Re: [Buildroot] [PATCH 15/16 v2] core/show-info: report package build steps and stamp files

[Thomas Petazzoni <thomas.petazzoni@bootlin.com>]

On Sat, 13 Nov 2021 14:28:26 +0100
"Yann E. MORIN" <yann.morin.1998@free.fr> wrote:

> People (and their scripts!) whi want to report on the progress of the
> build, will need to know what steps a package follows in what order.
> 
> This is handled internally by Buildroot itself already, by use of stamp
> files.
> 
> However, the names of those stamp files are purely an implementation
> detail (even if they are very unlikely to ever change).
> 
> Expose the build steps in a list, which is guaranteed to be ordered, ad
> for each step, its name and stamp file. The output (once filtered
> through jq, elided for bevity) will look like:
> 
>     [...]
>     "install_target": true,
>     "install_staging": false,
>     "install_images": false,
>     "build_steps": [
>       {
>         "step": "download",
>         "stamp_file": ".stamp_downloaded"
>       },
>       {
>         "step": "extract",
>         "stamp_file": ".stamp_extracted"
>       },
>       {
>         "step": "patch",
>         "stamp_file": ".stamp_patched"
>       },
>       {
>         "step": "configure",
>         "stamp_file": ".stamp_configured"
>       },
>       {
>         "step": "build",
>         "stamp_file": ".stamp_built"
>       },
>       {
>         "step": "install_target",
>         "stamp_file": ".stamp_target_installed"
>       }
>     ],
>     [...]
> 
> (Note: the first three fields already existed before this patch.)
> 
> Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
> Cc: Vadim Kochan <vadim4j@gmail.com>
> Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> Cc: Arnout Vandecappelle <arnout@mind.be>
> Cc: eeppeliteloop@gmail.com

This one I really found excessive. There's pretty a 1:1 relationship
between the steps and the stamp files, so anything that has knowledge
of the internal steps of a package can also know about the stamp files.

As it's more controversial than the rest of the series, I left it
aside. I'll for now mark it as Rejected, but I'm also ready to revisit
that if need be.

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot