Re: [Buildroot] [PATCH v1 1/3] package/liboping: add patch to fix gcc-8/gcc-9 snprintf truncation compile failure

From: Peter Seiderer <ps.report@gmx.net>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: buildroot@busybox.net,
	Fabrice Fontaine <fontaine.fabrice@gmail.com>,
	Maik Brenke <Maik.Brenke@continental-corporation.com>
Subject: Re: [Buildroot] [PATCH v1 1/3] package/liboping: add patch to fix gcc-8/gcc-9 snprintf truncation compile failure
Date: Fri, 31 Dec 2021 00:14:13 +0100	[thread overview]
Message-ID: <20211231001413.26ef092b@gmx.net> (raw)
In-Reply-To: <20211230161150.7b073fc6@windsurf>

Hello Thomas,

On Thu, 30 Dec 2021 16:11:50 +0100, Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:

> Hello Peter,
> 
> On Fri,  6 Mar 2020 21:10:20 +0100
> Peter Seiderer <ps.report@gmx.net> wrote:
> 
> > Add patch from upstream merge request ([1]) to fix fix gcc-8/gcc-9 snprintf
> > truncation related compile failure (-Wall/-Werror), reported on the
> > mailing list ([2]).
> > 
> > Fixes:
> > 
> >   liboping.c: In function ‘ping_set_ttl’:
> >   liboping.c:207:9: error: ‘%s’ directive output may be truncated writing up to 255 bytes into a region of size 242 [-Werror=format-truncation=]
> >     207 |    "%s: %s", function, message);
> >         |         ^~
> > 
> > [1] https://github.com/octo/liboping/pull/50
> > [2] http://lists.busybox.net/pipermail/buildroot/2020-March/275861.html
> > 
> > Reported-by: Maik Brenke <Maik.Brenke@continental-corporation.com>
> > Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> > ---
> >  ...d-snprintf-truncation-warning-wError.patch | 31 +++++++++++++++++++
> >  1 file changed, 31 insertions(+)
> >  create mode 100644 package/liboping/0002-Mitigated-snprintf-truncation-warning-wError.patch  
> 
> So I'm sorry, but the problem still didn't occur. I've tried using gcc
> 8.x and 9.x toolchains, haven't been able to see, and neither were the
> autobuilders.
> 
> So for now, I'll mark this patch as Rejected, but if you have a
> reproducer, we can certainly reconsider this.

Still reproducible with the following defconfig:

BR2_arm=y
BR2_arm1176jzf_s=y
BR2_OPTIMIZE_3=y
BR2_FORTIFY_SOURCE_NONE=y
BR2_TOOLCHAIN_BUILDROOT_GLIBC=y
BR2_GCC_VERSION_9_X=y
BR2_TOOLCHAIN_BUILDROOT_CXX=y
BR2_PACKAGE_LIBOPING=y

Regards,
Peter

> 
> Best regards,
> 
> Thomas

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot