All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Fabien DESSENNE <fabien.dessenne@st.com>
Cc: Vincent ABRIOU <vincent.abriou@st.com>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"kernel@stlinux.com" <kernel@stlinux.com>
Subject: Re: [PATCH] drm: Set depth and bpp for XRGB4444 family formats
Date: Fri, 09 Sep 2016 12:09:36 +0300	[thread overview]
Message-ID: <20214565.GgAVjhbUkG@avalon> (raw)
In-Reply-To: <648905f5-dc2c-2628-542a-f357a2fcb808@st.com>

Hi Fabien,

On Friday 19 Aug 2016 11:01:37 Fabien DESSENNE wrote:
> Hi Laurent,
> 
> Daniel talked about a planned reorg from you around DRM formats (or
> something like this) and I have proposed to fix some missing parts with
> the XRGB444 formats.
> 
> Can you let us know if you can consider this fix as part of your reorg?

I don't, because it's already there :-) See "[PATCH v4 00/14] Centralize 
format information" posted to this mailing list.

The series removes the drm_fb_get_bpp_depth() function. You have several 
options:

- Use drm_format_info() to retrieve format information that include the depth 
and the number of bytes per pixel per plane.

- Use drm_format_plane_cpp() if you only need the number of bytes per pixel 
per plane.

- Check the formats directly in your driver instead of basing decisions on the 
number of bytes per pixel, as Daniel mentioned.

> If you can't what would be the best option to get this fixed?

-- 
Regards,

Laurent Pinchart

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

      reply	other threads:[~2016-09-09  9:09 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-10  9:21 [PATCH] drm: Set depth and bpp for XRGB4444 family formats Fabien Dessenne
2016-08-10 10:35 ` Daniel Vetter
2016-08-10 11:04   ` Fabien DESSENNE
2016-08-10 14:12     ` Daniel Vetter
2016-08-10 15:26       ` Fabien DESSENNE
2016-08-10 16:57         ` Daniel Vetter
2016-08-10 17:11           ` Ville Syrjälä
2016-08-19  9:01         ` Fabien DESSENNE
2016-09-09  9:09           ` Laurent Pinchart [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20214565.GgAVjhbUkG@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=fabien.dessenne@st.com \
    --cc=kernel@stlinux.com \
    --cc=vincent.abriou@st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.