From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============6670397781124611504==" MIME-Version: 1.0 From: kernel test robot To: kbuild-all@lists.01.org Subject: Re: [PATCH v5 04/14] media: cadence: csi2rx: Add external DPHY support Date: Sat, 01 Jan 2022 11:07:53 +0800 Message-ID: <202201011112.jOhq9ZhX-lkp@intel.com> In-Reply-To: <20211223191615.17803-5-p.yadav@ti.com> List-Id: --===============6670397781124611504== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi Pratyush, I love your patch! Yet something to improve: [auto build test ERROR on media-tree/master] [also build test ERROR on robh/for-next linus/master v5.16-rc7 next-2021122= 4] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Pratyush-Yadav/CSI2RX-supp= ort-on-J721E/20211224-031826 base: git://linuxtv.org/media_tree.git master config: i386-randconfig-a001-20220101 (https://download.01.org/0day-ci/arch= ive/20220101/202201011112.jOhq9ZhX-lkp(a)intel.com/config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce (this is a W=3D1 build): # https://github.com/0day-ci/linux/commit/c4496ba026bf59690831a4ece= 96bce5c10bde0bf git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Pratyush-Yadav/CSI2RX-support-on-J= 721E/20211224-031826 git checkout c4496ba026bf59690831a4ece96bce5c10bde0bf # save the config file to linux build tree mkdir build_dir make W=3D1 O=3Dbuild_dir ARCH=3Di386 SHELL=3D/bin/bash If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): ld: drivers/media/platform/cadence/cdns-csi2rx.o: in function `csi2rx_co= nfigure_external_dphy': >> drivers/media/platform/cadence/cdns-csi2rx.c:168: undefined reference to= `phy_mipi_dphy_get_default_config' vim +168 drivers/media/platform/cadence/cdns-csi2rx.c 145 = 146 static int csi2rx_configure_external_dphy(struct csi2rx_priv *csi2rx) 147 { 148 union phy_configure_opts opts =3D { }; 149 struct phy_configure_opts_mipi_dphy *cfg =3D &opts.mipi_dphy; 150 const struct csi2rx_fmt *fmt; 151 s64 pixel_clock; 152 int ret; 153 u8 bpp; 154 bool got_pm =3D true; 155 = 156 fmt =3D csi2rx_get_fmt_by_code(csi2rx->fmt.code); 157 bpp =3D fmt->bpp; 158 = 159 /* 160 * Do not divide by the number of lanes here. That will be done by 161 * phy_mipi_dphy_get_default_config(). 162 */ 163 pixel_clock =3D v4l2_get_link_freq(csi2rx->source_subdev->ctrl_hand= ler, 164 1, 2); 165 if (pixel_clock < 0) 166 return pixel_clock; 167 = > 168 ret =3D phy_mipi_dphy_get_default_config(pixel_clock, bpp, 169 csi2rx->num_lanes, cfg); 170 if (ret) 171 return ret; 172 = 173 ret =3D phy_pm_runtime_get_sync(csi2rx->dphy); 174 if (ret =3D=3D -ENOTSUPP) 175 got_pm =3D false; 176 else if (ret < 0) 177 return ret; 178 = 179 ret =3D phy_power_on(csi2rx->dphy); 180 if (ret) 181 goto out; 182 = 183 ret =3D phy_configure(csi2rx->dphy, &opts); 184 if (ret) { 185 /* Can't do anything if it fails. Ignore the return value. */ 186 phy_power_off(csi2rx->dphy); 187 goto out; 188 } 189 = 190 out: 191 if (got_pm) 192 phy_pm_runtime_put(csi2rx->dphy); 193 = 194 return ret; 195 } 196 = --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org --===============6670397781124611504==--