From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2785C2C82 for ; Sat, 1 Jan 2022 22:58:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1641077888; x=1672613888; h=date:from:to:cc:subject:message-id:mime-version; bh=7SK0DU34lm4A76mU+OTQXk/ZoNkBeoIrXAV+IY98qgg=; b=FZFaSeoy5pEDW34zH/fHjiQY/aWY1N7/k+unpmoI7ygzAOQVEljE6Zpn NurzF0frVb3ErVVqNdwxv09/RM/0R2lWNxeMYcQJGExtmpVGlo728oDQd bPA+yzqQYLHAdgTIdszXGZAvs4In80TzatOWV89DMrqi16N5x/1jLyavP jDz21ljMfNUyT+0lUMRv8GVap1MXBKlApxulKK2Otx8oaoKBFE1uonY7Y BCIGXaTgmSY+kRScPUGVJ7xzoEFxlLFxNEkF+znseLzu+qmhjJ0n5hsyV 9U61sadTeKpDQxoCSynIVk0F2ksfanmLMerOkzLnv5G73tnm50ccHxz/q A==; X-IronPort-AV: E=McAfee;i="6200,9189,10214"; a="328262783" X-IronPort-AV: E=Sophos;i="5.88,254,1635231600"; d="scan'208";a="328262783" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Jan 2022 14:58:07 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,254,1635231600"; d="scan'208";a="610412205" Received: from lkp-server01.sh.intel.com (HELO e357b3ef1427) ([10.239.97.150]) by FMSMGA003.fm.intel.com with ESMTP; 01 Jan 2022 14:58:05 -0800 Received: from kbuild by e357b3ef1427 with local (Exim 4.92) (envelope-from ) id 1n3nK9-000CrP-AG; Sat, 01 Jan 2022 22:58:05 +0000 Date: Sun, 2 Jan 2022 06:58:00 +0800 From: kernel test robot To: Arnd Bergmann Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, Jessica Yu , Sami Tolvanen , Miroslav Benes Subject: kernel/module.c:4478:14: warning: variable 'exit' set but not used Message-ID: <202201020600.rl5oKvlD-lkp@intel.com> Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) Hi Arnd, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 278218f6778bc7d6f8b67199446c56cec7ebb841 commit: 0d67e332e6df72f43eaa21228daa3a79e23093f3 module: fix clang CFI with MODULE_UNLOAD=n date: 3 months ago config: arm64-randconfig-r022-20220101 (https://download.01.org/0day-ci/archive/20220102/202201020600.rl5oKvlD-lkp@intel.com/config) compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 7cd109b92c72855937273a6c8ab19016fbe27d33) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install arm64 cross compiling tool for clang build # apt-get install binutils-aarch64-linux-gnu # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=0d67e332e6df72f43eaa21228daa3a79e23093f3 git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git git fetch --no-tags linus master git checkout 0d67e332e6df72f43eaa21228daa3a79e23093f3 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): >> kernel/module.c:4478:14: warning: variable 'exit' set but not used [-Wunused-but-set-variable] exitcall_t *exit; ^ 1 warning generated. vim +/exit +4478 kernel/module.c ^1da177e4c3f41 Linus Torvalds 2005-04-16 4473 cf68fffb66d60d Sami Tolvanen 2021-04-08 4474 static void cfi_init(struct module *mod) cf68fffb66d60d Sami Tolvanen 2021-04-08 4475 { cf68fffb66d60d Sami Tolvanen 2021-04-08 4476 #ifdef CONFIG_CFI_CLANG cf68fffb66d60d Sami Tolvanen 2021-04-08 4477 initcall_t *init; cf68fffb66d60d Sami Tolvanen 2021-04-08 @4478 exitcall_t *exit; cf68fffb66d60d Sami Tolvanen 2021-04-08 4479 cf68fffb66d60d Sami Tolvanen 2021-04-08 4480 rcu_read_lock_sched(); cf68fffb66d60d Sami Tolvanen 2021-04-08 4481 mod->cfi_check = (cfi_check_fn) cf68fffb66d60d Sami Tolvanen 2021-04-08 4482 find_kallsyms_symbol_value(mod, "__cfi_check"); cf68fffb66d60d Sami Tolvanen 2021-04-08 4483 init = (initcall_t *) cf68fffb66d60d Sami Tolvanen 2021-04-08 4484 find_kallsyms_symbol_value(mod, "__cfi_jt_init_module"); cf68fffb66d60d Sami Tolvanen 2021-04-08 4485 exit = (exitcall_t *) cf68fffb66d60d Sami Tolvanen 2021-04-08 4486 find_kallsyms_symbol_value(mod, "__cfi_jt_cleanup_module"); cf68fffb66d60d Sami Tolvanen 2021-04-08 4487 rcu_read_unlock_sched(); cf68fffb66d60d Sami Tolvanen 2021-04-08 4488 cf68fffb66d60d Sami Tolvanen 2021-04-08 4489 /* Fix init/exit functions to point to the CFI jump table */ cf68fffb66d60d Sami Tolvanen 2021-04-08 4490 if (init) cf68fffb66d60d Sami Tolvanen 2021-04-08 4491 mod->init = *init; 0d67e332e6df72 Arnd Bergmann 2021-09-27 4492 #ifdef CONFIG_MODULE_UNLOAD cf68fffb66d60d Sami Tolvanen 2021-04-08 4493 if (exit) cf68fffb66d60d Sami Tolvanen 2021-04-08 4494 mod->exit = *exit; 0d67e332e6df72 Arnd Bergmann 2021-09-27 4495 #endif cf68fffb66d60d Sami Tolvanen 2021-04-08 4496 cf68fffb66d60d Sami Tolvanen 2021-04-08 4497 cfi_module_add(mod, module_addr_min); cf68fffb66d60d Sami Tolvanen 2021-04-08 4498 #endif cf68fffb66d60d Sami Tolvanen 2021-04-08 4499 } cf68fffb66d60d Sami Tolvanen 2021-04-08 4500 :::::: The code at line 4478 was first introduced by commit :::::: cf68fffb66d60d96209446bfc4a15291dc5a5d41 add support for Clang CFI :::::: TO: Sami Tolvanen :::::: CC: Kees Cook --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============8204215421245566077==" MIME-Version: 1.0 From: kernel test robot To: kbuild-all@lists.01.org Subject: kernel/module.c:4478:14: warning: variable 'exit' set but not used Date: Sun, 02 Jan 2022 06:58:00 +0800 Message-ID: <202201020600.rl5oKvlD-lkp@intel.com> List-Id: --===============8204215421245566077== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi Arnd, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git = master head: 278218f6778bc7d6f8b67199446c56cec7ebb841 commit: 0d67e332e6df72f43eaa21228daa3a79e23093f3 module: fix clang CFI with= MODULE_UNLOAD=3Dn date: 3 months ago config: arm64-randconfig-r022-20220101 (https://download.01.org/0day-ci/arc= hive/20220102/202201020600.rl5oKvlD-lkp(a)intel.com/config) compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 7cd109= b92c72855937273a6c8ab19016fbe27d33) reproduce (this is a W=3D1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/= make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install arm64 cross compiling tool for clang build # apt-get install binutils-aarch64-linux-gnu # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.gi= t/commit/?id=3D0d67e332e6df72f43eaa21228daa3a79e23093f3 git remote add linus https://git.kernel.org/pub/scm/linux/kernel/gi= t/torvalds/linux.git git fetch --no-tags linus master git checkout 0d67e332e6df72f43eaa21228daa3a79e23093f3 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dclang make.cross W=3D= 1 O=3Dbuild_dir ARCH=3Darm64 SHELL=3D/bin/bash If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): >> kernel/module.c:4478:14: warning: variable 'exit' set but not used [-Wun= used-but-set-variable] exitcall_t *exit; ^ 1 warning generated. vim +/exit +4478 kernel/module.c ^1da177e4c3f41 Linus Torvalds 2005-04-16 4473 = cf68fffb66d60d Sami Tolvanen 2021-04-08 4474 static void cfi_init(struct= module *mod) cf68fffb66d60d Sami Tolvanen 2021-04-08 4475 { cf68fffb66d60d Sami Tolvanen 2021-04-08 4476 #ifdef CONFIG_CFI_CLANG cf68fffb66d60d Sami Tolvanen 2021-04-08 4477 initcall_t *init; cf68fffb66d60d Sami Tolvanen 2021-04-08 @4478 exitcall_t *exit; cf68fffb66d60d Sami Tolvanen 2021-04-08 4479 = cf68fffb66d60d Sami Tolvanen 2021-04-08 4480 rcu_read_lock_sched(); cf68fffb66d60d Sami Tolvanen 2021-04-08 4481 mod->cfi_check =3D (cfi_ch= eck_fn) cf68fffb66d60d Sami Tolvanen 2021-04-08 4482 find_kallsyms_symbol_valu= e(mod, "__cfi_check"); cf68fffb66d60d Sami Tolvanen 2021-04-08 4483 init =3D (initcall_t *) cf68fffb66d60d Sami Tolvanen 2021-04-08 4484 find_kallsyms_symbol_valu= e(mod, "__cfi_jt_init_module"); cf68fffb66d60d Sami Tolvanen 2021-04-08 4485 exit =3D (exitcall_t *) cf68fffb66d60d Sami Tolvanen 2021-04-08 4486 find_kallsyms_symbol_valu= e(mod, "__cfi_jt_cleanup_module"); cf68fffb66d60d Sami Tolvanen 2021-04-08 4487 rcu_read_unlock_sched(); cf68fffb66d60d Sami Tolvanen 2021-04-08 4488 = cf68fffb66d60d Sami Tolvanen 2021-04-08 4489 /* Fix init/exit functions= to point to the CFI jump table */ cf68fffb66d60d Sami Tolvanen 2021-04-08 4490 if (init) cf68fffb66d60d Sami Tolvanen 2021-04-08 4491 mod->init =3D *init; 0d67e332e6df72 Arnd Bergmann 2021-09-27 4492 #ifdef CONFIG_MODULE_UNLOAD cf68fffb66d60d Sami Tolvanen 2021-04-08 4493 if (exit) cf68fffb66d60d Sami Tolvanen 2021-04-08 4494 mod->exit =3D *exit; 0d67e332e6df72 Arnd Bergmann 2021-09-27 4495 #endif cf68fffb66d60d Sami Tolvanen 2021-04-08 4496 = cf68fffb66d60d Sami Tolvanen 2021-04-08 4497 cfi_module_add(mod, module= _addr_min); cf68fffb66d60d Sami Tolvanen 2021-04-08 4498 #endif cf68fffb66d60d Sami Tolvanen 2021-04-08 4499 } cf68fffb66d60d Sami Tolvanen 2021-04-08 4500 = :::::: The code at line 4478 was first introduced by commit :::::: cf68fffb66d60d96209446bfc4a15291dc5a5d41 add support for Clang CFI :::::: TO: Sami Tolvanen :::::: CC: Kees Cook --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org --===============8204215421245566077==--