From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 45F36C433F5 for ; Sun, 2 Jan 2022 23:47:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EX7qZB5ff4U3PyAsyDfLrkvorJJ0foR02kxRPVXGovE=; b=JGuNO0Pgf3V4hc mAlKAkmvZsyS8Z+70PuMp0+VkJHIR7X77d2rw/2tX0xs9gkcHs0vgmp5QMXO04Hs0gGo54YIw37DT Aq5L7GaJvlcI8rVtPHt+CRjJ2EvPjcIrS84Cq2ZLmdoiaZwYAo2ztN6za4SHxbJPnNumAdJYPMNM8 WCdVkVRDaiijPtCvf7om6Bb/+W5aIyBsVfzPwAepDW8b3Pwku3Sjwc/YQg61sl3vgpelgmWNaL28K V7mRFyzXIMOBCI83TLEDI4u5P674OkKR4jD5B52R0JQxWDE9B4OphCaW7m7zG4uDF+CdANwxL6N0w ICLS7ofnanEQ7Vjp0Rmg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n4AZA-008EC9-QE; Sun, 02 Jan 2022 23:47:08 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n4AYw-008EAs-TZ; Sun, 02 Jan 2022 23:46:57 +0000 X-UUID: 6114f70182ff445d8e3b8e9d5a0f3e26-20220102 X-UUID: 6114f70182ff445d8e3b8e9d5a0f3e26-20220102 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1682304121; Sun, 02 Jan 2022 16:46:49 -0700 Received: from mtkexhb02.mediatek.inc (172.21.101.103) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sun, 2 Jan 2022 15:46:48 -0800 Received: from mtkcas10.mediatek.inc (172.21.101.39) by mtkexhb02.mediatek.inc (172.21.101.103) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 3 Jan 2022 07:46:34 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by mtkcas10.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 3 Jan 2022 07:46:34 +0800 From: To: , Nathan Chancellor , "Nick Desaulniers" , Jie Qiu , "Junzhi Zhao" , Philipp Zabel CC: , , , , , , , , Subject: Re: [PATCH v3] drm/mediatek: Fix unused-but-set variable warning Date: Mon, 3 Jan 2022 07:46:32 +0800 Message-ID: <20220102234633.31709-1-miles.chen@mediatek.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: References: MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220102_154654_979579_2D14DA90 X-CRM114-Status: UNSURE ( 9.97 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org > I'm still not happy with the commit subject, I think it is misleading. Clang > only helped to find the bug, but the we are fixing something else, that's not > just a clang warning. But I don't want to nit-pick too much so: > > Reviewed-by: Matthias Brugger thanks. I think you are right. I will change the subject to "drm/mediatek: Fix mtk_cec_mask()", remove the clang part and submit patch v4. e.g, """ drm/mediatek: Fix mtk_cec_mask() In current implementation, mtk_cec_mask() writes val into target register and ignores the mask. After talking to our hdmi experts, mtk_cec_mask() should read a register, clean only mask bits, and update (val | mask) bits to the register. Fixes: 8f83f26891e1 ("drm/mediatek: Add HDMI support") """ _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD0F52C80 for ; Sun, 2 Jan 2022 23:51:47 +0000 (UTC) X-UUID: e16f94d125c744a79ed82d7091faa024-20220103 X-UUID: e16f94d125c744a79ed82d7091faa024-20220103 Received: from mtkcas10.mediatek.inc [(172.21.101.39)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1794068794; Mon, 03 Jan 2022 07:46:36 +0800 Received: from mtkexhb02.mediatek.inc (172.21.101.103) by mtkmbs07n1.mediatek.inc (172.21.101.16) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 3 Jan 2022 07:46:34 +0800 Received: from mtkcas10.mediatek.inc (172.21.101.39) by mtkexhb02.mediatek.inc (172.21.101.103) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 3 Jan 2022 07:46:34 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by mtkcas10.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 3 Jan 2022 07:46:34 +0800 From: To: , Nathan Chancellor , "Nick Desaulniers" , Jie Qiu , "Junzhi Zhao" , Philipp Zabel CC: , , , , , , , , Subject: Re: [PATCH v3] drm/mediatek: Fix unused-but-set variable warning Date: Mon, 3 Jan 2022 07:46:32 +0800 Message-ID: <20220102234633.31709-1-miles.chen@mediatek.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain X-MTK: N > I'm still not happy with the commit subject, I think it is misleading. Clang > only helped to find the bug, but the we are fixing something else, that's not > just a clang warning. But I don't want to nit-pick too much so: > > Reviewed-by: Matthias Brugger thanks. I think you are right. I will change the subject to "drm/mediatek: Fix mtk_cec_mask()", remove the clang part and submit patch v4. e.g, """ drm/mediatek: Fix mtk_cec_mask() In current implementation, mtk_cec_mask() writes val into target register and ignores the mask. After talking to our hdmi experts, mtk_cec_mask() should read a register, clean only mask bits, and update (val | mask) bits to the register. Fixes: 8f83f26891e1 ("drm/mediatek: Add HDMI support") """ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C4BCBC433EF for ; Sun, 2 Jan 2022 23:48:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HSROSy1GfvPA9C+cVkOOaIJ8YfaHWai4z4dJbbkkjzY=; b=0glDkgre0VT9KW vIXlJZ0hepDG/N2+b6GVBfBMbrNSZtsWvDzlDX/11Q2j5uZ/oLu0bnLf7xUoK1P95WQQy2U49e17A TBKKg0B/hzdNzZZxO03n9Q91g51x34Qr0g+6UZfE+vu8QOI8gNH4BSbB93OI+CRx90N6H0+dSpQ+w BTzEbBTz4xVW62VUizX67UouznAST924W8+nYrl4UB4Yu1Dbte20B38myj/0lkKXtdhwI9ZCtwI1z hiqwi2kZ2oQOGHwSuabiWVSTYh1oX3xGqu+zR3ado6X4fPh0M7gzfoLayhyUbyMlD0I0UoH9RYw6d dDkzZmoxsD6N1IPkSEaA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n4AZ1-008EBv-E7; Sun, 02 Jan 2022 23:46:59 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n4AYw-008EAs-TZ; Sun, 02 Jan 2022 23:46:57 +0000 X-UUID: 6114f70182ff445d8e3b8e9d5a0f3e26-20220102 X-UUID: 6114f70182ff445d8e3b8e9d5a0f3e26-20220102 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1682304121; Sun, 02 Jan 2022 16:46:49 -0700 Received: from mtkexhb02.mediatek.inc (172.21.101.103) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sun, 2 Jan 2022 15:46:48 -0800 Received: from mtkcas10.mediatek.inc (172.21.101.39) by mtkexhb02.mediatek.inc (172.21.101.103) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 3 Jan 2022 07:46:34 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by mtkcas10.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 3 Jan 2022 07:46:34 +0800 From: To: , Nathan Chancellor , "Nick Desaulniers" , Jie Qiu , "Junzhi Zhao" , Philipp Zabel CC: , , , , , , , , Subject: Re: [PATCH v3] drm/mediatek: Fix unused-but-set variable warning Date: Mon, 3 Jan 2022 07:46:32 +0800 Message-ID: <20220102234633.31709-1-miles.chen@mediatek.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: References: MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220102_154654_979579_2D14DA90 X-CRM114-Status: UNSURE ( 9.97 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > I'm still not happy with the commit subject, I think it is misleading. Clang > only helped to find the bug, but the we are fixing something else, that's not > just a clang warning. But I don't want to nit-pick too much so: > > Reviewed-by: Matthias Brugger thanks. I think you are right. I will change the subject to "drm/mediatek: Fix mtk_cec_mask()", remove the clang part and submit patch v4. e.g, """ drm/mediatek: Fix mtk_cec_mask() In current implementation, mtk_cec_mask() writes val into target register and ignores the mask. After talking to our hdmi experts, mtk_cec_mask() should read a register, clean only mask bits, and update (val | mask) bits to the register. Fixes: 8f83f26891e1 ("drm/mediatek: Add HDMI support") """ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4C2F7C433F5 for ; Mon, 3 Jan 2022 08:40:05 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BAF1710E1C3; Mon, 3 Jan 2022 08:39:58 +0000 (UTC) Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) by gabe.freedesktop.org (Postfix) with ESMTPS id 85F3189444 for ; Sun, 2 Jan 2022 23:46:41 +0000 (UTC) X-UUID: e16f94d125c744a79ed82d7091faa024-20220103 X-UUID: e16f94d125c744a79ed82d7091faa024-20220103 Received: from mtkcas10.mediatek.inc [(172.21.101.39)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1794068794; Mon, 03 Jan 2022 07:46:36 +0800 Received: from mtkexhb02.mediatek.inc (172.21.101.103) by mtkmbs07n1.mediatek.inc (172.21.101.16) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 3 Jan 2022 07:46:34 +0800 Received: from mtkcas10.mediatek.inc (172.21.101.39) by mtkexhb02.mediatek.inc (172.21.101.103) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 3 Jan 2022 07:46:34 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by mtkcas10.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 3 Jan 2022 07:46:34 +0800 From: To: , Nathan Chancellor , "Nick Desaulniers" , Jie Qiu , "Junzhi Zhao" , Philipp Zabel Subject: Re: [PATCH v3] drm/mediatek: Fix unused-but-set variable warning Date: Mon, 3 Jan 2022 07:46:32 +0800 Message-ID: <20220102234633.31709-1-miles.chen@mediatek.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain X-MTK: N X-Mailman-Approved-At: Mon, 03 Jan 2022 08:39:57 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: chunkuang.hu@kernel.org, airlied@linux.ie, llvm@lists.linux.dev, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, miles.chen@mediatek.com, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" > I'm still not happy with the commit subject, I think it is misleading. Clang > only helped to find the bug, but the we are fixing something else, that's not > just a clang warning. But I don't want to nit-pick too much so: > > Reviewed-by: Matthias Brugger thanks. I think you are right. I will change the subject to "drm/mediatek: Fix mtk_cec_mask()", remove the clang part and submit patch v4. e.g, """ drm/mediatek: Fix mtk_cec_mask() In current implementation, mtk_cec_mask() writes val into target register and ignores the mask. After talking to our hdmi experts, mtk_cec_mask() should read a register, clean only mask bits, and update (val | mask) bits to the register. Fixes: 8f83f26891e1 ("drm/mediatek: Add HDMI support") """