From mboxrd@z Thu Jan 1 00:00:00 1970 From: Miquel Raynal Date: Mon, 3 Jan 2022 17:17:21 +0100 Subject: [PATCH] mtd: aspeed-smc: improve probe resilience In-Reply-To: <20211231102623.izaqlzjvracbbgmp@ti.com> References: <20211229143334.297305-1-patrick@stwcx.xyz> <20211229173411.l2bipmi4x3arqjoo@ti.com> <20211231102623.izaqlzjvracbbgmp@ti.com> Message-ID: <20220103171721.46c8e697@xps13> List-Id: To: linux-aspeed@lists.ozlabs.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Hello, p.yadav at ti.com wrote on Fri, 31 Dec 2021 15:56:25 +0530: > Hi Patrick, > > On 30/12/21 09:29AM, Patrick Williams wrote: > > On Wed, Dec 29, 2021 at 11:04:13PM +0530, Pratyush Yadav wrote: > > > Hi, > > > > > > On 29/12/21 08:33AM, Patrick Williams wrote: > > > > > The patch itself looks fine to me but we no longer want to maintain > > > drivers under drivers/mtd/spi-nor/controllers/. They should be moved to > > > implement the SPI MEM API (under drivers/spi/). > > > > Is the linux-aspeed community aware of this? Are you saying you don't want to > > take fixes for their driver into the MTD tree? Can it be pulled into the Aspeed > > tree? > > I am fine with taking in bug fixes but no longer want to take in any new > features. My main intention was to nudge you to convert it to SPI MEM > regardless of whether this is a bug fix or a new feature, because > eventually we want to get rid of drivers/mtd/spi-nor/controllers/ and > the API that comes along with it. I totally agree with Pratyush here, we no longer want to support the spi-nor controller API so if, as you say, there are boards failing in the field, it means there are still users and these users must be warned that at some point we might discontinue the support of these drivers if it becomes too painful. > As for your patch, I certainly don't want it to go via the aspeed tree. Definitely, no. > It should go via the MTD tree or not at all. I am not quite sure if this > counts as a bug fix or a new feature though. > > > > > > Could you please volunteer to do the conversion for this driver? > > > > I'm not personally going to be able to get to it for at least the next 3 months. > > > > It looks like we don't have a dedicated maintainer for this driver other than > > Joel by nature of him being listed as the maintainer of "ARM/ASPEED MACHINE > > SUPPORT". I'm not sure if Aspeed themselves are planning on doing the necessary > > refactoring here. > > > > > > Joel, are you aware of this driver using a deprecated implementation? Were > > there anyone planning to do the reworks that you are aware of? I'd like to get > > this fix at least into the OpenBMC kernel tree because I'm seeing this fail in > > the real world. > Thanks, Miqu?l From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 81E26C433EF for ; Mon, 3 Jan 2022 16:18:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=klSuO3pMtu8O/dvbQ9EkL/3+9oCLKRaa5MM/agkouqI=; b=GeOHx0RCuLxy1K 6VCyO+RWNf1bYWWXwuWNmJNPrZveMTmBAZAi0kOVnID3fT8FBRbfItisLviWZXxApYhNAFQUgoyow LPAjM9juYg9IPSufWp8JhPN8ZaKaY9EywGZqV14J00KBBh2cETXIWBw1mYGQ/a27NCLMfHfncx3Uk 6VNUVXP0xE7BAIbar3yn+nypSMHiLVkcYpDC0+YoZYfGleK0ZQnWqzQv0sRcu90XRQwet5vNyctPc oRjCGGFkI5Eu30/jYV82JbQOURoIVs6xnLZgKfjczRaZ8vF3ngfSWOCMj33W4Rn3c6IT4gFm9g+LX Vginsx1iFn+BYLkziTkA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n4Q1l-009Rgy-RK; Mon, 03 Jan 2022 16:17:41 +0000 Received: from relay12.mail.gandi.net ([217.70.178.232]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n4Q1a-009RfJ-8u; Mon, 03 Jan 2022 16:17:31 +0000 Received: (Authenticated sender: miquel.raynal@bootlin.com) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 49201200006; Mon, 3 Jan 2022 16:17:23 +0000 (UTC) Date: Mon, 3 Jan 2022 17:17:21 +0100 From: Miquel Raynal To: Pratyush Yadav Cc: Patrick Williams , Joel Stanley , Tudor Ambarus , Michael Walle , Richard Weinberger , Vignesh Raghavendra , Andrew Jeffery , Potin Lai , , , , Subject: Re: [PATCH] mtd: aspeed-smc: improve probe resilience Message-ID: <20220103171721.46c8e697@xps13> In-Reply-To: <20211231102623.izaqlzjvracbbgmp@ti.com> References: <20211229143334.297305-1-patrick@stwcx.xyz> <20211229173411.l2bipmi4x3arqjoo@ti.com> <20211231102623.izaqlzjvracbbgmp@ti.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220103_081730_472769_8D2D5374 X-CRM114-Status: GOOD ( 29.14 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGVsbG8sCgpwLnlhZGF2QHRpLmNvbSB3cm90ZSBvbiBGcmksIDMxIERlYyAyMDIxIDE1OjU2OjI1 ICswNTMwOgoKPiBIaSBQYXRyaWNrLAo+IAo+IE9uIDMwLzEyLzIxIDA5OjI5QU0sIFBhdHJpY2sg V2lsbGlhbXMgd3JvdGU6Cj4gPiBPbiBXZWQsIERlYyAyOSwgMjAyMSBhdCAxMTowNDoxM1BNICsw NTMwLCBQcmF0eXVzaCBZYWRhdiB3cm90ZTogIAo+ID4gPiBIaSwKPiA+ID4gCj4gPiA+IE9uIDI5 LzEyLzIxIDA4OjMzQU0sIFBhdHJpY2sgV2lsbGlhbXMgd3JvdGU6ICAKPiA+ICAgIAo+ID4gPiBU aGUgcGF0Y2ggaXRzZWxmIGxvb2tzIGZpbmUgdG8gbWUgYnV0IHdlIG5vIGxvbmdlciB3YW50IHRv IG1haW50YWluIAo+ID4gPiBkcml2ZXJzIHVuZGVyIGRyaXZlcnMvbXRkL3NwaS1ub3IvY29udHJv bGxlcnMvLiBUaGV5IHNob3VsZCBiZSBtb3ZlZCB0byAKPiA+ID4gaW1wbGVtZW50IHRoZSBTUEkg TUVNIEFQSSAodW5kZXIgZHJpdmVycy9zcGkvKS4gIAo+ID4gCj4gPiBJcyB0aGUgbGludXgtYXNw ZWVkIGNvbW11bml0eSBhd2FyZSBvZiB0aGlzPyAgQXJlIHlvdSBzYXlpbmcgeW91IGRvbid0IHdh bnQgdG8KPiA+IHRha2UgZml4ZXMgZm9yIHRoZWlyIGRyaXZlciBpbnRvIHRoZSBNVEQgdHJlZT8g IENhbiBpdCBiZSBwdWxsZWQgaW50byB0aGUgQXNwZWVkCj4gPiB0cmVlPyAgCj4gCj4gSSBhbSBm aW5lIHdpdGggdGFraW5nIGluIGJ1ZyBmaXhlcyBidXQgbm8gbG9uZ2VyIHdhbnQgdG8gdGFrZSBp biBhbnkgbmV3IAo+IGZlYXR1cmVzLiBNeSBtYWluIGludGVudGlvbiB3YXMgdG8gbnVkZ2UgeW91 IHRvIGNvbnZlcnQgaXQgdG8gU1BJIE1FTSAKPiByZWdhcmRsZXNzIG9mIHdoZXRoZXIgdGhpcyBp cyBhIGJ1ZyBmaXggb3IgYSBuZXcgZmVhdHVyZSwgYmVjYXVzZSAKPiBldmVudHVhbGx5IHdlIHdh bnQgdG8gZ2V0IHJpZCBvZiBkcml2ZXJzL210ZC9zcGktbm9yL2NvbnRyb2xsZXJzLyBhbmQgCj4g dGhlIEFQSSB0aGF0IGNvbWVzIGFsb25nIHdpdGggaXQuCgpJIHRvdGFsbHkgYWdyZWUgd2l0aCBQ cmF0eXVzaCBoZXJlLCB3ZSBubyBsb25nZXIgd2FudCB0byBzdXBwb3J0IHRoZQpzcGktbm9yIGNv bnRyb2xsZXIgQVBJIHNvIGlmLCBhcyB5b3Ugc2F5LCB0aGVyZSBhcmUgYm9hcmRzIGZhaWxpbmcK aW4gdGhlIGZpZWxkLCBpdCBtZWFucyB0aGVyZSBhcmUgc3RpbGwgdXNlcnMgYW5kIHRoZXNlIHVz ZXJzIG11c3QgYmUKd2FybmVkIHRoYXQgYXQgc29tZSBwb2ludCB3ZSBtaWdodCBkaXNjb250aW51 ZSB0aGUgc3VwcG9ydCBvZiB0aGVzZQpkcml2ZXJzIGlmIGl0IGJlY29tZXMgdG9vIHBhaW5mdWwu Cgo+IEFzIGZvciB5b3VyIHBhdGNoLCBJIGNlcnRhaW5seSBkb24ndCB3YW50IGl0IHRvIGdvIHZp YSB0aGUgYXNwZWVkIHRyZWUuCgpEZWZpbml0ZWx5LCBuby4KCj4gSXQgc2hvdWxkIGdvIHZpYSB0 aGUgTVREIHRyZWUgb3Igbm90IGF0IGFsbC4gSSBhbSBub3QgcXVpdGUgc3VyZSBpZiB0aGlzIAo+ IGNvdW50cyBhcyBhIGJ1ZyBmaXggb3IgYSBuZXcgZmVhdHVyZSB0aG91Z2guCj4gCj4gPiAgIAo+ ID4gPiBDb3VsZCB5b3UgcGxlYXNlIHZvbHVudGVlciB0byBkbyB0aGUgY29udmVyc2lvbiBmb3Ig dGhpcyBkcml2ZXI/ICAKPiA+IAo+ID4gSSdtIG5vdCBwZXJzb25hbGx5IGdvaW5nIHRvIGJlIGFi bGUgdG8gZ2V0IHRvIGl0IGZvciBhdCBsZWFzdCB0aGUgbmV4dCAzIG1vbnRocy4KPiA+IAo+ID4g SXQgbG9va3MgbGlrZSB3ZSBkb24ndCBoYXZlIGEgZGVkaWNhdGVkIG1haW50YWluZXIgZm9yIHRo aXMgZHJpdmVyIG90aGVyIHRoYW4KPiA+IEpvZWwgYnkgbmF0dXJlIG9mIGhpbSBiZWluZyBsaXN0 ZWQgYXMgdGhlIG1haW50YWluZXIgb2YgIkFSTS9BU1BFRUQgTUFDSElORQo+ID4gU1VQUE9SVCIu ICBJJ20gbm90IHN1cmUgaWYgQXNwZWVkIHRoZW1zZWx2ZXMgYXJlIHBsYW5uaW5nIG9uIGRvaW5n IHRoZSBuZWNlc3NhcnkKPiA+IHJlZmFjdG9yaW5nIGhlcmUuCj4gPiAKPiA+IAo+ID4gSm9lbCwg YXJlIHlvdSBhd2FyZSBvZiB0aGlzIGRyaXZlciB1c2luZyBhIGRlcHJlY2F0ZWQgaW1wbGVtZW50 YXRpb24/ICBXZXJlCj4gPiB0aGVyZSBhbnlvbmUgcGxhbm5pbmcgdG8gZG8gdGhlIHJld29ya3Mg dGhhdCB5b3UgYXJlIGF3YXJlIG9mPyAgSSdkIGxpa2UgdG8gZ2V0Cj4gPiB0aGlzIGZpeCBhdCBs ZWFzdCBpbnRvIHRoZSBPcGVuQk1DIGtlcm5lbCB0cmVlIGJlY2F1c2UgSSdtIHNlZWluZyB0aGlz IGZhaWwgaW4KPiA+IHRoZSByZWFsIHdvcmxkLiAgCj4gCgpUaGFua3MsCk1pcXXDqGwKCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51eCBN VEQgZGlzY3Vzc2lvbiBtYWlsaW5nIGxpc3QKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFp bG1hbi9saXN0aW5mby9saW51eC1tdGQvCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CC125C433F5 for ; Mon, 3 Jan 2022 16:18:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zJcccSztNAKOrAriV3J4Gvw6afKIadF6OUwiKfui8gI=; b=Imbnd0/BvqLIhm 4I6jmsjIGoQGVx+K163yiSOiIuWUamJSQclq19dz7Q31bJ21jbV5MNyzmlCCWz9IMLIg7SEfeDJ9H 6ZFwulhDJ9C+WN1qqZTb3/X6eG5r46ekQTJ41PZGwjlI8xIlpADiOrBr7M1wP2XcZjisj91QUg2O0 bHBhvuKBJIDiLHDleHkPvEhVvIyDVTjdVWJEx2B6F5KqEyFUAXwyaxuhWKesBgNBez6bmXNm24K55 dwl2q+dEYuoiiGoQDL5rLrcJHpXYspVxdU2yUa4LGaQ/nEVeWf3HLzi1rQFfSzDj0N+BBTPjdQwh2 Isi+lie8Ys9G5jLD3FpA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n4Q1d-009RgD-LL; Mon, 03 Jan 2022 16:17:33 +0000 Received: from relay12.mail.gandi.net ([217.70.178.232]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n4Q1a-009RfJ-8u; Mon, 03 Jan 2022 16:17:31 +0000 Received: (Authenticated sender: miquel.raynal@bootlin.com) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 49201200006; Mon, 3 Jan 2022 16:17:23 +0000 (UTC) Date: Mon, 3 Jan 2022 17:17:21 +0100 From: Miquel Raynal To: Pratyush Yadav Cc: Patrick Williams , Joel Stanley , Tudor Ambarus , Michael Walle , Richard Weinberger , Vignesh Raghavendra , Andrew Jeffery , Potin Lai , , , , Subject: Re: [PATCH] mtd: aspeed-smc: improve probe resilience Message-ID: <20220103171721.46c8e697@xps13> In-Reply-To: <20211231102623.izaqlzjvracbbgmp@ti.com> References: <20211229143334.297305-1-patrick@stwcx.xyz> <20211229173411.l2bipmi4x3arqjoo@ti.com> <20211231102623.izaqlzjvracbbgmp@ti.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220103_081730_472769_8D2D5374 X-CRM114-Status: GOOD ( 29.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGVsbG8sCgpwLnlhZGF2QHRpLmNvbSB3cm90ZSBvbiBGcmksIDMxIERlYyAyMDIxIDE1OjU2OjI1 ICswNTMwOgoKPiBIaSBQYXRyaWNrLAo+IAo+IE9uIDMwLzEyLzIxIDA5OjI5QU0sIFBhdHJpY2sg V2lsbGlhbXMgd3JvdGU6Cj4gPiBPbiBXZWQsIERlYyAyOSwgMjAyMSBhdCAxMTowNDoxM1BNICsw NTMwLCBQcmF0eXVzaCBZYWRhdiB3cm90ZTogIAo+ID4gPiBIaSwKPiA+ID4gCj4gPiA+IE9uIDI5 LzEyLzIxIDA4OjMzQU0sIFBhdHJpY2sgV2lsbGlhbXMgd3JvdGU6ICAKPiA+ICAgIAo+ID4gPiBU aGUgcGF0Y2ggaXRzZWxmIGxvb2tzIGZpbmUgdG8gbWUgYnV0IHdlIG5vIGxvbmdlciB3YW50IHRv IG1haW50YWluIAo+ID4gPiBkcml2ZXJzIHVuZGVyIGRyaXZlcnMvbXRkL3NwaS1ub3IvY29udHJv bGxlcnMvLiBUaGV5IHNob3VsZCBiZSBtb3ZlZCB0byAKPiA+ID4gaW1wbGVtZW50IHRoZSBTUEkg TUVNIEFQSSAodW5kZXIgZHJpdmVycy9zcGkvKS4gIAo+ID4gCj4gPiBJcyB0aGUgbGludXgtYXNw ZWVkIGNvbW11bml0eSBhd2FyZSBvZiB0aGlzPyAgQXJlIHlvdSBzYXlpbmcgeW91IGRvbid0IHdh bnQgdG8KPiA+IHRha2UgZml4ZXMgZm9yIHRoZWlyIGRyaXZlciBpbnRvIHRoZSBNVEQgdHJlZT8g IENhbiBpdCBiZSBwdWxsZWQgaW50byB0aGUgQXNwZWVkCj4gPiB0cmVlPyAgCj4gCj4gSSBhbSBm aW5lIHdpdGggdGFraW5nIGluIGJ1ZyBmaXhlcyBidXQgbm8gbG9uZ2VyIHdhbnQgdG8gdGFrZSBp biBhbnkgbmV3IAo+IGZlYXR1cmVzLiBNeSBtYWluIGludGVudGlvbiB3YXMgdG8gbnVkZ2UgeW91 IHRvIGNvbnZlcnQgaXQgdG8gU1BJIE1FTSAKPiByZWdhcmRsZXNzIG9mIHdoZXRoZXIgdGhpcyBp cyBhIGJ1ZyBmaXggb3IgYSBuZXcgZmVhdHVyZSwgYmVjYXVzZSAKPiBldmVudHVhbGx5IHdlIHdh bnQgdG8gZ2V0IHJpZCBvZiBkcml2ZXJzL210ZC9zcGktbm9yL2NvbnRyb2xsZXJzLyBhbmQgCj4g dGhlIEFQSSB0aGF0IGNvbWVzIGFsb25nIHdpdGggaXQuCgpJIHRvdGFsbHkgYWdyZWUgd2l0aCBQ cmF0eXVzaCBoZXJlLCB3ZSBubyBsb25nZXIgd2FudCB0byBzdXBwb3J0IHRoZQpzcGktbm9yIGNv bnRyb2xsZXIgQVBJIHNvIGlmLCBhcyB5b3Ugc2F5LCB0aGVyZSBhcmUgYm9hcmRzIGZhaWxpbmcK aW4gdGhlIGZpZWxkLCBpdCBtZWFucyB0aGVyZSBhcmUgc3RpbGwgdXNlcnMgYW5kIHRoZXNlIHVz ZXJzIG11c3QgYmUKd2FybmVkIHRoYXQgYXQgc29tZSBwb2ludCB3ZSBtaWdodCBkaXNjb250aW51 ZSB0aGUgc3VwcG9ydCBvZiB0aGVzZQpkcml2ZXJzIGlmIGl0IGJlY29tZXMgdG9vIHBhaW5mdWwu Cgo+IEFzIGZvciB5b3VyIHBhdGNoLCBJIGNlcnRhaW5seSBkb24ndCB3YW50IGl0IHRvIGdvIHZp YSB0aGUgYXNwZWVkIHRyZWUuCgpEZWZpbml0ZWx5LCBuby4KCj4gSXQgc2hvdWxkIGdvIHZpYSB0 aGUgTVREIHRyZWUgb3Igbm90IGF0IGFsbC4gSSBhbSBub3QgcXVpdGUgc3VyZSBpZiB0aGlzIAo+ IGNvdW50cyBhcyBhIGJ1ZyBmaXggb3IgYSBuZXcgZmVhdHVyZSB0aG91Z2guCj4gCj4gPiAgIAo+ ID4gPiBDb3VsZCB5b3UgcGxlYXNlIHZvbHVudGVlciB0byBkbyB0aGUgY29udmVyc2lvbiBmb3Ig dGhpcyBkcml2ZXI/ICAKPiA+IAo+ID4gSSdtIG5vdCBwZXJzb25hbGx5IGdvaW5nIHRvIGJlIGFi bGUgdG8gZ2V0IHRvIGl0IGZvciBhdCBsZWFzdCB0aGUgbmV4dCAzIG1vbnRocy4KPiA+IAo+ID4g SXQgbG9va3MgbGlrZSB3ZSBkb24ndCBoYXZlIGEgZGVkaWNhdGVkIG1haW50YWluZXIgZm9yIHRo aXMgZHJpdmVyIG90aGVyIHRoYW4KPiA+IEpvZWwgYnkgbmF0dXJlIG9mIGhpbSBiZWluZyBsaXN0 ZWQgYXMgdGhlIG1haW50YWluZXIgb2YgIkFSTS9BU1BFRUQgTUFDSElORQo+ID4gU1VQUE9SVCIu ICBJJ20gbm90IHN1cmUgaWYgQXNwZWVkIHRoZW1zZWx2ZXMgYXJlIHBsYW5uaW5nIG9uIGRvaW5n IHRoZSBuZWNlc3NhcnkKPiA+IHJlZmFjdG9yaW5nIGhlcmUuCj4gPiAKPiA+IAo+ID4gSm9lbCwg YXJlIHlvdSBhd2FyZSBvZiB0aGlzIGRyaXZlciB1c2luZyBhIGRlcHJlY2F0ZWQgaW1wbGVtZW50 YXRpb24/ICBXZXJlCj4gPiB0aGVyZSBhbnlvbmUgcGxhbm5pbmcgdG8gZG8gdGhlIHJld29ya3Mg dGhhdCB5b3UgYXJlIGF3YXJlIG9mPyAgSSdkIGxpa2UgdG8gZ2V0Cj4gPiB0aGlzIGZpeCBhdCBs ZWFzdCBpbnRvIHRoZSBPcGVuQk1DIGtlcm5lbCB0cmVlIGJlY2F1c2UgSSdtIHNlZWluZyB0aGlz IGZhaWwgaW4KPiA+IHRoZSByZWFsIHdvcmxkLiAgCj4gCgpUaGFua3MsCk1pcXXDqGwKCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJu ZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRw Oi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 728A8C433F5 for ; Mon, 3 Jan 2022 16:17:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234228AbiACQR3 convert rfc822-to-8bit (ORCPT ); Mon, 3 Jan 2022 11:17:29 -0500 Received: from relay12.mail.gandi.net ([217.70.178.232]:43305 "EHLO relay12.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232511AbiACQR2 (ORCPT ); Mon, 3 Jan 2022 11:17:28 -0500 Received: (Authenticated sender: miquel.raynal@bootlin.com) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 49201200006; Mon, 3 Jan 2022 16:17:23 +0000 (UTC) Date: Mon, 3 Jan 2022 17:17:21 +0100 From: Miquel Raynal To: Pratyush Yadav Cc: Patrick Williams , Joel Stanley , Tudor Ambarus , Michael Walle , Richard Weinberger , Vignesh Raghavendra , Andrew Jeffery , Potin Lai , , , , Subject: Re: [PATCH] mtd: aspeed-smc: improve probe resilience Message-ID: <20220103171721.46c8e697@xps13> In-Reply-To: <20211231102623.izaqlzjvracbbgmp@ti.com> References: <20211229143334.297305-1-patrick@stwcx.xyz> <20211229173411.l2bipmi4x3arqjoo@ti.com> <20211231102623.izaqlzjvracbbgmp@ti.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, p.yadav@ti.com wrote on Fri, 31 Dec 2021 15:56:25 +0530: > Hi Patrick, > > On 30/12/21 09:29AM, Patrick Williams wrote: > > On Wed, Dec 29, 2021 at 11:04:13PM +0530, Pratyush Yadav wrote: > > > Hi, > > > > > > On 29/12/21 08:33AM, Patrick Williams wrote: > > > > > The patch itself looks fine to me but we no longer want to maintain > > > drivers under drivers/mtd/spi-nor/controllers/. They should be moved to > > > implement the SPI MEM API (under drivers/spi/). > > > > Is the linux-aspeed community aware of this? Are you saying you don't want to > > take fixes for their driver into the MTD tree? Can it be pulled into the Aspeed > > tree? > > I am fine with taking in bug fixes but no longer want to take in any new > features. My main intention was to nudge you to convert it to SPI MEM > regardless of whether this is a bug fix or a new feature, because > eventually we want to get rid of drivers/mtd/spi-nor/controllers/ and > the API that comes along with it. I totally agree with Pratyush here, we no longer want to support the spi-nor controller API so if, as you say, there are boards failing in the field, it means there are still users and these users must be warned that at some point we might discontinue the support of these drivers if it becomes too painful. > As for your patch, I certainly don't want it to go via the aspeed tree. Definitely, no. > It should go via the MTD tree or not at all. I am not quite sure if this > counts as a bug fix or a new feature though. > > > > > > Could you please volunteer to do the conversion for this driver? > > > > I'm not personally going to be able to get to it for at least the next 3 months. > > > > It looks like we don't have a dedicated maintainer for this driver other than > > Joel by nature of him being listed as the maintainer of "ARM/ASPEED MACHINE > > SUPPORT". I'm not sure if Aspeed themselves are planning on doing the necessary > > refactoring here. > > > > > > Joel, are you aware of this driver using a deprecated implementation? Were > > there anyone planning to do the reworks that you are aware of? I'd like to get > > this fix at least into the OpenBMC kernel tree because I'm seeing this fail in > > the real world. > Thanks, Miquèl