From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D5828C433F5 for ; Mon, 3 Jan 2022 17:33:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=FgdeSXmufa2TArDNmDAJjqcolInWW4vst78yktJyTBs=; b=fMZZlQwpaU+vYc ahPj8hfF0wpM7asp+fPtX4d4PmwptQOI33l1J0vDh006o9psKeldHQNzTQuhL+rdSLgNurLnu1+wK rblH7oj6y1wXaq6V/aZw2z3RbD3pwFesZafiXb28sKcmUZqYJCDqOaUlmqxjVObrp+uMLKVyg0h7k 158BNJTlJCURFcX8GeZLkJCPYki3q++K5K1/X4upY7ZNIXjqZ+BSVw8FhMQviER/7In/FxJD3AuPv P+Yjv8ZQDMoOjRZCnjy2nPm7QPakq+QFE9Zng8LgKmRlQkxoXo6LPPH1nFd0zw2f3WKrQBufkebN5 H9T46/fMTl5S8jBywn4Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n4RDC-009hw7-4C; Mon, 03 Jan 2022 17:33:34 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n4RAH-009gVW-81; Mon, 03 Jan 2022 17:30:34 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 06FFE6119F; Mon, 3 Jan 2022 17:30:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DD953C36AEE; Mon, 3 Jan 2022 17:30:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1641231031; bh=hGPKFm/39euNVFMinPd0zZsLdEwQkPaR6fJ4viZLL/k=; h=From:To:Cc:Subject:Date:From; b=P3+QWd7Mzyey2/eUrZXwuyvJbMvC4rOaiO0KySdlrFwJ0pQysS87wMeqTsyKeRQGp BSz5lfMPJbjUH/G7k19FLvQz1PQOba85sCPwc1HRCFDa/Guf58ak9PEH+wCOxu8QQb lUUiO9WZMYi+EADwN5sg4l704tEDGkIxYzsbBSqQ/KJTAtk+aOLG1FOEzz5NpGZyHS z1MU1jwtFRMXRMa/fhNrxm53rNHMQvnryobgSF+R+o0Sz5qMIcBTSJOVbAaDLHdwP+ gyvkGAinpCWpo94+bXg9V63/yvzbd0Rq4XNA2bvwpYUG0r4dAsktkzl5scf371zqu/ +j1mBg1hGRazg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Chunfeng Yun , Greg Kroah-Hartman , Sasha Levin , matthias.bgg@gmail.com, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH AUTOSEL 4.19 1/5] usb: mtu3: fix interval value for intr and isoc Date: Mon, 3 Jan 2022 12:30:25 -0500 Message-Id: <20220103173029.1613474-1-sashal@kernel.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220103_093033_377382_A92B6723 X-CRM114-Status: GOOD ( 12.24 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org From: Chunfeng Yun [ Upstream commit e3d4621c22f90c33321ae6a6baab60cdb8e5a77c ] Use the Interval value from isoc/intr endpoint descriptor, no need minus one. The original code doesn't cause transfer error for normal cases, but it may have side effect with respond time of ERDY or tPingTimeout. Signed-off-by: Chunfeng Yun Link: https://lore.kernel.org/r/20211218095749.6250-1-chunfeng.yun@mediatek.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/usb/mtu3/mtu3_gadget.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/mtu3/mtu3_gadget.c b/drivers/usb/mtu3/mtu3_gadget.c index 270721cf229f7..c5c864a02a763 100644 --- a/drivers/usb/mtu3/mtu3_gadget.c +++ b/drivers/usb/mtu3/mtu3_gadget.c @@ -82,7 +82,7 @@ static int mtu3_ep_enable(struct mtu3_ep *mep) if (usb_endpoint_xfer_int(desc) || usb_endpoint_xfer_isoc(desc)) { interval = desc->bInterval; - interval = clamp_val(interval, 1, 16) - 1; + interval = clamp_val(interval, 1, 16); if (usb_endpoint_xfer_isoc(desc) && comp_desc) mult = comp_desc->bmAttributes; } @@ -94,7 +94,7 @@ static int mtu3_ep_enable(struct mtu3_ep *mep) if (usb_endpoint_xfer_isoc(desc) || usb_endpoint_xfer_int(desc)) { interval = desc->bInterval; - interval = clamp_val(interval, 1, 16) - 1; + interval = clamp_val(interval, 1, 16); mult = usb_endpoint_maxp_mult(desc) - 1; } break; -- 2.34.1 _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA65EC4332F for ; Mon, 3 Jan 2022 17:31:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235472AbiACRbh (ORCPT ); Mon, 3 Jan 2022 12:31:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53474 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235454AbiACRau (ORCPT ); Mon, 3 Jan 2022 12:30:50 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 59E92C061376; Mon, 3 Jan 2022 09:30:34 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 16C65B81042; Mon, 3 Jan 2022 17:30:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DD953C36AEE; Mon, 3 Jan 2022 17:30:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1641231031; bh=hGPKFm/39euNVFMinPd0zZsLdEwQkPaR6fJ4viZLL/k=; h=From:To:Cc:Subject:Date:From; b=P3+QWd7Mzyey2/eUrZXwuyvJbMvC4rOaiO0KySdlrFwJ0pQysS87wMeqTsyKeRQGp BSz5lfMPJbjUH/G7k19FLvQz1PQOba85sCPwc1HRCFDa/Guf58ak9PEH+wCOxu8QQb lUUiO9WZMYi+EADwN5sg4l704tEDGkIxYzsbBSqQ/KJTAtk+aOLG1FOEzz5NpGZyHS z1MU1jwtFRMXRMa/fhNrxm53rNHMQvnryobgSF+R+o0Sz5qMIcBTSJOVbAaDLHdwP+ gyvkGAinpCWpo94+bXg9V63/yvzbd0Rq4XNA2bvwpYUG0r4dAsktkzl5scf371zqu/ +j1mBg1hGRazg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Chunfeng Yun , Greg Kroah-Hartman , Sasha Levin , matthias.bgg@gmail.com, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH AUTOSEL 4.19 1/5] usb: mtu3: fix interval value for intr and isoc Date: Mon, 3 Jan 2022 12:30:25 -0500 Message-Id: <20220103173029.1613474-1-sashal@kernel.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org From: Chunfeng Yun [ Upstream commit e3d4621c22f90c33321ae6a6baab60cdb8e5a77c ] Use the Interval value from isoc/intr endpoint descriptor, no need minus one. The original code doesn't cause transfer error for normal cases, but it may have side effect with respond time of ERDY or tPingTimeout. Signed-off-by: Chunfeng Yun Link: https://lore.kernel.org/r/20211218095749.6250-1-chunfeng.yun@mediatek.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/usb/mtu3/mtu3_gadget.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/mtu3/mtu3_gadget.c b/drivers/usb/mtu3/mtu3_gadget.c index 270721cf229f7..c5c864a02a763 100644 --- a/drivers/usb/mtu3/mtu3_gadget.c +++ b/drivers/usb/mtu3/mtu3_gadget.c @@ -82,7 +82,7 @@ static int mtu3_ep_enable(struct mtu3_ep *mep) if (usb_endpoint_xfer_int(desc) || usb_endpoint_xfer_isoc(desc)) { interval = desc->bInterval; - interval = clamp_val(interval, 1, 16) - 1; + interval = clamp_val(interval, 1, 16); if (usb_endpoint_xfer_isoc(desc) && comp_desc) mult = comp_desc->bmAttributes; } @@ -94,7 +94,7 @@ static int mtu3_ep_enable(struct mtu3_ep *mep) if (usb_endpoint_xfer_isoc(desc) || usb_endpoint_xfer_int(desc)) { interval = desc->bInterval; - interval = clamp_val(interval, 1, 16) - 1; + interval = clamp_val(interval, 1, 16); mult = usb_endpoint_maxp_mult(desc) - 1; } break; -- 2.34.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A0124C433F5 for ; Mon, 3 Jan 2022 17:34:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=i9Cfow9MHf1c6Q6CXP28wO7TBioADZ7Kh29uJjIKSBQ=; b=jVcHBA0gRb4y+5 haVpkWHDrrAnUFOy9L2il2H6SzpaxBTJRmDMl6y5qkftRo11Urgq46bmffrzExKPq0tDx3grLgEku zbAStUGvWRgUTvFbeWLDkRI/F+0c2hLqselnh+VWvfvhFUyGElt/eYf8kN+HB/1Ywf8svOMjW+4Xt Q0C8KZuLnP0nzeJzs+O++W1SCBaotLwoF/WkdmmkqLnBA/dQcsDqrjJqbQWBJBAR7X/eogm4eRH8r c89o9wnRwxFqru71bw4OPgxgjZs3AgOdIC9pPVytRU595/k/tjUysterSKdBMhvdyQvOyqiT0tu1P yZNT+OhlXYNYi9RiOSyw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n4RCV-009hcc-6e; Mon, 03 Jan 2022 17:32:51 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n4RAH-009gVW-81; Mon, 03 Jan 2022 17:30:34 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 06FFE6119F; Mon, 3 Jan 2022 17:30:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DD953C36AEE; Mon, 3 Jan 2022 17:30:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1641231031; bh=hGPKFm/39euNVFMinPd0zZsLdEwQkPaR6fJ4viZLL/k=; h=From:To:Cc:Subject:Date:From; b=P3+QWd7Mzyey2/eUrZXwuyvJbMvC4rOaiO0KySdlrFwJ0pQysS87wMeqTsyKeRQGp BSz5lfMPJbjUH/G7k19FLvQz1PQOba85sCPwc1HRCFDa/Guf58ak9PEH+wCOxu8QQb lUUiO9WZMYi+EADwN5sg4l704tEDGkIxYzsbBSqQ/KJTAtk+aOLG1FOEzz5NpGZyHS z1MU1jwtFRMXRMa/fhNrxm53rNHMQvnryobgSF+R+o0Sz5qMIcBTSJOVbAaDLHdwP+ gyvkGAinpCWpo94+bXg9V63/yvzbd0Rq4XNA2bvwpYUG0r4dAsktkzl5scf371zqu/ +j1mBg1hGRazg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Chunfeng Yun , Greg Kroah-Hartman , Sasha Levin , matthias.bgg@gmail.com, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH AUTOSEL 4.19 1/5] usb: mtu3: fix interval value for intr and isoc Date: Mon, 3 Jan 2022 12:30:25 -0500 Message-Id: <20220103173029.1613474-1-sashal@kernel.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220103_093033_377382_A92B6723 X-CRM114-Status: GOOD ( 12.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Chunfeng Yun [ Upstream commit e3d4621c22f90c33321ae6a6baab60cdb8e5a77c ] Use the Interval value from isoc/intr endpoint descriptor, no need minus one. The original code doesn't cause transfer error for normal cases, but it may have side effect with respond time of ERDY or tPingTimeout. Signed-off-by: Chunfeng Yun Link: https://lore.kernel.org/r/20211218095749.6250-1-chunfeng.yun@mediatek.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/usb/mtu3/mtu3_gadget.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/mtu3/mtu3_gadget.c b/drivers/usb/mtu3/mtu3_gadget.c index 270721cf229f7..c5c864a02a763 100644 --- a/drivers/usb/mtu3/mtu3_gadget.c +++ b/drivers/usb/mtu3/mtu3_gadget.c @@ -82,7 +82,7 @@ static int mtu3_ep_enable(struct mtu3_ep *mep) if (usb_endpoint_xfer_int(desc) || usb_endpoint_xfer_isoc(desc)) { interval = desc->bInterval; - interval = clamp_val(interval, 1, 16) - 1; + interval = clamp_val(interval, 1, 16); if (usb_endpoint_xfer_isoc(desc) && comp_desc) mult = comp_desc->bmAttributes; } @@ -94,7 +94,7 @@ static int mtu3_ep_enable(struct mtu3_ep *mep) if (usb_endpoint_xfer_isoc(desc) || usb_endpoint_xfer_int(desc)) { interval = desc->bInterval; - interval = clamp_val(interval, 1, 16) - 1; + interval = clamp_val(interval, 1, 16); mult = usb_endpoint_maxp_mult(desc) - 1; } break; -- 2.34.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel