From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Arnout Vandecappelle <arnout@mind.be>
Cc: Andrey Nechypurenko <andreynech@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] support/scripts/: remove -E flag from patch call
Date: Mon, 3 Jan 2022 21:18:22 +0100 [thread overview]
Message-ID: <20220103201822.GI69135@scaer> (raw)
In-Reply-To: <63439c64-530d-4d2f-67e5-91a854501a5c@mind.be>
Arnout, All,
On 2022-01-03 18:11 +0100, Arnout Vandecappelle spake thusly:
> On 30/12/2021 22:47, Yann E. MORIN wrote:
> >On 2021-12-14 13:55 +0100, Andrey Nechypurenko spake thusly:
> >>-E flag instructs patch to remove empty files. However, in some cases
> >>empty files are essential. If they are missing, build could be broken
> >>or other bad things can happen.
[--SNIP--]
> >I was going to apply this, but then I was wondering; what about patches
> >that actually *want* to remove files?
> >It turns out that we do have a few patches that remove files:
> Have you actually tested this? With modern patch, the /dev/null indicates
> exactly what we want: that the file must be removed. So even without -E, the
> file gets removed.
>
> What -E does is remove a file in the following case:
>
> --- a/foo
> +++ a/foo
> @@ -1,1 +0,0 @@
> - foo
Ah, yeah, I was a bit unsure... Now I tried, adn indeed it behaves as
expected.
> git grep -B1 '+0,0 @@' only yields /dev/null cases, so I think it's OK.
> So I think the only real concern is: will a patch version that supports
> renames always behave like this? I *think* the answer is yes, but it's hard
> to be sure of course.
OK, I'm sold on the idea, and I believe this is sane enough.
Applied to master, thanks.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2022-01-03 20:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-14 12:55 [Buildroot] [PATCH 1/1] support/scripts/: remove -E flag from patch call Andrey Nechypurenko
2021-12-30 21:47 ` Yann E. MORIN
2022-01-03 11:29 ` Andrey Nechypurenko
2022-01-03 17:11 ` Arnout Vandecappelle
2022-01-03 20:18 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220103201822.GI69135@scaer \
--to=yann.morin.1998@free.fr \
--cc=andreynech@gmail.com \
--cc=arnout@mind.be \
--cc=buildroot@buildroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.