From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3E10BC433EF for ; Tue, 4 Jan 2022 09:03:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JQJoVFhNhTteOUewGSEJTWvemkcFio6b40ZeBDmQaPY=; b=aUhB8Q+5rSM/2m hENYhO1yp6LmUXozJJxT2LFn3M1vwqcQTDBHkHbhl8xVsgu8S5VU5sH6t035/kMQKiqiTSvpxEe1z tno/9fLb9q4Uhvfnne4c4IUf6imZyFzlazaX4Da9aFfnCEO7pjNoOCYZ/Oj2HmqxZPUvGqkm4c1rQ /HOqBX58FwVRQeSmMb4dP8r60OSzSnNwOazvCcbn7UsdmZzJabzJ5GZo0MHdAIJ/TUmLXluvNq+xB K/WX4NE7/FV1JnrYjzOuG7LlQp6VOI3XUJT3hs6/Z+cUHHZHO5UsvLL958QcJTxzxycU/Ow3L+Mra BWkNK2UcJyi0OuFKiHhA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n4fiQ-00Arou-7G; Tue, 04 Jan 2022 09:02:46 +0000 Received: from relay4-d.mail.gandi.net ([217.70.183.196]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n4fdo-00AqX9-Ut for linux-mtd@lists.infradead.org; Tue, 04 Jan 2022 08:58:03 +0000 Received: (Authenticated sender: miquel.raynal@bootlin.com) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 22E05E000C; Tue, 4 Jan 2022 08:57:57 +0000 (UTC) Date: Tue, 4 Jan 2022 09:57:55 +0100 From: Miquel Raynal To: Florian Fainelli Cc: linux-mtd@lists.infradead.org, =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Richard Weinberger , Vignesh Raghavendra , Brian Norris , Kamal Dasu , Arnd Bergmann , Cai Huoqing , Colin Ian King , open list , "open list:BROADCOM SPECIFIC AMBA DRIVER (BCMA)" , "open list:BROADCOM STB NAND FLASH DRIVER" Subject: Re: [PATCH 1/9] mtd: rawnand: brcmnand: Allow SoC to provide I/O operations Message-ID: <20220104095755.46858287@xps13> In-Reply-To: <20220104093221.6414aab9@xps13> References: <20211223002225.3738385-1-f.fainelli@gmail.com> <20211223002225.3738385-2-f.fainelli@gmail.com> <20220103174953.40d7fa52@xps13> <299bf6ed-80e6-ad15-8dc7-5ededaca15c5@gmail.com> <20220104093221.6414aab9@xps13> Organization: Bootlin X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220104_005801_314421_80EDC98D X-CRM114-Status: GOOD ( 31.13 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGkgTWlxdWVsLAoKbWlxdWVsLnJheW5hbEBib290bGluLmNvbSB3cm90ZSBvbiBUdWUsIDQgSmFu IDIwMjIgMDk6MzI6MjEgKzAxMDA6Cgo+IEhpIEZsb3JpYW4sCj4gCj4gZi5mYWluZWxsaUBnbWFp bC5jb20gd3JvdGUgb24gTW9uLCAzIEphbiAyMDIyIDA5OjI0OjI2IC0wODAwOgo+IAo+ID4gT24g MS8zLzIwMjIgODo0OSBBTSwgTWlxdWVsIFJheW5hbCB3cm90ZTogIAo+ID4gPiBIaSBGbG9yaWFu LAo+ID4gPiAKPiA+ID4gZi5mYWluZWxsaUBnbWFpbC5jb20gd3JvdGUgb24gV2VkLCAyMiBEZWMg MjAyMSAxNjoyMjoxNyAtMDgwMDoKPiA+ID4gICAgIAo+ID4gPj4gQWxsb3cgYSBicmNtbmFuZF9z b2MgaW5zdGFuY2UgdG8gcHJvdmlkZSBhIGN1c3RvbSBzZXQgb2YgSS9PIG9wZXJhdGlvbnMKPiA+ ID4+IHdoaWNoIHdlIHdpbGwgcmVxdWlyZSB3aGVuIHVzaW5nIHRoaXMgZHJpdmVyIG9uIGEgQkNN QSBidXMgd2hpY2ggaXMgbm90Cj4gPiA+PiBkaXJlY3RseSBtZW1vcnkgbWFwcGVkIEkvTy4gVXBk YXRlIHRoZSBuYW5kX3tyZWFkLHdyaXRlfV9yZWcgYWNjb3JkaW5nbHkKPiA+ID4+IHRvIHVzZSB0 aGUgU29DIG9wZXJhdGlvbnMgaWYgcHJvdmlkZWQuCj4gPiA+Pgo+ID4gPj4gU2lnbmVkLW9mZi1i eTogRmxvcmlhbiBGYWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+Cj4gPiA+PiAtLS0KPiA+ ID4+ICAgZHJpdmVycy9tdGQvbmFuZC9yYXcvYnJjbW5hbmQvYnJjbW5hbmQuYyB8IDE0ICsrKysr KysrKysrKy0tCj4gPiA+PiAgIGRyaXZlcnMvbXRkL25hbmQvcmF3L2JyY21uYW5kL2JyY21uYW5k LmggfCAyMyArKysrKysrKysrKysrKysrKysrKysrKwo+ID4gPj4gICAyIGZpbGVzIGNoYW5nZWQs IDM1IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCj4gPiA+Pgo+ID4gPj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvbXRkL25hbmQvcmF3L2JyY21uYW5kL2JyY21uYW5kLmMgYi9kcml2ZXJzL210 ZC9uYW5kL3Jhdy9icmNtbmFuZC9icmNtbmFuZC5jCj4gPiA+PiBpbmRleCBmNzU5Mjk3ODNiOTQu LjdhMTY3M2IxYjFhZiAxMDA2NDQKPiA+ID4+IC0tLSBhL2RyaXZlcnMvbXRkL25hbmQvcmF3L2Jy Y21uYW5kL2JyY21uYW5kLmMKPiA+ID4+ICsrKyBiL2RyaXZlcnMvbXRkL25hbmQvcmF3L2JyY21u YW5kL2JyY21uYW5kLmMKPiA+ID4+IEBAIC01OTQsMTMgKzU5NCwxOCBAQCBlbnVtIHsgICAgCj4g PiA+PiAgID4+ICAgc3RhdGljIGlubGluZSB1MzIgbmFuZF9yZWFkcmVnKHN0cnVjdCBicmNtbmFu ZF9jb250cm9sbGVyICpjdHJsLCB1MzIgb2ZmcykgICAgCj4gPiA+PiAgIHsKPiA+ID4+ICsJaWYg KGJyY21uYW5kX3NvY19oYXNfb3BzKGN0cmwtPnNvYykpCj4gPiA+PiArCQlyZXR1cm4gYnJjbW5h bmRfc29jX3JlYWQoY3RybC0+c29jLCBvZmZzKTsKPiA+ID4+ICAgCXJldHVybiBicmNtbmFuZF9y ZWFkbChjdHJsLT5uYW5kX2Jhc2UgKyBvZmZzKTsKPiA+ID4+ICAgfSAgICAKPiA+ID4+ICAgPj4g ICBzdGF0aWMgaW5saW5lIHZvaWQgbmFuZF93cml0ZXJlZyhzdHJ1Y3QgYnJjbW5hbmRfY29udHJv bGxlciAqY3RybCwgdTMyIG9mZnMsICAgIAo+ID4gPj4gICAJCQkJIHUzMiB2YWwpCj4gPiA+PiAg IHsKPiA+ID4+IC0JYnJjbW5hbmRfd3JpdGVsKHZhbCwgY3RybC0+bmFuZF9iYXNlICsgb2Zmcyk7 Cj4gPiA+PiArCWlmIChicmNtbmFuZF9zb2NfaGFzX29wcyhjdHJsLT5zb2MpKQo+ID4gPj4gKwkJ YnJjbW5hbmRfc29jX3dyaXRlKGN0cmwtPnNvYywgdmFsLCBvZmZzKTsKPiA+ID4+ICsJZWxzZQo+ ID4gPj4gKwkJYnJjbW5hbmRfd3JpdGVsKHZhbCwgY3RybC0+bmFuZF9iYXNlICsgb2Zmcyk7Cj4g PiA+PiAgIH0gICAgCj4gPiA+PiAgID4+ICAgc3RhdGljIGludCBicmNtbmFuZF9yZXZpc2lvbl9p bml0KHN0cnVjdCBicmNtbmFuZF9jb250cm9sbGVyICpjdHJsKSAgICAKPiA+ID4+IEBAIC03NjYs MTMgKzc3MSwxOCBAQCBzdGF0aWMgaW5saW5lIHZvaWQgYnJjbW5hbmRfcm13X3JlZyhzdHJ1Y3Qg YnJjbW5hbmRfY29udHJvbGxlciAqY3RybCwgICAgCj4gPiA+PiAgID4+ICAgc3RhdGljIGlubGlu ZSB1MzIgYnJjbW5hbmRfcmVhZF9mYyhzdHJ1Y3QgYnJjbW5hbmRfY29udHJvbGxlciAqY3RybCwg aW50IHdvcmQpICAgIAo+ID4gPj4gICB7Cj4gPiA+PiArCWlmIChicmNtbmFuZF9zb2NfaGFzX29w cyhjdHJsLT5zb2MpKQo+ID4gPj4gKwkJcmV0dXJuIGJyY21uYW5kX3NvY19yZWFkKGN0cmwtPnNv YywgfjApOwo+ID4gPj4gICAJcmV0dXJuIF9fcmF3X3JlYWRsKGN0cmwtPm5hbmRfZmMgKyB3b3Jk ICogNCk7Cj4gPiA+PiAgIH0gICAgCj4gPiA+PiAgID4+ICAgc3RhdGljIGlubGluZSB2b2lkIGJy Y21uYW5kX3dyaXRlX2ZjKHN0cnVjdCBicmNtbmFuZF9jb250cm9sbGVyICpjdHJsLCAgICAKPiA+ ID4+ICAgCQkJCSAgICAgaW50IHdvcmQsIHUzMiB2YWwpCj4gPiA+PiAgIHsKPiA+ID4+IC0JX19y YXdfd3JpdGVsKHZhbCwgY3RybC0+bmFuZF9mYyArIHdvcmQgKiA0KTsKPiA+ID4+ICsJaWYgKGJy Y21uYW5kX3NvY19oYXNfb3BzKGN0cmwtPnNvYykpCj4gPiA+PiArCQlicmNtbmFuZF9zb2Nfd3Jp dGUoY3RybC0+c29jLCB2YWwsIH4wKTsKPiA+ID4+ICsJZWxzZQo+ID4gPj4gKwkJX19yYXdfd3Jp dGVsKHZhbCwgY3RybC0+bmFuZF9mYyArIHdvcmQgKiA0KTsKPiA+ID4+ICAgfSAgICAKPiA+ID4+ ICAgPj4gICBzdGF0aWMgaW5saW5lIHZvaWQgZWR1X3dyaXRlbChzdHJ1Y3QgYnJjbW5hbmRfY29u dHJvbGxlciAqY3RybCwgICAgCj4gPiA+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9tdGQvbmFuZC9y YXcvYnJjbW5hbmQvYnJjbW5hbmQuaCBiL2RyaXZlcnMvbXRkL25hbmQvcmF3L2JyY21uYW5kL2Jy Y21uYW5kLmgKPiA+ID4+IGluZGV4IGViNDk4ZmJlNTA1ZS4uYTNmMmFkNWY2NTcyIDEwMDY0NAo+ ID4gPj4gLS0tIGEvZHJpdmVycy9tdGQvbmFuZC9yYXcvYnJjbW5hbmQvYnJjbW5hbmQuaAo+ID4g Pj4gKysrIGIvZHJpdmVycy9tdGQvbmFuZC9yYXcvYnJjbW5hbmQvYnJjbW5hbmQuaAo+ID4gPj4g QEAgLTExLDEyICsxMSwxOSBAQCAgICAKPiA+ID4+ICAgPj4gICBzdHJ1Y3QgcGxhdGZvcm1fZGV2 aWNlOyAgICAKPiA+ID4+ICAgc3RydWN0IGRldl9wbV9vcHM7Cj4gPiA+PiArc3RydWN0IGJyY21u YW5kX2lvX29wczsgICAgCj4gPiA+PiAgID4+ICAgc3RydWN0IGJyY21uYW5kX3NvYyB7ICAgIAo+ ID4gPj4gICAJYm9vbCAoKmN0bHJkeV9hY2spKHN0cnVjdCBicmNtbmFuZF9zb2MgKnNvYyk7Cj4g PiA+PiAgIAl2b2lkICgqY3RscmR5X3NldF9lbmFibGVkKShzdHJ1Y3QgYnJjbW5hbmRfc29jICpz b2MsIGJvb2wgZW4pOwo+ID4gPj4gICAJdm9pZCAoKnByZXBhcmVfZGF0YV9idXMpKHN0cnVjdCBi cmNtbmFuZF9zb2MgKnNvYywgYm9vbCBwcmVwYXJlLAo+ID4gPj4gICAJCQkJIGJvb2wgaXNfcGFy YW0pOwo+ID4gPj4gKwljb25zdCBzdHJ1Y3QgYnJjbW5hbmRfaW9fb3BzICpvcHM7Cj4gPiA+PiAr fTsKPiA+ID4+ICsKPiA+ID4+ICtzdHJ1Y3QgYnJjbW5hbmRfaW9fb3BzIHsKPiA+ID4+ICsJdTMy ICgqcmVhZF9yZWcpKHN0cnVjdCBicmNtbmFuZF9zb2MgKnNvYywgdTMyIG9mZnNldCk7Cj4gPiA+ PiArCXZvaWQgKCp3cml0ZV9yZWcpKHN0cnVjdCBicmNtbmFuZF9zb2MgKnNvYywgdTMyIHZhbCwg dTMyIG9mZnNldCk7Cj4gPiA+PiAgIH07ICAgIAo+ID4gPj4gICA+PiAgIHN0YXRpYyBpbmxpbmUg dm9pZCBicmNtbmFuZF9zb2NfZGF0YV9idXNfcHJlcGFyZShzdHJ1Y3QgYnJjbW5hbmRfc29jICpz b2MsICAgIAo+ID4gPj4gQEAgLTU4LDYgKzY1LDIyIEBAIHN0YXRpYyBpbmxpbmUgdm9pZCBicmNt bmFuZF93cml0ZWwodTMyIHZhbCwgdm9pZCBfX2lvbWVtICphZGRyKQo+ID4gPj4gICAJCXdyaXRl bF9yZWxheGVkKHZhbCwgYWRkcik7Cj4gPiA+PiAgIH0gICAgCj4gPiA+PiAgID4+ICtzdGF0aWMg aW5saW5lIGJvb2wgYnJjbW5hbmRfc29jX2hhc19vcHMoc3RydWN0IGJyY21uYW5kX3NvYyAqc29j KSAgICAKPiA+ID4+ICt7Cj4gPiA+PiArCXJldHVybiBzb2MgJiYgc29jLT5vcHMgJiYgc29jLT5v cHMtPnJlYWRfcmVnICYmIHNvYy0+b3BzLT53cml0ZV9yZWc7Cj4gPiA+PiArfQo+ID4gPj4gKwo+ ID4gPj4gK3N0YXRpYyBpbmxpbmUgdTMyIGJyY21uYW5kX3NvY19yZWFkKHN0cnVjdCBicmNtbmFu ZF9zb2MgKnNvYywgdTMyIG9mZnNldCkKPiA+ID4+ICt7Cj4gPiA+PiArCXJldHVybiBzb2MtPm9w cy0+cmVhZF9yZWcoc29jLCBvZmZzZXQpOwo+ID4gPj4gK30KPiA+ID4+ICsKPiA+ID4+ICtzdGF0 aWMgaW5saW5lIHZvaWQgYnJjbW5hbmRfc29jX3dyaXRlKHN0cnVjdCBicmNtbmFuZF9zb2MgKnNv YywgdTMyIHZhbCwKPiA+ID4+ICsJCQkJICAgICAgdTMyIG9mZnNldCkKPiA+ID4+ICt7Cj4gPiA+ PiArCXNvYy0+b3BzLT53cml0ZV9yZWcoc29jLCB2YWwsIG9mZnNldCk7Cj4gPiA+PiArfQo+ID4g Pj4gKyAgICAKPiA+ID4gCj4gPiA+IEl0IG1pZ2h0IGJlIHdvcnRoIGxvb2tpbmcgaW50byBtb3Jl IG9wdGltaXplZCB3YXlzIHRvIGRvIHRoZXNlIGNoZWNrcywKPiA+ID4gaW4gcGFydGljdWxhciB0 aGUgcmVhZC93cml0ZV9yZWcgb25lcyBiZWNhdXNlIHlvdSdyZSBjaGVja2luZyBhZ2FpbnN0Cj4g PiA+IHNvbWUgc3RhdGljIGRhdGEgd2hpY2ggY2Fubm90IGJlIG9wdGltaXplZCBvdXQgYnkgdGhl IGNvbXBpbGVyIGJ1dAo+ID4gPiB3b24ndCBjaGFuZ2UgaW4gdGhlIGxpZmV0aW1lIG9mIHRoZSBr ZXJuZWwuICAgIAo+ID4gCj4gPiBJIHN1cHBvc2UgSSBjb3VsZCBhZGQgYW4gYWRkaXRpb24gaWYg SVNfRU5BQkxFRChDT05GSUdfTVREX05BTkRfQlJDTU5BTkRfQkNNQSkgYXQgdGhlIGZyb250IG9m IGJyY21uYW5kX3NvY19oYXNfb3BzKCksIHdvdWxkIHRoYXQgYWRkcmVzcyB5b3VyIGNvbmNlcm4g b3IgeW91IGhhdmUgc29tZXRoaW5nIGVsc2UgaW4gbWluZD8gIAo+IAo+IEkgZG9uJ3QgbGlrZSBt dWNoIHRoZSAjaWZkZWYgc29sdXRpb24sIGluc3RlYWQgeW91IG1pZ2h0IHRoaW5rIG9mCj4gc3Rh dGljIGtleXMsIG9yIGV2ZW4gYmV0dGVyIHVzaW5nIGEgcmVnbWFwLiBSZWdtYXAgaW1wbGVtZW50 YXRpb24gaXMKPiBmcmVlLCB5b3UgY2FuIHVzZSBlaXRoZXIgb25lIHdheSBvciB0aGUgb3RoZXIg YW5kIGZvciBhbG1vc3Qgbm8KPiBvdmVyaGVhZCBjb21wYXJlZCB0byB0aGUgYnVuY2ggb2YgZnVu Y3Rpb25zIHlvdSBoYXZlIGhlcmUuCgpNYXliZSByZWdtYXBzIHdpbGwgYWN0dWFsbHkgYmUgc2xv d2VyIHRoYW4gdGhlc2UgcmVndWxhciBpZidzLiBQZXJoYXBzCnN0YXRpYyBrZXlzIGFyZSB0aGUg YmVzdCBvcHRpb24/CgpDaGVlcnMsCk1pcXXDqGwKCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51eCBNVEQgZGlzY3Vzc2lvbiBtYWlsaW5n IGxpc3QKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1t dGQvCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D9BDC433EF for ; Tue, 4 Jan 2022 08:58:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229584AbiADI6A convert rfc822-to-8bit (ORCPT ); Tue, 4 Jan 2022 03:58:00 -0500 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:56207 "EHLO relay4-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229472AbiADI6A (ORCPT ); Tue, 4 Jan 2022 03:58:00 -0500 Received: (Authenticated sender: miquel.raynal@bootlin.com) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 22E05E000C; Tue, 4 Jan 2022 08:57:57 +0000 (UTC) Date: Tue, 4 Jan 2022 09:57:55 +0100 From: Miquel Raynal To: Florian Fainelli Cc: linux-mtd@lists.infradead.org, =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Richard Weinberger , Vignesh Raghavendra , Brian Norris , Kamal Dasu , Arnd Bergmann , Cai Huoqing , Colin Ian King , open list , "open list:BROADCOM SPECIFIC AMBA DRIVER (BCMA)" , "open list:BROADCOM STB NAND FLASH DRIVER" Subject: Re: [PATCH 1/9] mtd: rawnand: brcmnand: Allow SoC to provide I/O operations Message-ID: <20220104095755.46858287@xps13> In-Reply-To: <20220104093221.6414aab9@xps13> References: <20211223002225.3738385-1-f.fainelli@gmail.com> <20211223002225.3738385-2-f.fainelli@gmail.com> <20220103174953.40d7fa52@xps13> <299bf6ed-80e6-ad15-8dc7-5ededaca15c5@gmail.com> <20220104093221.6414aab9@xps13> Organization: Bootlin X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Hi Miquel, miquel.raynal@bootlin.com wrote on Tue, 4 Jan 2022 09:32:21 +0100: > Hi Florian, > > f.fainelli@gmail.com wrote on Mon, 3 Jan 2022 09:24:26 -0800: > > > On 1/3/2022 8:49 AM, Miquel Raynal wrote: > > > Hi Florian, > > > > > > f.fainelli@gmail.com wrote on Wed, 22 Dec 2021 16:22:17 -0800: > > > > > >> Allow a brcmnand_soc instance to provide a custom set of I/O operations > > >> which we will require when using this driver on a BCMA bus which is not > > >> directly memory mapped I/O. Update the nand_{read,write}_reg accordingly > > >> to use the SoC operations if provided. > > >> > > >> Signed-off-by: Florian Fainelli > > >> --- > > >> drivers/mtd/nand/raw/brcmnand/brcmnand.c | 14 ++++++++++++-- > > >> drivers/mtd/nand/raw/brcmnand/brcmnand.h | 23 +++++++++++++++++++++++ > > >> 2 files changed, 35 insertions(+), 2 deletions(-) > > >> > > >> diff --git a/drivers/mtd/nand/raw/brcmnand/brcmnand.c b/drivers/mtd/nand/raw/brcmnand/brcmnand.c > > >> index f75929783b94..7a1673b1b1af 100644 > > >> --- a/drivers/mtd/nand/raw/brcmnand/brcmnand.c > > >> +++ b/drivers/mtd/nand/raw/brcmnand/brcmnand.c > > >> @@ -594,13 +594,18 @@ enum { > > >> >> static inline u32 nand_readreg(struct brcmnand_controller *ctrl, u32 offs) > > >> { > > >> + if (brcmnand_soc_has_ops(ctrl->soc)) > > >> + return brcmnand_soc_read(ctrl->soc, offs); > > >> return brcmnand_readl(ctrl->nand_base + offs); > > >> } > > >> >> static inline void nand_writereg(struct brcmnand_controller *ctrl, u32 offs, > > >> u32 val) > > >> { > > >> - brcmnand_writel(val, ctrl->nand_base + offs); > > >> + if (brcmnand_soc_has_ops(ctrl->soc)) > > >> + brcmnand_soc_write(ctrl->soc, val, offs); > > >> + else > > >> + brcmnand_writel(val, ctrl->nand_base + offs); > > >> } > > >> >> static int brcmnand_revision_init(struct brcmnand_controller *ctrl) > > >> @@ -766,13 +771,18 @@ static inline void brcmnand_rmw_reg(struct brcmnand_controller *ctrl, > > >> >> static inline u32 brcmnand_read_fc(struct brcmnand_controller *ctrl, int word) > > >> { > > >> + if (brcmnand_soc_has_ops(ctrl->soc)) > > >> + return brcmnand_soc_read(ctrl->soc, ~0); > > >> return __raw_readl(ctrl->nand_fc + word * 4); > > >> } > > >> >> static inline void brcmnand_write_fc(struct brcmnand_controller *ctrl, > > >> int word, u32 val) > > >> { > > >> - __raw_writel(val, ctrl->nand_fc + word * 4); > > >> + if (brcmnand_soc_has_ops(ctrl->soc)) > > >> + brcmnand_soc_write(ctrl->soc, val, ~0); > > >> + else > > >> + __raw_writel(val, ctrl->nand_fc + word * 4); > > >> } > > >> >> static inline void edu_writel(struct brcmnand_controller *ctrl, > > >> diff --git a/drivers/mtd/nand/raw/brcmnand/brcmnand.h b/drivers/mtd/nand/raw/brcmnand/brcmnand.h > > >> index eb498fbe505e..a3f2ad5f6572 100644 > > >> --- a/drivers/mtd/nand/raw/brcmnand/brcmnand.h > > >> +++ b/drivers/mtd/nand/raw/brcmnand/brcmnand.h > > >> @@ -11,12 +11,19 @@ > > >> >> struct platform_device; > > >> struct dev_pm_ops; > > >> +struct brcmnand_io_ops; > > >> >> struct brcmnand_soc { > > >> bool (*ctlrdy_ack)(struct brcmnand_soc *soc); > > >> void (*ctlrdy_set_enabled)(struct brcmnand_soc *soc, bool en); > > >> void (*prepare_data_bus)(struct brcmnand_soc *soc, bool prepare, > > >> bool is_param); > > >> + const struct brcmnand_io_ops *ops; > > >> +}; > > >> + > > >> +struct brcmnand_io_ops { > > >> + u32 (*read_reg)(struct brcmnand_soc *soc, u32 offset); > > >> + void (*write_reg)(struct brcmnand_soc *soc, u32 val, u32 offset); > > >> }; > > >> >> static inline void brcmnand_soc_data_bus_prepare(struct brcmnand_soc *soc, > > >> @@ -58,6 +65,22 @@ static inline void brcmnand_writel(u32 val, void __iomem *addr) > > >> writel_relaxed(val, addr); > > >> } > > >> >> +static inline bool brcmnand_soc_has_ops(struct brcmnand_soc *soc) > > >> +{ > > >> + return soc && soc->ops && soc->ops->read_reg && soc->ops->write_reg; > > >> +} > > >> + > > >> +static inline u32 brcmnand_soc_read(struct brcmnand_soc *soc, u32 offset) > > >> +{ > > >> + return soc->ops->read_reg(soc, offset); > > >> +} > > >> + > > >> +static inline void brcmnand_soc_write(struct brcmnand_soc *soc, u32 val, > > >> + u32 offset) > > >> +{ > > >> + soc->ops->write_reg(soc, val, offset); > > >> +} > > >> + > > > > > > It might be worth looking into more optimized ways to do these checks, > > > in particular the read/write_reg ones because you're checking against > > > some static data which cannot be optimized out by the compiler but > > > won't change in the lifetime of the kernel. > > > > I suppose I could add an addition if IS_ENABLED(CONFIG_MTD_NAND_BRCMNAND_BCMA) at the front of brcmnand_soc_has_ops(), would that address your concern or you have something else in mind? > > I don't like much the #ifdef solution, instead you might think of > static keys, or even better using a regmap. Regmap implementation is > free, you can use either one way or the other and for almost no > overhead compared to the bunch of functions you have here. Maybe regmaps will actually be slower than these regular if's. Perhaps static keys are the best option? Cheers, Miquèl