From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D4167C433F5 for ; Tue, 4 Jan 2022 09:25:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jbJbVaRrRuOX5FhXtS8/lc9z6Z5LSUKXUcHPvD3C+CA=; b=UMqS6qJFxa08Jg KU89pn2xMwsrueDJmxubfh41Qm+A2q/7UXPLOGB8juQyjAEXT5i2NASCLw2cssY+uy0+haGhxHJU0 kSVAU66YKh/wH6tjEgnKnP5No/HtpMOso6lpCpSlG8w99xk1GYSX5P5ONdpqz5jyz3Fh5v6tN1xeV k9d0EAfkakBDD5TPMZkXEYJ0awR819RHg8dIiznzAeeX6ilf/ZTowHLMaBp4WbhuPX2U9te+ZF4Un Cct6VERrqJisYXoVIlJe/6G06zL7n/9Uy+cPET9cdRkynUCamsrDNG1Vuy9PtqnGc2tJy1YuWC7OE /0DmNAxmY0RAPpPHhRiA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n4g3h-00Az42-J4; Tue, 04 Jan 2022 09:24:45 +0000 Received: from relay5-d.mail.gandi.net ([217.70.183.197]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n4g3d-00Az1m-7i for linux-mtd@lists.infradead.org; Tue, 04 Jan 2022 09:24:43 +0000 Received: (Authenticated sender: miquel.raynal@bootlin.com) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id E0A671C0002; Tue, 4 Jan 2022 09:24:34 +0000 (UTC) Date: Tue, 4 Jan 2022 10:24:33 +0100 From: Miquel Raynal To: Boris Brezillon Cc: Richard Weinberger , Vignesh Raghavendra , Tudor Ambarus , Pratyush Yadav , Michael Walle , , Mark Brown , , Julien Su , Jaime Liao , Thomas Petazzoni , Xiangsheng Hou Subject: Re: [PATCH v9 06/13] spi: spi-mem: Add an ecc parameter to the spi_mem_op structure Message-ID: <20220104102433.0ad3bb2c@xps13> In-Reply-To: <20220104100230.1076beed@collabora.com> References: <20220104083631.40776-1-miquel.raynal@bootlin.com> <20220104083631.40776-7-miquel.raynal@bootlin.com> <20220104100230.1076beed@collabora.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220104_012441_623772_8D3DC0BF X-CRM114-Status: GOOD ( 27.10 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGVsbG8gQm9yaXMsCgpib3Jpcy5icmV6aWxsb25AY29sbGFib3JhLmNvbSB3cm90ZSBvbiBUdWUs IDQgSmFuIDIwMjIgMTA6MDI6MzAgKzAxMDA6Cgo+IE9uIFR1ZSwgIDQgSmFuIDIwMjIgMDk6MzY6 MjQgKzAxMDAKPiBNaXF1ZWwgUmF5bmFsIDxtaXF1ZWwucmF5bmFsQGJvb3RsaW4uY29tPiB3cm90 ZToKPiAKPiA+IFNvb24gdGhlIFNQSS1OQU5EIGNvcmUgd2lsbCBuZWVkIGEgd2F5IHRvIHJlcXVl c3QgYSBTUEkgY29udHJvbGxlciB0bwo+ID4gZW5hYmxlIEVDQyBzdXBwb3J0IGZvciBhIGdpdmVu IG9wZXJhdGlvbi4gVGhpcyBpcyBiZWNhdXNlIG9mIHRoZQo+ID4gcGlwZWxpbmVkIGludGVncmF0 aW9uIG9mIGNlcnRhaW4gRUNDIGVuZ2luZXMsIHdoaWNoIGFyZSBkaXJlY3RseSBtYW5hZ2VkCj4g PiBieSB0aGUgU1BJIGNvbnRyb2xsZXIgaXRzZWxmLgo+ID4gCj4gPiBJbnRyb2R1Y2UgYSBzcGlf bWVtX29wIGFkZGl0aW9uYWwgZmllbGQgZm9yIHRoaXMgcHVycG9zZTogZWNjLgo+ID4gCj4gPiBT byBmYXIgdGhpcyBmaWVsZCBpcyBsZWZ0IHVuc2V0IGFuZCBjaGVja2VkIHRvIGJlIGZhbHNlIGJ5 IGFsbAo+ID4gdGhlIFNQSSBjb250cm9sbGVyIGRyaXZlcnMgaW4gdGhlaXIgLT5zdXBwb3J0c19v cCgpIGhvb2ssIGFzIHRoZXkgYWxsCj4gPiBjYWxsIHNwaV9tZW1fZGVmYXVsdF9zdXBwb3J0c19v cCgpLgo+ID4gCj4gPiBTaWduZWQtb2ZmLWJ5OiBNaXF1ZWwgUmF5bmFsIDxtaXF1ZWwucmF5bmFs QGJvb3RsaW4uY29tPgo+ID4gQWNrZWQtYnk6IFByYXR5dXNoIFlhZGF2IDxwLnlhZGF2QHRpLmNv bT4KPiA+IC0tLQo+ID4gIGRyaXZlcnMvc3BpL3NwaS1tZW0uYyAgICAgICB8IDUgKysrKysKPiA+ ICBpbmNsdWRlL2xpbnV4L3NwaS9zcGktbWVtLmggfCA1ICsrKysrCj4gPiAgMiBmaWxlcyBjaGFu Z2VkLCAxMCBpbnNlcnRpb25zKCspCj4gPiAKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3NwaS9z cGktbWVtLmMgYi9kcml2ZXJzL3NwaS9zcGktbWVtLmMKPiA+IGluZGV4IGVkOTY2ZDgxMjllYi4u ZjM4YWMzMTk2MWM5IDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9zcGkvc3BpLW1lbS5jCj4gPiAr KysgYi9kcml2ZXJzL3NwaS9zcGktbWVtLmMKPiA+IEBAIC0xNzgsNiArMTc4LDExIEBAIGJvb2wg c3BpX21lbV9kZWZhdWx0X3N1cHBvcnRzX29wKHN0cnVjdCBzcGlfbWVtICptZW0sCj4gPiAgCQkJ cmV0dXJuIGZhbHNlOwo+ID4gIAl9Cj4gPiAgCj4gPiArCWlmIChvcC0+ZGF0YS5lY2MpIHsKPiA+ ICsJCWlmICghc3BpX21lbV9jb250cm9sbGVyX2lzX2NhcGFibGUoY3RsciwgZWNjKSkKPiA+ICsJ CQlyZXR1cm4gZmFsc2U7Cj4gPiArCX0gIAo+IAo+IE5pdDoKPiAKPiAJaWYgKG9wLT5kYXRhLmVj YyAmJgo+IAkgICAgIXNwaV9tZW1fY29udHJvbGxlcl9pc19jYXBhYmxlKGN0bHIsIGVjYykpCj4g CQlyZXR1cm4gZmFsc2U7Cj4gCgpBY3R1YWxseSBJIHdhbnRlZCBvbiBwdXJwb3NlIHRvIGRpc3Rp bmd1aXNoIHRoZSBkaWZmZXJlbnQgY2hlY2tzOgoKaWYgKGR0cikgewoJZG8gc29tZXRoaW5nIGhl cmU7Cn0KCmlmIChlY2MpIHsKCWRvIHNvbWV0aGluZyBlbHNlOwp9CgpyZXR1cm47CgphbmQgaW4g b3JkZXIgdG8ga2VlcCB0aGVtIHRpZHkgSSB1c2VkIGluZGVwZW5kZW50IGlmIHN0YXRlbWVudHMg d2l0aGluCmVhY2ggb2YgdGhlc2UgOikKCj4gPiArCj4gPiAgCXJldHVybiBzcGlfbWVtX2NoZWNr X2J1c3dpZHRoKG1lbSwgb3ApOwo+ID4gIH0KPiA+ICBFWFBPUlRfU1lNQk9MX0dQTChzcGlfbWVt X2RlZmF1bHRfc3VwcG9ydHNfb3ApOwo+ID4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvbGludXgvc3Bp L3NwaS1tZW0uaCBiL2luY2x1ZGUvbGludXgvc3BpL3NwaS1tZW0uaAo+ID4gaW5kZXggNGExYmZl Njg5ODcyLi4wNTEwNTBiNDAzMDkgMTAwNjQ0Cj4gPiAtLS0gYS9pbmNsdWRlL2xpbnV4L3NwaS9z cGktbWVtLmgKPiA+ICsrKyBiL2luY2x1ZGUvbGludXgvc3BpL3NwaS1tZW0uaAo+ID4gQEAgLTg5 LDYgKzg5LDcgQEAgZW51bSBzcGlfbWVtX2RhdGFfZGlyIHsKPiA+ICAgKiBAZHVtbXkuZHRyOiB3 aGV0aGVyIHRoZSBkdW1teSBieXRlcyBzaG91bGQgYmUgc2VudCBpbiBEVFIgbW9kZSBvciBub3QK PiA+ICAgKiBAZGF0YS5idXN3aWR0aDogbnVtYmVyIG9mIElPIGxhbmVzIHVzZWQgdG8gc2VuZC9y ZWNlaXZlIHRoZSBkYXRhCj4gPiAgICogQGRhdGEuZHRyOiB3aGV0aGVyIHRoZSBkYXRhIHNob3Vs ZCBiZSBzZW50IGluIERUUiBtb2RlIG9yIG5vdAo+ID4gKyAqIEBkYXRhLmVjYzogd2hldGhlciBl cnJvciBjb3JyZWN0aW9uIGlzIHJlcXVpcmVkIG9yIG5vdAo+ID4gICAqIEBkYXRhLmRpcjogZGly ZWN0aW9uIG9mIHRoZSB0cmFuc2Zlcgo+ID4gICAqIEBkYXRhLm5ieXRlczogbnVtYmVyIG9mIGRh dGEgYnl0ZXMgdG8gc2VuZC9yZWNlaXZlLiBDYW4gYmUgemVybyBpZiB0aGUKPiA+ICAgKgkJIG9w ZXJhdGlvbiBkb2VzIG5vdCBpbnZvbHZlIHRyYW5zZmVycmluZyBkYXRhCj4gPiBAQCAtMTE5LDYg KzEyMCw3IEBAIHN0cnVjdCBzcGlfbWVtX29wIHsKPiA+ICAJc3RydWN0IHsKPiA+ICAJCXU4IGJ1 c3dpZHRoOwo+ID4gIAkJdTggZHRyIDogMTsKPiA+ICsJCXU4IGVjYyA6IDE7Cj4gPiAgCQllbnVt IHNwaV9tZW1fZGF0YV9kaXIgZGlyOwo+ID4gIAkJdW5zaWduZWQgaW50IG5ieXRlczsKPiA+ICAJ CXVuaW9uIHsKPiA+IEBAIC0xMjYsNiArMTI4LDcgQEAgc3RydWN0IHNwaV9tZW1fb3Agewo+ID4g IAkJCWNvbnN0IHZvaWQgKm91dDsKPiA+ICAJCX0gYnVmOwo+ID4gIAl9IGRhdGE7Cj4gPiArCj4g PiAgfTsKPiA+ICAKPiA+ICAjZGVmaW5lIFNQSV9NRU1fT1AoX19jbWQsIF9fYWRkciwgX19kdW1t eSwgX19kYXRhKQkJXAo+ID4gQEAgLTI4OCw5ICsyOTEsMTEgQEAgc3RydWN0IHNwaV9jb250cm9s bGVyX21lbV9vcHMgewo+ID4gIC8qKgo+ID4gICAqIHN0cnVjdCBzcGlfY29udHJvbGxlcl9tZW1f Y2FwcyAtIFNQSSBtZW1vcnkgY29udHJvbGxlciBjYXBhYmlsaXRpZXMKPiA+ICAgKiBAZHRyOiBT dXBwb3J0cyBEVFIgb3BlcmF0aW9ucwo+ID4gKyAqIEBlY2M6IFN1cHBvcnRzIG9wZXJhdGlvbnMg d2l0aCBlcnJvciBjb3JyZWN0aW9uCj4gPiAgICovCj4gPiAgc3RydWN0IHNwaV9jb250cm9sbGVy X21lbV9jYXBzIHsKPiA+ICAJYm9vbCBkdHI7Cj4gPiArCWJvb2wgZWNjOwo+ID4gIH07Cj4gPiAg Cj4gPiAgI2RlZmluZSBzcGlfbWVtX2NvbnRyb2xsZXJfaXNfY2FwYWJsZShjdGxyLCBjYXApCVwg IAo+IAoKClRoYW5rcywKTWlxdcOobAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCkxpbnV4IE1URCBkaXNjdXNzaW9uIG1haWxpbmcgbGlzdApo dHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LW10ZC8K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFC5EC433EF for ; Tue, 4 Jan 2022 09:24:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229609AbiADJYj convert rfc822-to-8bit (ORCPT ); Tue, 4 Jan 2022 04:24:39 -0500 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:38451 "EHLO relay5-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229507AbiADJYi (ORCPT ); Tue, 4 Jan 2022 04:24:38 -0500 Received: (Authenticated sender: miquel.raynal@bootlin.com) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id E0A671C0002; Tue, 4 Jan 2022 09:24:34 +0000 (UTC) Date: Tue, 4 Jan 2022 10:24:33 +0100 From: Miquel Raynal To: Boris Brezillon Cc: Richard Weinberger , Vignesh Raghavendra , Tudor Ambarus , Pratyush Yadav , Michael Walle , , Mark Brown , , Julien Su , Jaime Liao , Thomas Petazzoni , Xiangsheng Hou Subject: Re: [PATCH v9 06/13] spi: spi-mem: Add an ecc parameter to the spi_mem_op structure Message-ID: <20220104102433.0ad3bb2c@xps13> In-Reply-To: <20220104100230.1076beed@collabora.com> References: <20220104083631.40776-1-miquel.raynal@bootlin.com> <20220104083631.40776-7-miquel.raynal@bootlin.com> <20220104100230.1076beed@collabora.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org Hello Boris, boris.brezillon@collabora.com wrote on Tue, 4 Jan 2022 10:02:30 +0100: > On Tue, 4 Jan 2022 09:36:24 +0100 > Miquel Raynal wrote: > > > Soon the SPI-NAND core will need a way to request a SPI controller to > > enable ECC support for a given operation. This is because of the > > pipelined integration of certain ECC engines, which are directly managed > > by the SPI controller itself. > > > > Introduce a spi_mem_op additional field for this purpose: ecc. > > > > So far this field is left unset and checked to be false by all > > the SPI controller drivers in their ->supports_op() hook, as they all > > call spi_mem_default_supports_op(). > > > > Signed-off-by: Miquel Raynal > > Acked-by: Pratyush Yadav > > --- > > drivers/spi/spi-mem.c | 5 +++++ > > include/linux/spi/spi-mem.h | 5 +++++ > > 2 files changed, 10 insertions(+) > > > > diff --git a/drivers/spi/spi-mem.c b/drivers/spi/spi-mem.c > > index ed966d8129eb..f38ac31961c9 100644 > > --- a/drivers/spi/spi-mem.c > > +++ b/drivers/spi/spi-mem.c > > @@ -178,6 +178,11 @@ bool spi_mem_default_supports_op(struct spi_mem *mem, > > return false; > > } > > > > + if (op->data.ecc) { > > + if (!spi_mem_controller_is_capable(ctlr, ecc)) > > + return false; > > + } > > Nit: > > if (op->data.ecc && > !spi_mem_controller_is_capable(ctlr, ecc)) > return false; > Actually I wanted on purpose to distinguish the different checks: if (dtr) { do something here; } if (ecc) { do something else; } return; and in order to keep them tidy I used independent if statements within each of these :) > > + > > return spi_mem_check_buswidth(mem, op); > > } > > EXPORT_SYMBOL_GPL(spi_mem_default_supports_op); > > diff --git a/include/linux/spi/spi-mem.h b/include/linux/spi/spi-mem.h > > index 4a1bfe689872..051050b40309 100644 > > --- a/include/linux/spi/spi-mem.h > > +++ b/include/linux/spi/spi-mem.h > > @@ -89,6 +89,7 @@ enum spi_mem_data_dir { > > * @dummy.dtr: whether the dummy bytes should be sent in DTR mode or not > > * @data.buswidth: number of IO lanes used to send/receive the data > > * @data.dtr: whether the data should be sent in DTR mode or not > > + * @data.ecc: whether error correction is required or not > > * @data.dir: direction of the transfer > > * @data.nbytes: number of data bytes to send/receive. Can be zero if the > > * operation does not involve transferring data > > @@ -119,6 +120,7 @@ struct spi_mem_op { > > struct { > > u8 buswidth; > > u8 dtr : 1; > > + u8 ecc : 1; > > enum spi_mem_data_dir dir; > > unsigned int nbytes; > > union { > > @@ -126,6 +128,7 @@ struct spi_mem_op { > > const void *out; > > } buf; > > } data; > > + > > }; > > > > #define SPI_MEM_OP(__cmd, __addr, __dummy, __data) \ > > @@ -288,9 +291,11 @@ struct spi_controller_mem_ops { > > /** > > * struct spi_controller_mem_caps - SPI memory controller capabilities > > * @dtr: Supports DTR operations > > + * @ecc: Supports operations with error correction > > */ > > struct spi_controller_mem_caps { > > bool dtr; > > + bool ecc; > > }; > > > > #define spi_mem_controller_is_capable(ctlr, cap) \ > Thanks, Miquèl