From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 08DDAC433EF for ; Wed, 5 Jan 2022 11:06:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IQDR6IGMQ+Aca1V6nehTQiW/tsaVQqK4QMRrNacJZgY=; b=xLYcLNxPMbBT2C MM6uayKlyYW8ST8x+Vd5TyBiEnv4BHcx3lgRThHnAtxU2X6QOllmws/PT9XTY6bm+EKf1yJOvYh+L DGSdR9OAy0ftngQOhDXuJ6QSbTQdvfCaDKnaYqQsKcAcAopiMCN99xC57TJ6hzX7yvaHbnAHCuVAB rb5Zqm0YkUePcBn2UvolKI7XA5JwKC1cTiAi9HXM1ZaBGqU6ac55xPrbpJca/y3KPr9iLvg3GzK0r 867rnDqvpDzW4/vjC+SFbi1BJ3PMDzlTfVv5iWc3YQKfbtRSW+M4ypvV/OGzvR+k6CZb0J+TaCfVd JK7CdEaueSjG3AkcOYUQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n5462-00EbzM-6b; Wed, 05 Jan 2022 11:04:46 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n545y-00Ebyj-LE for linux-arm-kernel@lists.infradead.org; Wed, 05 Jan 2022 11:04:44 +0000 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n545t-0008W1-8N; Wed, 05 Jan 2022 12:04:37 +0100 Received: from ore by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1n545q-0004qQ-DW; Wed, 05 Jan 2022 12:04:34 +0100 Date: Wed, 5 Jan 2022 12:04:34 +0100 From: Oleksij Rempel To: Shawn Guo Cc: Mark Rutland , Rob Herring , Sascha Hauer , Thierry Reding , Sam Ravnborg , David Airlie , Daniel Vetter , devicetree@vger.kernel.org, Fabio Estevam , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, NXP Linux Team , Pengutronix Kernel Team , David Jander , Robin van der Gracht , dri-devel@lists.freedesktop.org, Jonathan Cameron Subject: Re: [PATCH v1 4/4] ARM: dts: imx6dl: plym2m, prtvt7, victgo: make use of new resistive-adc-touch driver Message-ID: <20220105110434.GG303@pengutronix.de> References: <20211122124310.2796505-1-o.rempel@pengutronix.de> <20211122124310.2796505-4-o.rempel@pengutronix.de> <20211206010627.GK4216@dragon> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211206010627.GK4216@dragon> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 11:58:52 up 25 days, 19:44, 81 users, load average: 1.02, 1.06, 1.07 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220105_030442_729156_6E40753E X-CRM114-Status: GOOD ( 28.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Shawn, sorry for the delay, I just came back to work. On Mon, Dec 06, 2021 at 09:06:28AM +0800, Shawn Guo wrote: > On Mon, Nov 22, 2021 at 01:43:10PM +0100, Oleksij Rempel wrote: > > The tsc2046 is an ADC used as touchscreen controller. To share as mach > > code as possible, we should use it as actual ADC + virtual tochscreen > > controller. > > With this patch we make use of the new kernel IIO and HID infrastructure. > > > > Signed-off-by: Oleksij Rempel > > One space is enough in subject "victgo: make". done. > > --- > > arch/arm/boot/dts/imx6dl-plym2m.dts | 55 ++++++++++++++++++++--------- > > arch/arm/boot/dts/imx6dl-prtvt7.dts | 53 ++++++++++++++++++++------- > > arch/arm/boot/dts/imx6dl-victgo.dts | 55 +++++++++++++++++++++-------- > > 3 files changed, 120 insertions(+), 43 deletions(-) > > > > diff --git a/arch/arm/boot/dts/imx6dl-plym2m.dts b/arch/arm/boot/dts/imx6dl-plym2m.dts > > index 60fe5f14666e..e2afedae85cb 100644 > > --- a/arch/arm/boot/dts/imx6dl-plym2m.dts > > +++ b/arch/arm/boot/dts/imx6dl-plym2m.dts > > @@ -101,6 +101,17 @@ reg_12v0: regulator-12v0 { > > regulator-min-microvolt = <12000000>; > > regulator-max-microvolt = <12000000>; > > }; > > + > > + touchscreen { > > + compatible = "resistive-adc-touch"; > > + io-channels = <&adc 1>, <&adc 3>, <&adc 4>, <&adc 5>; > > + io-channel-names = "y", "z1", "z2", "x"; > > + touchscreen-min-pressure = <64687>; > > + touchscreen-inverted-x; > > + touchscreen-inverted-y; > > + touchscreen-x-plate-ohms = <300>; > > + touchscreen-y-plate-ohms = <800>; > > + }; > > }; > > > > &can1 { > > @@ -129,26 +140,38 @@ &ecspi2 { > > pinctrl-0 = <&pinctrl_ecspi2>; > > status = "okay"; > > > > - touchscreen@0 { > > - compatible = "ti,tsc2046"; > > + adc: adc@0 { > > Isn't label name "adc" too generic? I do not have strong opinion about this. Currently we have no restrictions for the node names: Documentation/devicetree/bindings/iio/adc/ti,tsc2046.yaml Documentation/devicetree/bindings/iio/adc/adc.yaml I can name it touchscreen-adc@0 or something like this. What are your preferences? Regards, Oleksij -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFB05C433EF for ; Wed, 5 Jan 2022 11:04:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235066AbiAELEn (ORCPT ); Wed, 5 Jan 2022 06:04:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51848 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239614AbiAELEl (ORCPT ); Wed, 5 Jan 2022 06:04:41 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2A6D4C061761 for ; Wed, 5 Jan 2022 03:04:41 -0800 (PST) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n545t-0008W1-8N; Wed, 05 Jan 2022 12:04:37 +0100 Received: from ore by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1n545q-0004qQ-DW; Wed, 05 Jan 2022 12:04:34 +0100 Date: Wed, 5 Jan 2022 12:04:34 +0100 From: Oleksij Rempel To: Shawn Guo Cc: Mark Rutland , Rob Herring , Sascha Hauer , Thierry Reding , Sam Ravnborg , David Airlie , Daniel Vetter , devicetree@vger.kernel.org, Fabio Estevam , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, NXP Linux Team , Pengutronix Kernel Team , David Jander , Robin van der Gracht , dri-devel@lists.freedesktop.org, Jonathan Cameron Subject: Re: [PATCH v1 4/4] ARM: dts: imx6dl: plym2m, prtvt7, victgo: make use of new resistive-adc-touch driver Message-ID: <20220105110434.GG303@pengutronix.de> References: <20211122124310.2796505-1-o.rempel@pengutronix.de> <20211122124310.2796505-4-o.rempel@pengutronix.de> <20211206010627.GK4216@dragon> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20211206010627.GK4216@dragon> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 11:58:52 up 25 days, 19:44, 81 users, load average: 1.02, 1.06, 1.07 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: devicetree@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Shawn, sorry for the delay, I just came back to work. On Mon, Dec 06, 2021 at 09:06:28AM +0800, Shawn Guo wrote: > On Mon, Nov 22, 2021 at 01:43:10PM +0100, Oleksij Rempel wrote: > > The tsc2046 is an ADC used as touchscreen controller. To share as mach > > code as possible, we should use it as actual ADC + virtual tochscreen > > controller. > > With this patch we make use of the new kernel IIO and HID infrastructure. > > > > Signed-off-by: Oleksij Rempel > > One space is enough in subject "victgo: make". done. > > --- > > arch/arm/boot/dts/imx6dl-plym2m.dts | 55 ++++++++++++++++++++--------- > > arch/arm/boot/dts/imx6dl-prtvt7.dts | 53 ++++++++++++++++++++------- > > arch/arm/boot/dts/imx6dl-victgo.dts | 55 +++++++++++++++++++++-------- > > 3 files changed, 120 insertions(+), 43 deletions(-) > > > > diff --git a/arch/arm/boot/dts/imx6dl-plym2m.dts b/arch/arm/boot/dts/imx6dl-plym2m.dts > > index 60fe5f14666e..e2afedae85cb 100644 > > --- a/arch/arm/boot/dts/imx6dl-plym2m.dts > > +++ b/arch/arm/boot/dts/imx6dl-plym2m.dts > > @@ -101,6 +101,17 @@ reg_12v0: regulator-12v0 { > > regulator-min-microvolt = <12000000>; > > regulator-max-microvolt = <12000000>; > > }; > > + > > + touchscreen { > > + compatible = "resistive-adc-touch"; > > + io-channels = <&adc 1>, <&adc 3>, <&adc 4>, <&adc 5>; > > + io-channel-names = "y", "z1", "z2", "x"; > > + touchscreen-min-pressure = <64687>; > > + touchscreen-inverted-x; > > + touchscreen-inverted-y; > > + touchscreen-x-plate-ohms = <300>; > > + touchscreen-y-plate-ohms = <800>; > > + }; > > }; > > > > &can1 { > > @@ -129,26 +140,38 @@ &ecspi2 { > > pinctrl-0 = <&pinctrl_ecspi2>; > > status = "okay"; > > > > - touchscreen@0 { > > - compatible = "ti,tsc2046"; > > + adc: adc@0 { > > Isn't label name "adc" too generic? I do not have strong opinion about this. Currently we have no restrictions for the node names: Documentation/devicetree/bindings/iio/adc/ti,tsc2046.yaml Documentation/devicetree/bindings/iio/adc/adc.yaml I can name it touchscreen-adc@0 or something like this. What are your preferences? Regards, Oleksij -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1525DC433EF for ; Wed, 5 Jan 2022 11:04:54 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 65AC710E239; Wed, 5 Jan 2022 11:04:53 +0000 (UTC) Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by gabe.freedesktop.org (Postfix) with ESMTPS id C53A210E239 for ; Wed, 5 Jan 2022 11:04:51 +0000 (UTC) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n545t-0008W1-8N; Wed, 05 Jan 2022 12:04:37 +0100 Received: from ore by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1n545q-0004qQ-DW; Wed, 05 Jan 2022 12:04:34 +0100 Date: Wed, 5 Jan 2022 12:04:34 +0100 From: Oleksij Rempel To: Shawn Guo Subject: Re: [PATCH v1 4/4] ARM: dts: imx6dl: plym2m, prtvt7, victgo: make use of new resistive-adc-touch driver Message-ID: <20220105110434.GG303@pengutronix.de> References: <20211122124310.2796505-1-o.rempel@pengutronix.de> <20211122124310.2796505-4-o.rempel@pengutronix.de> <20211206010627.GK4216@dragon> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20211206010627.GK4216@dragon> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 11:58:52 up 25 days, 19:44, 81 users, load average: 1.02, 1.06, 1.07 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: dri-devel@lists.freedesktop.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Pengutronix Kernel Team , Robin van der Gracht , David Airlie , Sascha Hauer , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Jonathan Cameron , Rob Herring , Thierry Reding , NXP Linux Team , David Jander , Sam Ravnborg , linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Shawn, sorry for the delay, I just came back to work. On Mon, Dec 06, 2021 at 09:06:28AM +0800, Shawn Guo wrote: > On Mon, Nov 22, 2021 at 01:43:10PM +0100, Oleksij Rempel wrote: > > The tsc2046 is an ADC used as touchscreen controller. To share as mach > > code as possible, we should use it as actual ADC + virtual tochscreen > > controller. > > With this patch we make use of the new kernel IIO and HID infrastructure. > > > > Signed-off-by: Oleksij Rempel > > One space is enough in subject "victgo: make". done. > > --- > > arch/arm/boot/dts/imx6dl-plym2m.dts | 55 ++++++++++++++++++++--------- > > arch/arm/boot/dts/imx6dl-prtvt7.dts | 53 ++++++++++++++++++++------- > > arch/arm/boot/dts/imx6dl-victgo.dts | 55 +++++++++++++++++++++-------- > > 3 files changed, 120 insertions(+), 43 deletions(-) > > > > diff --git a/arch/arm/boot/dts/imx6dl-plym2m.dts b/arch/arm/boot/dts/imx6dl-plym2m.dts > > index 60fe5f14666e..e2afedae85cb 100644 > > --- a/arch/arm/boot/dts/imx6dl-plym2m.dts > > +++ b/arch/arm/boot/dts/imx6dl-plym2m.dts > > @@ -101,6 +101,17 @@ reg_12v0: regulator-12v0 { > > regulator-min-microvolt = <12000000>; > > regulator-max-microvolt = <12000000>; > > }; > > + > > + touchscreen { > > + compatible = "resistive-adc-touch"; > > + io-channels = <&adc 1>, <&adc 3>, <&adc 4>, <&adc 5>; > > + io-channel-names = "y", "z1", "z2", "x"; > > + touchscreen-min-pressure = <64687>; > > + touchscreen-inverted-x; > > + touchscreen-inverted-y; > > + touchscreen-x-plate-ohms = <300>; > > + touchscreen-y-plate-ohms = <800>; > > + }; > > }; > > > > &can1 { > > @@ -129,26 +140,38 @@ &ecspi2 { > > pinctrl-0 = <&pinctrl_ecspi2>; > > status = "okay"; > > > > - touchscreen@0 { > > - compatible = "ti,tsc2046"; > > + adc: adc@0 { > > Isn't label name "adc" too generic? I do not have strong opinion about this. Currently we have no restrictions for the node names: Documentation/devicetree/bindings/iio/adc/ti,tsc2046.yaml Documentation/devicetree/bindings/iio/adc/adc.yaml I can name it touchscreen-adc@0 or something like this. What are your preferences? Regards, Oleksij -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |