From: Dan Carpenter <dan.carpenter@oracle.com>
To: Ismayil Mirzali <ismayilmirzeli@gmail.com>
Cc: linux-staging@lists.linux.dev, gregkh@linuxfoundation.org,
fabioaiuto83@gmail.com, linux@roeck-us.net, paskripkin@gmail.com
Subject: Re: [PATCH v3 1/2] staging: rtl8723bs: address style guide warnings
Date: Wed, 5 Jan 2022 17:47:09 +0300 [thread overview]
Message-ID: <20220105144709.GF7674@kadam> (raw)
In-Reply-To: <3bddd2a8c02540c56a48d6844b3fcd897441803b.1640197297.git.ismayilmirzeli@gmail.com>
On Wed, Dec 22, 2021 at 08:51:14PM +0200, Ismayil Mirzali wrote:
> @@ -247,6 +246,7 @@ static s32 xmit_xmitframes(struct adapter *padapter, struct xmit_priv *pxmitpriv
> if (pxmitbuf->len > 0 &&
> pxmitbuf->priv_data) {
> struct xmit_frame *pframe;
> +
> pframe = (struct xmit_frame *)pxmitbuf->priv_data;
> pframe->agg_num = k;
> pxmitbuf->agg_num = k;
> @@ -333,6 +333,7 @@ static s32 xmit_xmitframes(struct adapter *padapter, struct xmit_priv *pxmitpriv
> if (pxmitbuf) {
> if (pxmitbuf->len > 0) {
> struct xmit_frame *pframe;
> +
> pframe = (struct xmit_frame *)pxmitbuf->priv_data;
Separate patches.
> @@ -428,10 +427,9 @@ int rtl8723bs_xmit_thread(void *context)
>
> do {
> ret = rtl8723bs_xmit_handler(padapter);
> - if (signal_pending(current)) {
> + if (signal_pending(current))
> flush_signals(current);
> - }
> - } while (_SUCCESS == ret);
> + } while (ret == _SUCCESS);
Separate patch.
>
> complete(&pxmitpriv->SdioXmitTerminate);
regards,
dan carpenter
next prev parent reply other threads:[~2022-01-05 14:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-22 18:51 [PATCH v3 0/2] Fix styling issues and remove unused code in rtl8723bs Ismayil Mirzali
2021-12-22 18:51 ` [PATCH v3 1/2] staging: rtl8723bs: address style guide warnings Ismayil Mirzali
2021-12-23 7:25 ` Greg KH
2022-01-05 14:47 ` Dan Carpenter [this message]
2021-12-22 18:51 ` [PATCH v3 2/2] staging: rtl8723bs: removed unused if blocks Ismayil Mirzali
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220105144709.GF7674@kadam \
--to=dan.carpenter@oracle.com \
--cc=fabioaiuto83@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=ismayilmirzeli@gmail.com \
--cc=linux-staging@lists.linux.dev \
--cc=linux@roeck-us.net \
--cc=paskripkin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.