From: Jason Gunthorpe <jgg@nvidia.com>
To: Leon Romanovsky <leon@kernel.org>
Cc: Leon Romanovsky <leonro@nvidia.com>,
linux-rdma@vger.kernel.org,
syzbot+6d532fa8f9463da290bc@syzkaller.appspotmail.com
Subject: Re: [PATCH rdma-rc] RDMA/core: Don't infoleak GRH fields
Date: Wed, 5 Jan 2022 16:33:23 -0400 [thread overview]
Message-ID: <20220105203323.GA2887765@nvidia.com> (raw)
In-Reply-To: <0e9dd51f93410b7b2f4f5562f52befc878b71afa.1641298868.git.leonro@nvidia.com>
On Tue, Jan 04, 2022 at 02:21:52PM +0200, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@nvidia.com>
>
> If dst->is_global field is not set, the GRH fields are not cleared
> and the following infoleak is reported.
>
> =====================================================
> BUG: KMSAN: kernel-infoleak in instrument_copy_to_user include/linux/instrumented.h:121 [inline]
> BUG: KMSAN: kernel-infoleak in _copy_to_user+0x1c9/0x270 lib/usercopy.c:33
> instrument_copy_to_user include/linux/instrumented.h:121 [inline]
> _copy_to_user+0x1c9/0x270 lib/usercopy.c:33
> copy_to_user include/linux/uaccess.h:209 [inline]
> ucma_init_qp_attr+0x8c7/0xb10 drivers/infiniband/core/ucma.c:1242
> ucma_write+0x637/0x6c0 drivers/infiniband/core/ucma.c:1732
> vfs_write+0x8ce/0x2030 fs/read_write.c:588
> ksys_write+0x28b/0x510 fs/read_write.c:643
> __do_sys_write fs/read_write.c:655 [inline]
> __se_sys_write fs/read_write.c:652 [inline]
> __ia32_sys_write+0xdb/0x120 fs/read_write.c:652
> do_syscall_32_irqs_on arch/x86/entry/common.c:114 [inline]
> __do_fast_syscall_32+0x96/0xf0 arch/x86/entry/common.c:180
> do_fast_syscall_32+0x34/0x70 arch/x86/entry/common.c:205
> do_SYSENTER_32+0x1b/0x20 arch/x86/entry/common.c:248
> entry_SYSENTER_compat_after_hwframe+0x4d/0x5c
>
> Local variable resp created at:
> ucma_init_qp_attr+0xa4/0xb10 drivers/infiniband/core/ucma.c:1214
> ucma_write+0x637/0x6c0 drivers/infiniband/core/ucma.c:1732
>
> Bytes 40-59 of 144 are uninitialized
> Memory access of size 144 starts at ffff888167523b00
> Data copied to user address 0000000020000100
>
> CPU: 1 PID: 25910 Comm: syz-executor.1 Not tainted 5.16.0-rc5-syzkaller #0
> Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
> =====================================================
>
> Fixes: 4ba66093bdc6 ("IB/core: Check for global flag when using ah_attr")
> Reported-by: syzbot+6d532fa8f9463da290bc@syzkaller.appspotmail.com
> Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
> ---
> drivers/infiniband/core/uverbs_marshall.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to for-rc, thanks
Jason
prev parent reply other threads:[~2022-01-05 20:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-04 12:21 [PATCH rdma-rc] RDMA/core: Don't infoleak GRH fields Leon Romanovsky
2022-01-05 20:33 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220105203323.GA2887765@nvidia.com \
--to=jgg@nvidia.com \
--cc=leon@kernel.org \
--cc=leonro@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
--cc=syzbot+6d532fa8f9463da290bc@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.