From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Bernd Kuhls <bernd.kuhls@t-online.de>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v3 1/1] package/vdr: enable musl/uclibc build
Date: Wed, 5 Jan 2022 21:36:28 +0100 [thread overview]
Message-ID: <20220105213628.763562b2@windsurf> (raw)
In-Reply-To: <20220101120920.2809336-1-bernd.kuhls@t-online.de>
Hello Bernd,
On Sat, 1 Jan 2022 13:09:20 +0100
Bernd Kuhls <bernd.kuhls@t-online.de> wrote:
> Re-add patch 0001 to fix uClibc build, this patch was removed 2019:
> https://git.buildroot.net/buildroot/commit/?id=573d15b0790cfd2838cf0544ded79b415e20f5a7
>
> Add two more patches from Alpine Linux to fix musl build.
>
> Add optional dependency to libexecinfo to provide execinfo.h.
>
> Depend on BR2_SYSTEM_ENABLE_NLS to have gettext being added as
> dependency to provide _nl_msg_cat_cntr() needed by i18n.c.
>
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
> v3: rework nls/gettext dependencies (Thomas)
> v2: no changes
I have applied, but after dropping the NLS dependency. Indeed, the
_nl_msg_cat_cntr symbol is an internal symbol of gettext, which only
glibc and uclibc provide in their built-in libintl implementation. Even
the stub libintl-musl from the gettext-tiny project implements
_nl_msg_cat_cntr as a dummy symbol, which really tells us that it
serves no purpose on musl toolchains. So I've just added a patch for
vdr that ensures _nl_msg_cat_cntr is only used on glibc/uclibc
toolchains, by checking __GLIBC__.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2022-01-05 20:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-01 12:09 [Buildroot] [PATCH v3 1/1] package/vdr: enable musl/uclibc build Bernd Kuhls
2022-01-05 20:36 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220105213628.763562b2@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=bernd.kuhls@t-online.de \
--cc=buildroot@buildroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.