From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: "José Pekkarinen" <jose.pekkarinen@unikie.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/opensc: new package
Date: Wed, 5 Jan 2022 21:59:08 +0100 [thread overview]
Message-ID: <20220105215908.1d8677b3@windsurf> (raw)
In-Reply-To: <20211213061551.4110-1-jose.pekkarinen@unikie.com>
Hello José,
On Mon, 13 Dec 2021 08:15:51 +0200
José Pekkarinen <jose.pekkarinen@unikie.com> wrote:
> The patch will add opensc package.
>
> Signed-off-by: José Pekkarinen <jose.pekkarinen@unikie.com>
I'm afraid that when I read the feedback from upstream in your patches,
saying that they introduce memory leaks (and indeed they do), I'm not
really keen on merging this.
However, I saw you told upstream:
It is a bit of a chiken and egg problem. Buildroot wants me to
upstream the patches before the package would be accesible to you,
you want me to give a testing case that doesn't come easy without
upstreaming the package.
This is not totally correct for two reason:
* we don't require patches to be accepted upstream, except if we have
serious doubts about the patches.
* the package doesn't have to be accepted in Buildroot upstream to
provide an easy way for the opensc developers to reproduce the
issue. You can provide a Buildroot branch on a public Git
repository, with the opensc package, and a very simple
opensc_demo_defconfig in configs/ that uses some external toolchain
and builds just opensc to demonstrate the build failure. Then for
the opensc people, reproducing is as easy as:
git clone -b <yourbranch> git://your.repository.com
cd buildroot/
make opensc_demo_defconfig
make
Could you resolve the remaining issues and send an updated patch? Also,
please remember to add a version to your patches when submitting, it
really makes things easier.
Best regards,
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-01-05 20:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-13 6:15 [Buildroot] [PATCH] package/opensc: new package José Pekkarinen
2022-01-05 20:59 ` Thomas Petazzoni [this message]
2022-01-10 5:29 ` José Pekkarinen
-- strict thread matches above, loose matches on Subject: below --
2021-12-13 6:11 José Pekkarinen
2021-12-13 6:14 ` José Pekkarinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220105215908.1d8677b3@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@buildroot.org \
--cc=jose.pekkarinen@unikie.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.