All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Yang Yingliang <yangyingliang@huawei.com>
Cc: linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org,
	marcel@holtmann.org, johan.hedberg@gmail.com,
	luiz.dentz@gmail.com
Subject: Re: [PATCH -next] Bluetooth: virtio_bt: fix error return code in virtbt_probe()
Date: Thu, 6 Jan 2022 07:37:50 -0500	[thread overview]
Message-ID: <20220106073725-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20211213082751.745001-1-yangyingliang@huawei.com>

On Mon, Dec 13, 2021 at 04:27:51PM +0800, Yang Yingliang wrote:
> Fix to return a negative error code from the error handling
> case in virtbt_probe().
> 
> Fixes: 212a6e51a630 ("Bluetooth: virtio_bt: fix device removal")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>

Acked-by: Michael S. Tsirkin <mst@redhat.com>

same patch was also posted by Dan Carpenter.

> ---
>  drivers/bluetooth/virtio_bt.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/bluetooth/virtio_bt.c b/drivers/bluetooth/virtio_bt.c
> index 1dd734aef87b..f6d699fed139 100644
> --- a/drivers/bluetooth/virtio_bt.c
> +++ b/drivers/bluetooth/virtio_bt.c
> @@ -362,7 +362,8 @@ static int virtbt_probe(struct virtio_device *vdev)
>  	}
>  
>  	virtio_device_ready(vdev);
> -	if (virtbt_open_vdev(vbt))
> +	err = virtbt_open_vdev(vbt);
> +	if (err)
>  		goto open_failed;
>  
>  	return 0;
> -- 
> 2.25.1


      reply	other threads:[~2022-01-06 12:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-13  8:27 [PATCH -next] Bluetooth: virtio_bt: fix error return code in virtbt_probe() Yang Yingliang
2022-01-06 12:37 ` Michael S. Tsirkin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220106073725-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=johan.hedberg@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luiz.dentz@gmail.com \
    --cc=marcel@holtmann.org \
    --cc=yangyingliang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.