All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Cc: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
	axboe@kernel.dk, chaitanya.kulkarni@wdc.com,
	damien.lemoal@wdc.com, ming.lei@redhat.com,
	Johannes.Thumshirn@wdc.com, shinichiro.kawasaki@wdc.com,
	jiangguoqing@kylinos.cn, linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] null_blk: Use bitmap_zalloc() when applicable
Date: Thu, 6 Jan 2022 10:44:23 +0300	[thread overview]
Message-ID: <20220106074423.GG7674@kadam> (raw)
In-Reply-To: <c60a1750-ccbb-1f7a-12be-ac331393be80@opensource.wdc.com>

On Thu, Dec 30, 2021 at 11:28:28AM +0900, Damien Le Moal wrote:
> >  
> > -	tag_size = ALIGN(nq->queue_depth, BITS_PER_LONG) / BITS_PER_LONG;
> > -	nq->tag_map = kcalloc(tag_size, sizeof(unsigned long), GFP_KERNEL);
> > +	nq->tag_map = bitmap_zalloc(nq->queue_depth, GFP_KERNEL);
> >  	if (!nq->tag_map) {
> >  		kfree(nq->cmds);
> >  		return -ENOMEM;
> 
> Before this patch, tag_size would always be a multiple of BITS_PER_LONG.
> Using bitmap_zalloc(), that alignment goes away, but I think this is OK.
> 

It's still going to be a multiple of long.  Bitmaps are always stored
in longs.

regards,
dan carpenter


  reply	other threads:[~2022-01-06  7:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-23 21:55 [PATCH] null_blk: Use bitmap_zalloc() when applicable Christophe JAILLET
2021-12-30  2:28 ` Damien Le Moal
2022-01-06  7:44   ` Dan Carpenter [this message]
2022-01-06  7:49     ` Damien Le Moal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220106074423.GG7674@kadam \
    --to=dan.carpenter@oracle.com \
    --cc=Johannes.Thumshirn@wdc.com \
    --cc=axboe@kernel.dk \
    --cc=chaitanya.kulkarni@wdc.com \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=damien.lemoal@opensource.wdc.com \
    --cc=damien.lemoal@wdc.com \
    --cc=jiangguoqing@kylinos.cn \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ming.lei@redhat.com \
    --cc=shinichiro.kawasaki@wdc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.