From: Dan Carpenter <dan.carpenter@oracle.com>
To: Adam Kandur <sys.arch.adam@gmail.com>
Cc: linux-staging@lists.linux.dev
Subject: Re: [PATCH] qlge: refactor qlge_change_rx_buffers() in qlge_main.c
Date: Thu, 6 Jan 2022 11:35:58 +0300 [thread overview]
Message-ID: <20220106083557.GI7674@kadam> (raw)
In-Reply-To: <20211228135756.7343-1-sys.arch.adam@gmail.com>
On Tue, Dec 28, 2021 at 04:57:56PM +0300, Adam Kandur wrote:
> I assume this can be written using for loop instead of while,
> wich looks nicer for me.
The original code was better than your code.
Also we have a published style guidelines. We don't really encourage
people to start enforcing their own weird style preferences which are
not in the style guidelines. Once you are a maintainer then no one can
stop you from having opinions but until then it's best to stick to the
style guideline.
regards,
dan carpenter
next prev parent reply other threads:[~2022-01-06 8:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-28 13:57 [PATCH] qlge: refactor qlge_change_rx_buffers() in qlge_main.c Adam Kandur
2021-12-28 14:45 ` Pavel Skripkin
2022-01-06 8:35 ` Dan Carpenter [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-12-28 12:17 Adam Kandur
2021-12-28 13:05 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220106083557.GI7674@kadam \
--to=dan.carpenter@oracle.com \
--cc=linux-staging@lists.linux.dev \
--cc=sys.arch.adam@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.