All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: baolin.wang@linux.alibaba.com
Cc: linux-mm@kvack.org
Subject: [bug report] mm/damon: add access checking for hugetlb pages
Date: Thu, 6 Jan 2022 12:12:00 +0300	[thread overview]
Message-ID: <20220106091200.GA14564@kili> (raw)

Hello Baolin Wang,

The patch 86522923bb29: "mm/damon: add access checking for hugetlb
pages" from Dec 30, 2021, leads to the following Smatch static
checker warning:

	mm/damon/vaddr.c:405 damon_hugetlb_mkold()
	warn: 'page' can't be NULL.

mm/damon/vaddr.c
    398 static void damon_hugetlb_mkold(pte_t *pte, struct mm_struct *mm,
    399                                 struct vm_area_struct *vma, unsigned long addr)
    400 {
    401         bool referenced = false;
    402         pte_t entry = huge_ptep_get(pte);
    403         struct page *page = pte_page(entry);
    404 
--> 405         if (!page)

I don't think it makes sense to check "page" because we're already dead
if pte_page() starts returning NULL.  Maybe check "entry"?

    406                 return;
    407 
    408         get_page(page);
    409 
    410         if (pte_young(entry)) {
    411                 referenced = true;
    412                 entry = pte_mkold(entry);
    413                 huge_ptep_set_access_flags(vma, addr, pte, entry,
    414                                            vma->vm_flags & VM_WRITE);
    415         }

regards,
dan carpenter


             reply	other threads:[~2022-01-06  9:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-06  9:12 Dan Carpenter [this message]
2022-01-06 10:22 ` [bug report] mm/damon: add access checking for hugetlb pages Baolin Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220106091200.GA14564@kili \
    --to=dan.carpenter@oracle.com \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.