From: Juergen Gross <jgross@suse.com>
To: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org
Cc: samuel.thibault@ens-lyon.org, wl@xen.org,
Juergen Gross <jgross@suse.com>
Subject: [PATCH 08/15] mini-os: eliminate fbfront union member in struct file
Date: Thu, 6 Jan 2022 12:57:34 +0100 [thread overview]
Message-ID: <20220106115741.3219-9-jgross@suse.com> (raw)
In-Reply-To: <20220106115741.3219-1-jgross@suse.com>
Replace the fbfront specific union member in struct file with the
common dev pointer.
Signed-off-by: Juergen Gross <jgross@suse.com>
---
fbfront.c | 2 +-
include/lib.h | 3 ---
lib/sys.c | 4 ++--
3 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/fbfront.c b/fbfront.c
index 6725da1..c8410af 100644
--- a/fbfront.c
+++ b/fbfront.c
@@ -703,7 +703,7 @@ int fbfront_open(struct fbfront_dev *dev)
{
dev->fd = alloc_fd(FTYPE_FB);
printk("fb_open(%s) -> %d\n", dev->nodename, dev->fd);
- files[dev->fd].fb.dev = dev;
+ files[dev->fd].dev = dev;
return dev->fd;
}
#endif
diff --git a/include/lib.h b/include/lib.h
index 0cedae6..2a9a01c 100644
--- a/include/lib.h
+++ b/include/lib.h
@@ -199,9 +199,6 @@ struct file {
struct {
struct kbdfront_dev *dev;
} kbd;
- struct {
- struct fbfront_dev *dev;
- } fb;
#ifdef CONFIG_TPMFRONT
struct {
struct tpmfront_dev *dev;
diff --git a/lib/sys.c b/lib/sys.c
index 62c2020..2d48657 100644
--- a/lib/sys.c
+++ b/lib/sys.c
@@ -287,7 +287,7 @@ int read(int fd, void *buf, size_t nbytes)
case FTYPE_FB: {
int ret, n;
n = nbytes / sizeof(union xenfb_in_event);
- ret = fbfront_receive(files[fd].fb.dev, buf, n);
+ ret = fbfront_receive(files[fd].dev, buf, n);
if (ret <= 0) {
errno = EAGAIN;
return -1;
@@ -480,7 +480,7 @@ int close(int fd)
#endif
#ifdef CONFIG_FBFRONT
case FTYPE_FB:
- shutdown_fbfront(files[fd].fb.dev);
+ shutdown_fbfront(files[fd].dev);
files[fd].type = FTYPE_NONE;
return 0;
#endif
--
2.26.2
next prev parent reply other threads:[~2022-01-06 11:58 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-06 11:57 [PATCH 00/15] mini-os: remove struct file dependency from config Juergen Gross
2022-01-06 11:57 ` [PATCH 01/15] mini-os: split struct file definition from its usage Juergen Gross
2022-01-09 1:17 ` Samuel Thibault
2022-01-06 11:57 ` [PATCH 02/15] mini-os: makes file.read bool and move it ahead of device specific part Juergen Gross
2022-01-09 1:18 ` Samuel Thibault
2022-01-09 1:21 ` Samuel Thibault
2022-01-09 6:12 ` Juergen Gross
2022-01-09 10:20 ` Samuel Thibault
2022-01-09 10:28 ` Juergen Gross
2022-01-09 10:33 ` Samuel Thibault
2022-01-06 11:57 ` [PATCH 03/15] mini-os: make offset a common struct file member for all types Juergen Gross
2022-01-09 1:23 ` Samuel Thibault
2022-01-06 11:57 ` [PATCH 04/15] mini-os: replace multiple fd elements in struct file by common one Juergen Gross
2022-01-09 1:25 ` Samuel Thibault
2022-01-06 11:57 ` [PATCH 05/15] mini-os: introduce a common dev pointer in struct file Juergen Gross
2022-01-09 1:25 ` Samuel Thibault
2022-01-06 11:57 ` [PATCH 06/15] mini-os: eliminate blkfront union member " Juergen Gross
2022-01-09 1:26 ` Samuel Thibault
2022-01-06 11:57 ` [PATCH 07/15] mini-os: eliminate consfront " Juergen Gross
2022-01-09 1:27 ` Samuel Thibault
2022-01-06 11:57 ` Juergen Gross [this message]
2022-01-09 1:27 ` [PATCH 08/15] mini-os: eliminate fbfront " Samuel Thibault
2022-01-06 11:57 ` [PATCH 09/15] mini-os: eliminate kbdfront " Juergen Gross
2022-01-09 1:28 ` Samuel Thibault
2022-01-06 11:57 ` [PATCH 10/15] mini-os: eliminate netfront " Juergen Gross
2022-01-09 1:28 ` Samuel Thibault
2022-01-06 11:57 ` [PATCH 11/15] mini-os: move tpm respgot member of struct file to device specific data Juergen Gross
2022-01-09 1:30 ` Samuel Thibault
2022-01-06 11:57 ` [PATCH 12/15] mini-os: eliminate tpmfront union member in struct file Juergen Gross
2022-01-09 1:30 ` Samuel Thibault
2022-01-06 11:57 ` [PATCH 13/15] mini-os: eliminate tpmtis " Juergen Gross
2022-01-09 1:31 ` Samuel Thibault
2022-01-06 11:57 ` [PATCH 14/15] mini-os: eliminate xenbus " Juergen Gross
2022-01-09 1:32 ` Samuel Thibault
2022-01-06 11:57 ` [PATCH 15/15] mini-os: introduce get_file_from_fd() Juergen Gross
2022-01-09 1:33 ` Samuel Thibault
2022-01-07 2:39 ` [PATCH 00/15] mini-os: remove struct file dependency from config Samuel Thibault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220106115741.3219-9-jgross@suse.com \
--to=jgross@suse.com \
--cc=minios-devel@lists.xenproject.org \
--cc=samuel.thibault@ens-lyon.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.