From: SeongJae Park <sj@kernel.org>
To: ojeda@kernel.org
Cc: alex.gaynor@gmail.com, wedsonaf@google.com,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
rust-for-linux@vger.kernel.org, SeongJae Park <sj@kernel.org>
Subject: [PATCH] init/Kconfig: Specify the interpreter for rust-version.sh
Date: Thu, 6 Jan 2022 12:33:57 +0000 [thread overview]
Message-ID: <20220106123357.16220-1-sj@kernel.org> (raw)
Some common tools like 'diff' don't support permissions of the files.
Due to that, 'rust-version.sh' in some trees including '-mm' result in
having no execution permission, and therefore build fails like below:
$ make O=../linux.out/ olddefconfig
make[1]: Entering directory 'linux.out'
GEN Makefile
sh: 1: linux/scripts/rust-version.sh: Permission denied
init/Kconfig:71: syntax error
init/Kconfig:70: invalid statement
linux/scripts/kconfig/Makefile:77: recipe for target 'olddefconfig' failed
make[2]: *** [olddefconfig] Error 1
linux/Makefile:666: recipe for target 'olddefconfig' failed
make[1]: *** [olddefconfig] Error 2
make[1]: Leaving directory 'linux.out'
Makefile:226: recipe for target '__sub-make' failed
make: *** [__sub-make] Error 2
It's not a big deal, but not so fun. This commit fixes the issue by
specifying the interpreter for 'rust-version.sh' in the Kconfig file.
Signed-off-by: SeongJae Park <sj@kernel.org>
---
init/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/init/Kconfig b/init/Kconfig
index cd23faa163d1..97ab35692d46 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -67,7 +67,7 @@ config HAS_RUST
config RUSTC_VERSION
depends on HAS_RUST
int
- default $(shell,$(srctree)/scripts/rust-version.sh $(RUSTC))
+ default $(shell,/bin/sh $(srctree)/scripts/rust-version.sh $(RUSTC))
config CC_CAN_LINK
bool
--
2.17.1
next reply other threads:[~2022-01-06 12:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-06 12:33 SeongJae Park [this message]
2022-01-06 12:59 ` [PATCH] init/Kconfig: Specify the interpreter for rust-version.sh Wei Liu
2022-01-09 20:38 ` Miguel Ojeda
2022-01-10 8:41 ` SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220106123357.16220-1-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=alex.gaynor@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=wedsonaf@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.