From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============2705349621852108612==" MIME-Version: 1.0 From: kernel test robot To: kbuild-all@lists.01.org Subject: Re: [RFC 15/16] sched/fair: Account kthread runtime debt for CFS bandwidth Date: Thu, 06 Jan 2022 14:47:14 +0800 Message-ID: <202201061450.OId0pr1K-lkp@intel.com> In-Reply-To: <20220106004656.126790-16-daniel.m.jordan@oracle.com> List-Id: --===============2705349621852108612== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi Daniel, [FYI, it's a private test report for your RFC patch.] [auto build test WARNING on 7d2a07b769330c34b4deabeed939325c77a7ec2f] url: https://github.com/0day-ci/linux/commits/Daniel-Jordan/padata-vfio-= sched-Multithreaded-VFIO-page-pinning/20220106-084934 base: 7d2a07b769330c34b4deabeed939325c77a7ec2f config: arc-allyesconfig (https://download.01.org/0day-ci/archive/20220106/= 202201061450.OId0pr1K-lkp(a)intel.com/config) compiler: arceb-elf-gcc (GCC) 11.2.0 reproduce (this is a W=3D1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/= make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/4c1eb3c284a7aac84110e3197= 00d89e847dd0874 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Daniel-Jordan/padata-vfio-sched-Mu= ltithreaded-VFIO-page-pinning/20220106-084934 git checkout 4c1eb3c284a7aac84110e319700d89e847dd0874 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dgcc-11.2.0 make.cross= O=3Dbuild_dir ARCH=3Darc SHELL=3D/bin/bash kernel/sched/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): kernel/sched/core.c:3216:6: warning: no previous prototype for 'sched_se= t_stop_task' [-Wmissing-prototypes] 3216 | void sched_set_stop_task(int cpu, struct task_struct *stop) | ^~~~~~~~~~~~~~~~~~~ kernel/sched/core.c:10026:5: warning: no previous prototype for 'max_cfs= _bandwidth_cpus' [-Wmissing-prototypes] 10026 | int max_cfs_bandwidth_cpus(struct cgroup_subsys_state *css) | ^~~~~~~~~~~~~~~~~~~~~~ >> kernel/sched/core.c:10199:6: warning: no previous prototype for 'cpu_cgr= oup_remote_begin' [-Wmissing-prototypes] 10199 | void cpu_cgroup_remote_begin(struct task_struct *p, | ^~~~~~~~~~~~~~~~~~~~~~~ >> kernel/sched/core.c:10216:6: warning: no previous prototype for 'cpu_cgr= oup_remote_charge' [-Wmissing-prototypes] 10216 | void cpu_cgroup_remote_charge(struct task_struct *p, | ^~~~~~~~~~~~~~~~~~~~~~~~ In file included from include/linux/perf_event.h:25, from include/linux/trace_events.h:10, from include/trace/trace_events.h:21, from include/trace/define_trace.h:102, from include/trace/events/sched.h:738, from kernel/sched/core.c:10: arch/arc/include/asm/perf_event.h:126:27: warning: 'arc_pmu_cache_map' d= efined but not used [-Wunused-const-variable=3D] 126 | static const unsigned int arc_pmu_cache_map[C(MAX)][C(OP_MAX)][C= (RESULT_MAX)] =3D { | ^~~~~~~~~~~~~~~~~ arch/arc/include/asm/perf_event.h:91:27: warning: 'arc_pmu_ev_hw_map' de= fined but not used [-Wunused-const-variable=3D] 91 | static const char * const arc_pmu_ev_hw_map[] =3D { | ^~~~~~~~~~~~~~~~~ vim +/cpu_cgroup_remote_begin +10199 kernel/sched/core.c 10185 = 10186 /** 10187 * cpu_cgroup_remote_begin - begin charging p's CPU usage to a remot= e css 10188 * @p: the kernel thread whose CPU usage should be accounted 10189 * @css: the css to which the CPU usage should be accounted 10190 * 10191 * Begin charging a kernel thread's CPU usage to a remote (non-root)= task group 10192 * to account CPU time that the kernel thread spends working on beha= lf of the 10193 * group. Pair with at least one subsequent call to cpu_cgroup_remo= te_charge() 10194 * to complete the charge. 10195 * 10196 * Supports CFS bandwidth and cgroup2 CPU accounting stats but not w= eight-based 10197 * control for now. 10198 */ 10199 void cpu_cgroup_remote_begin(struct task_struct *p, 10200 struct cgroup_subsys_state *css) 10201 { 10202 if (p->sched_class =3D=3D &fair_sched_class) 10203 cpu_cgroup_remote_begin_fair(p, css_tg(css)); 10204 } 10205 = 10206 /** 10207 * cpu_cgroup_remote_charge - account p's CPU usage to a remote css 10208 * @p: the kernel thread whose CPU usage should be accounted 10209 * @css: the css to which the CPU usage should be accounted 10210 * 10211 * Account a kernel thread's CPU usage to a remote (non-root) task g= roup. Pair 10212 * with a previous call to cpu_cgroup_remote_begin() with the same @= p and @css. 10213 * This may be invoked multiple times after the initial 10214 * cpu_cgroup_remote_begin() to account additional CPU usage. 10215 */ 10216 void cpu_cgroup_remote_charge(struct task_struct *p, 10217 struct cgroup_subsys_state *css) 10218 { 10219 if (p->sched_class =3D=3D &fair_sched_class) 10220 cpu_cgroup_remote_charge_fair(p, css_tg(css)); 10221 } 10222 = --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org --===============2705349621852108612==--