All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <quwenruo.btrfs@gmx.com>
Cc: Sahil Kang <sahil.kang@asilaycomputing.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 1/1] btrfs: reuse existing pointers from btrfs_ioctl
Date: Thu, 6 Jan 2022 16:03:34 +0100	[thread overview]
Message-ID: <20220106150334.GD14046@twin.jikos.cz> (raw)
In-Reply-To: <486dd0a1-60a5-1554-26fb-69e1789a5dd4@gmx.com>

On Wed, Jan 05, 2022 at 05:53:20PM +0800, Qu Wenruo wrote:
> One suspicious ioctls, they should require write permission, but don't:
> 
> - btrfs_ioctl_start_sync()
>    If there is no running trans, it would bail out without doing
>    anything, but I'm wondering if we should call mnt_want_write_file().
> 
>    As this means, if we mount a subvolume read-only, but the fs still has
>    some part mounted RW, we can start a sync using the read-only mounted
>    part.

We can possibly do the mnt_want_write but it should not propagate the
errors, because calling sync on a fully read-only filesystem should not
error out.

  reply	other threads:[~2022-01-06 15:04 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-05  8:30 [PATCH 0/1] btrfs: reuse existing pointers from btrfs_ioctl Sahil Kang
2022-01-05  8:30 ` [PATCH 1/1] " Sahil Kang
2022-01-05  9:53   ` Qu Wenruo
2022-01-06 15:03     ` David Sterba [this message]
2022-01-16  2:48       ` [PATCH 0/1] btrfs: reuse existing inode " Sahil Kang
2022-01-16  2:48         ` [PATCH 1/1] " Sahil Kang
2022-01-17 13:39           ` David Sterba
2022-01-06 15:27   ` [PATCH 1/1] btrfs: reuse existing pointers " David Sterba
2022-01-05  9:30 ` [PATCH 0/1] " Qu Wenruo
2022-01-06 15:11   ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220106150334.GD14046@twin.jikos.cz \
    --to=dsterba@suse.cz \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=quwenruo.btrfs@gmx.com \
    --cc=sahil.kang@asilaycomputing.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.