From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============0088342926927060483==" MIME-Version: 1.0 From: kernel test robot To: kbuild-all@lists.01.org Subject: Re: [PATCH] Add serial device bus support to penmount serial driver. Date: Thu, 06 Jan 2022 22:24:54 +0800 Message-ID: <202201062256.vFHz1d0U-lkp@intel.com> In-Reply-To: <1641463060-6602-1-git-send-email-penmount.touch@gmail.com> List-Id: --===============0088342926927060483== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi John, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on dtor-input/next] [also build test WARNING on hid/for-next linux/master linus/master v5.16-rc= 8 next-20220105] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/John-Sung/Add-serial-devic= e-bus-support-to-penmount-serial-driver/20220106-175910 base: https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git next config: ia64-allyesconfig (https://download.01.org/0day-ci/archive/20220106= /202201062256.vFHz1d0U-lkp(a)intel.com/config) compiler: ia64-linux-gcc (GCC) 11.2.0 reproduce (this is a W=3D1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/= make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/053957cedaa900325f4562071= 7607b464f532b54 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review John-Sung/Add-serial-device-bus-su= pport-to-penmount-serial-driver/20220106-175910 git checkout 053957cedaa900325f45620717607b464f532b54 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dgcc-11.2.0 make.cross= O=3Dbuild_dir ARCH=3Dia64 SHELL=3D/bin/bash drivers/input/touchscreen/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): drivers/input/touchscreen/penmount.c: In function 'pm_driver_init': >> drivers/input/touchscreen/penmount.c:257:13: warning: variable 'err' set= but not used [-Wunused-but-set-variable] 257 | int err; | ^~~ vim +/err +257 drivers/input/touchscreen/penmount.c ee4799997950e8 Rick Koch 2006-08-05 246 = ee4799997950e8 Rick Koch 2006-08-05 247 /* ee4799997950e8 Rick Koch 2006-08-05 248 * pm_connect() is the routine t= hat is called when someone adds a 21ae508bab28c2 John Sung 2011-09-09 249 * new serio device that support= s PenMount protocol and registers it as ee4799997950e8 Rick Koch 2006-08-05 250 * an input device. ee4799997950e8 Rick Koch 2006-08-05 251 */ 053957cedaa900 John Sung 2022-01-06 252 static struct pm * pm_driver_ini= t(struct device * dev, const struct pm_device_conf * conf, char *phys) ee4799997950e8 Rick Koch 2006-08-05 253 { 053957cedaa900 John Sung 2022-01-06 254 struct pm *pm =3D NULL; ee4799997950e8 Rick Koch 2006-08-05 255 struct input_dev *input_dev; 90aba7d8b155c2 John Sung 2011-09-09 256 int max_x, max_y; ee4799997950e8 Rick Koch 2006-08-05 @257 int err; ee4799997950e8 Rick Koch 2006-08-05 258 = ee4799997950e8 Rick Koch 2006-08-05 259 pm =3D kzalloc(sizeof(struct pm= ), GFP_KERNEL); ee4799997950e8 Rick Koch 2006-08-05 260 input_dev =3D input_allocate_de= vice(); ee4799997950e8 Rick Koch 2006-08-05 261 if (!pm || !input_dev) { ee4799997950e8 Rick Koch 2006-08-05 262 err =3D -ENOMEM; ee4799997950e8 Rick Koch 2006-08-05 263 goto fail1; ee4799997950e8 Rick Koch 2006-08-05 264 } ee4799997950e8 Rick Koch 2006-08-05 265 = ee4799997950e8 Rick Koch 2006-08-05 266 pm->dev =3D input_dev; = ee4799997950e8 Rick Koch 2006-08-05 267 = 21ae508bab28c2 John Sung 2011-09-09 268 input_dev->name =3D "PenMount S= erial TouchScreen"; 053957cedaa900 John Sung 2022-01-06 269 input_dev->phys =3D phys; ee4799997950e8 Rick Koch 2006-08-05 270 input_dev->id.bustype =3D BUS_R= S232; ee4799997950e8 Rick Koch 2006-08-05 271 input_dev->id.vendor =3D SERIO_= PENMOUNT; ee4799997950e8 Rick Koch 2006-08-05 272 input_dev->id.product =3D 0; ee4799997950e8 Rick Koch 2006-08-05 273 input_dev->id.version =3D 0x010= 0; 053957cedaa900 John Sung 2022-01-06 274 input_dev->dev.parent =3D dev; ee4799997950e8 Rick Koch 2006-08-05 275 = 7b19ada2ed3c1e Jiri Slaby 2007-10-18 276 input_dev->evbit[0] =3D BIT_MAS= K(EV_KEY) | BIT_MASK(EV_ABS); 7b19ada2ed3c1e Jiri Slaby 2007-10-18 277 input_dev->keybit[BIT_WORD(BTN_= TOUCH)] =3D BIT_MASK(BTN_TOUCH); c42e2e406ad49f John Sung 2011-09-09 278 = 053957cedaa900 John Sung 2022-01-06 279 pm->conf =3D conf; 053957cedaa900 John Sung 2022-01-06 280 input_dev->id.product =3D conf-= >productid; 053957cedaa900 John Sung 2022-01-06 281 max_x =3D max_y =3D conf->max; 90aba7d8b155c2 John Sung 2011-09-09 282 = 90aba7d8b155c2 John Sung 2011-09-09 283 input_set_abs_params(pm->dev, A= BS_X, 0, max_x, 0, 0); 90aba7d8b155c2 John Sung 2011-09-09 284 input_set_abs_params(pm->dev, A= BS_Y, 0, max_y, 0, 0); 90aba7d8b155c2 John Sung 2011-09-09 285 = 053957cedaa900 John Sung 2022-01-06 286 if (pm->conf->maxcontacts > 1) { 053957cedaa900 John Sung 2022-01-06 287 input_mt_init_slots(pm->dev, p= m->conf->maxcontacts, 0); 90aba7d8b155c2 John Sung 2011-09-09 288 input_set_abs_params(pm->dev, 90aba7d8b155c2 John Sung 2011-09-09 289 ABS_MT_POSITION_X, 0, m= ax_x, 0, 0); 90aba7d8b155c2 John Sung 2011-09-09 290 input_set_abs_params(pm->dev, 90aba7d8b155c2 John Sung 2011-09-09 291 ABS_MT_POSITION_Y, 0, m= ax_y, 0, 0); 90aba7d8b155c2 John Sung 2011-09-09 292 } 053957cedaa900 John Sung 2022-01-06 293 return pm; 053957cedaa900 John Sung 2022-01-06 294 = 053957cedaa900 John Sung 2022-01-06 295 fail1: = 053957cedaa900 John Sung 2022-01-06 296 if (input_dev) input_free_devic= e(input_dev); 053957cedaa900 John Sung 2022-01-06 297 if (pm) kfree(pm); 053957cedaa900 John Sung 2022-01-06 298 return NULL; 053957cedaa900 John Sung 2022-01-06 299 } 053957cedaa900 John Sung 2022-01-06 300 = --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org --===============0088342926927060483==--