From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2417C433EF for ; Fri, 7 Jan 2022 01:46:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344384AbiAGBqz (ORCPT ); Thu, 6 Jan 2022 20:46:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42626 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344368AbiAGBqy (ORCPT ); Thu, 6 Jan 2022 20:46:54 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80180C061245; Thu, 6 Jan 2022 17:46:54 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A6C5F61EA5; Fri, 7 Jan 2022 01:46:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E7FB7C36AE0; Fri, 7 Jan 2022 01:46:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1641520013; bh=9Kg5n4ZOUJTxXcMjPnNz9VtaD4O7j1UtUbFnhINlySU=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=tx/K4xmqIjfZ3ybLw+8BpMjCt7U5jESX2rHUxQUkarENciQQIsHcbVhjkWPHFz2Yk wlgWWP7sBSDlAtlqEcXKvs5HcyIUKsdGbE0G0QhSfEF0PLkL2UL5+vXMsXke1DmW4E ofMB/B5ZTxgrUvjkcMy6Ni4BZwWwfBeUwiRCf7LC1pQT/OM4TpBnvCFAmDi9/RnLby Z72ycqtIvIXwTIqz4zYkZzNAK9B55LisSeQBJOw4ZM7HHejrxPFivXRHD1GogoTqkO mhUgedK+FZmGKeax+hxXTCAPeAUvxrEEg9sSiqkE2SEeAVrY0fFVqTL8/+qa4Sb/tK dGLfGWICYuXmw== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20211223154244.1024062-1-conor.dooley@microchip.com> References: <20211223154244.1024062-1-conor.dooley@microchip.com> Subject: Re: [PATCH] clk: bm1880: remove kfrees on static allocations From: Stephen Boyd Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, daire.mcnamara@microchip.com, mail@conchuod.ie, Conor Dooley To: Mmturquette@baylibre.com, conor.dooley@microchip.com, linux-clk@vger.kernel.org, mani@kernel.org Date: Thu, 06 Jan 2022 17:46:51 -0800 User-Agent: alot/0.9.1 Message-Id: <20220107014652.E7FB7C36AE0@smtp.kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Quoting conor.dooley@microchip.com (2021-12-23 07:42:44) > From: Conor Dooley >=20 > bm1880_clk_unregister_pll & bm1880_clk_unregister_div both try to > free statically allocated variables, so remove those kfrees. >=20 > For example, if we take L703 kfree(div_hw): > - div_hw is a bm1880_div_hw_clock pointer > - in bm1880_clk_register_plls this is pointed to an element of arg1: > struct bm1880_div_hw_clock *clks > - in the probe, where bm1880_clk_register_plls is called arg1 is > bm1880_div_clks, defined on L371: > static struct bm1880_div_hw_clock bm1880_div_clks[] >=20 > Signed-off-by: Conor Dooley > --- Applied to clk-next From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D3119C433EF for ; Fri, 7 Jan 2022 01:48:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:To:Cc:From:Subject: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tnLknm4tkWokBUsMvTEpa1q6CbodnkLXxKRKejelFoM=; b=s3Zsp4qdF5Y0It 7u+O+FkIMOFGiY2HncZqEeS9OxiNn2nEe5N2mOUP0zcsQuxaI19xx2bhiMlSJHSJFO/Jxn4dZsfrH Vq1Lyaz63EuYb0ajhp7W2g3kcCan4pUdN7eaEeSsp5jF37K5o5y0afyFZeoCJ/GoHWVgxBKfLu7GK w04GyuPA3c9r7c5ie21DpgNZVpXRuUJpvAKp8biO6ieoloA9JXOniaVx7Hx48omZ8vSZnISGO2vP9 ugRS3A6JHffECXd5Xzk62+rorI2GX0qQSXdbJGFp2q2bKs2kLD+Ksmoe9zIR6Xz21KWJPIHKBI3dR 8eM1CcbaHcoYxQzfX8HA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n5eLL-001p4B-8Y; Fri, 07 Jan 2022 01:46:59 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n5eLH-001p3N-QO for linux-arm-kernel@lists.infradead.org; Fri, 07 Jan 2022 01:46:57 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 584BDB82350; Fri, 7 Jan 2022 01:46:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E7FB7C36AE0; Fri, 7 Jan 2022 01:46:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1641520013; bh=9Kg5n4ZOUJTxXcMjPnNz9VtaD4O7j1UtUbFnhINlySU=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=tx/K4xmqIjfZ3ybLw+8BpMjCt7U5jESX2rHUxQUkarENciQQIsHcbVhjkWPHFz2Yk wlgWWP7sBSDlAtlqEcXKvs5HcyIUKsdGbE0G0QhSfEF0PLkL2UL5+vXMsXke1DmW4E ofMB/B5ZTxgrUvjkcMy6Ni4BZwWwfBeUwiRCf7LC1pQT/OM4TpBnvCFAmDi9/RnLby Z72ycqtIvIXwTIqz4zYkZzNAK9B55LisSeQBJOw4ZM7HHejrxPFivXRHD1GogoTqkO mhUgedK+FZmGKeax+hxXTCAPeAUvxrEEg9sSiqkE2SEeAVrY0fFVqTL8/+qa4Sb/tK dGLfGWICYuXmw== MIME-Version: 1.0 In-Reply-To: <20211223154244.1024062-1-conor.dooley@microchip.com> References: <20211223154244.1024062-1-conor.dooley@microchip.com> Subject: Re: [PATCH] clk: bm1880: remove kfrees on static allocations From: Stephen Boyd Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, daire.mcnamara@microchip.com, mail@conchuod.ie, Conor Dooley To: Mmturquette@baylibre.com, conor.dooley@microchip.com, linux-clk@vger.kernel.org, mani@kernel.org Date: Thu, 06 Jan 2022 17:46:51 -0800 User-Agent: alot/0.9.1 Message-Id: <20220107014652.E7FB7C36AE0@smtp.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220106_174656_015799_75653E1F X-CRM114-Status: UNSURE ( 9.86 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting conor.dooley@microchip.com (2021-12-23 07:42:44) > From: Conor Dooley > > bm1880_clk_unregister_pll & bm1880_clk_unregister_div both try to > free statically allocated variables, so remove those kfrees. > > For example, if we take L703 kfree(div_hw): > - div_hw is a bm1880_div_hw_clock pointer > - in bm1880_clk_register_plls this is pointed to an element of arg1: > struct bm1880_div_hw_clock *clks > - in the probe, where bm1880_clk_register_plls is called arg1 is > bm1880_div_clks, defined on L371: > static struct bm1880_div_hw_clock bm1880_div_clks[] > > Signed-off-by: Conor Dooley > --- Applied to clk-next _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel