From: Dan Carpenter <dan.carpenter@oracle.com>
To: Abdun Nihaal <abdun.nihaal@gmail.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
Larry.Finger@lwfinger.net, phil@philpotter.co.uk,
straube.linux@gmail.com, martin@kaiser.cx,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] staging: r8188eu: change functions to return void
Date: Fri, 7 Jan 2022 11:58:52 +0300 [thread overview]
Message-ID: <20220107085852.GQ7674@kadam> (raw)
In-Reply-To: <20220107065210.7utcwjenvcspydyk@nlap2>
On Fri, Jan 07, 2022 at 12:22:10PM +0530, Abdun Nihaal wrote:
> Hello Greg,
>
> On Thu, Jan 06, 2022 at 06:58:50PM +0100, Greg KH wrote:
> > On Thu, Jan 06, 2022 at 11:11:52PM +0530, Abdun Nihaal wrote:
> > > Some functions in ioctl_linux.c always returns 0 and their return values
> > > are never used. Change return type of such functions to void.
> > >
> > > While at it, align function arguments with open parenthesis to fix
> > > checkpatch checks.
> > >
> > > Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > Signed-off-by: Abdun Nihaal <abdun.nihaal@gmail.com>
> >
> > Are you sure that checkpatch allowed this change?
>
> Yes, I ran checkpatch on both the patches and found no errors, warnings
> or checks. Is there something that needs to be fixed?
You're not allowed to end a void function with a return statement.
Checkpatch will only detect these if you run it again with the -f
option.
regards,
dan carpenter
next prev parent reply other threads:[~2022-01-07 8:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-06 17:41 [PATCH v2 0/2] staging: r8188eu: remove unneeded ret variables Abdun Nihaal
2022-01-06 17:41 ` [PATCH v2 1/2] " Abdun Nihaal
2022-01-06 17:41 ` [PATCH v2 2/2] staging: r8188eu: change functions to return void Abdun Nihaal
2022-01-06 17:58 ` Greg KH
2022-01-07 6:52 ` Abdun Nihaal
2022-01-07 8:58 ` Dan Carpenter [this message]
2022-01-07 9:55 ` Abdun Nihaal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220107085852.GQ7674@kadam \
--to=dan.carpenter@oracle.com \
--cc=Larry.Finger@lwfinger.net \
--cc=abdun.nihaal@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=martin@kaiser.cx \
--cc=phil@philpotter.co.uk \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.