From: Jason Gunthorpe <jgg@nvidia.com>
To: Bob Pearson <rpearsonhpe@gmail.com>
Cc: zyjzyj2000@gmail.com, linux-rdma@vger.kernel.org
Subject: Re: [PATCH for-next v8 3/8] RDMA/rxe: Cleanup pool APIs for keyed objects
Date: Fri, 7 Jan 2022 09:25:49 -0400 [thread overview]
Message-ID: <20220107132549.GA3068392@nvidia.com> (raw)
In-Reply-To: <20211216233201.14893-4-rpearsonhpe@gmail.com>
On Thu, Dec 16, 2021 at 05:31:57PM -0600, Bob Pearson wrote:
> +/**
> + * rxe_elem_release() - cleanup pool element when last reference dropped
> + * @kref: address of the kref contained in pool element
> + *
> + * Caller should hold pool lock
> + */
> +void rxe_elem_release(struct kref *kref)
> +{
> + struct rxe_pool_elem *elem =
> + container_of(kref, struct rxe_pool_elem, ref_cnt);
> + struct rxe_pool *pool = elem->pool;
> +
> + if (pool->flags & RXE_POOL_INDEX)
> + xa_erase(&pool->xarray.xa, elem->index);
> + else if (pool->flags & RXE_POOL_KEY)
> + rb_erase(&elem->key_node, &pool->key.tree);
This doesn't hold a lock anymore before calling rb_erase()
Jason
next prev parent reply other threads:[~2022-01-07 13:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-16 23:31 [PATCH for-next v8 0/8] RDMA/rxe: Correct race conditions Bob Pearson
2021-12-16 23:31 ` [PATCH for-next v8 1/8] RDMA/rxe: Replace RB tree by xarray for indexes Bob Pearson
2022-01-07 13:06 ` Jason Gunthorpe
2021-12-16 23:31 ` [PATCH for-next v8 2/8] RDMA/rxe: Reverse the sense of RXE_POOL_NO_ALLOC Bob Pearson
2021-12-16 23:31 ` [PATCH for-next v8 3/8] RDMA/rxe: Cleanup pool APIs for keyed objects Bob Pearson
2022-01-07 13:25 ` Jason Gunthorpe [this message]
2021-12-16 23:31 ` [PATCH for-next v8 4/8] RDMA/rxe: Fix ref error in rxe_av.c Bob Pearson
2021-12-16 23:31 ` [PATCH for-next v8 5/8] RDMA/rxe: Replace mr by rkey in responder resources Bob Pearson
2021-12-16 23:32 ` [PATCH for-next v8 6/8] RDMA/rxe: Minor cleanups in rxe_pool.c/rxe_pool.h Bob Pearson
2021-12-16 23:32 ` [PATCH for-next v8 7/8] RDMA/rxe: Replace rxe_alloc by kzalloc for rxe_mc_elem Bob Pearson
2021-12-16 23:32 ` [PATCH for-next v8 8/8] RDMA/rxe: Add wait for completion to obj destruct Bob Pearson
2022-01-07 12:53 ` Jason Gunthorpe
2022-01-07 13:12 ` [PATCH for-next v8 0/8] RDMA/rxe: Correct race conditions Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220107132549.GA3068392@nvidia.com \
--to=jgg@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
--cc=rpearsonhpe@gmail.com \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.