From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 704FFC433F5 for ; Fri, 7 Jan 2022 15:13:02 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B152D83720; Fri, 7 Jan 2022 16:12:59 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="fUE9xTlI"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id F06AE83728; Fri, 7 Jan 2022 16:12:57 +0100 (CET) Received: from mail-qt1-x835.google.com (mail-qt1-x835.google.com [IPv6:2607:f8b0:4864:20::835]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A749B836C5 for ; Fri, 7 Jan 2022 16:12:54 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x835.google.com with SMTP id v7so2476784qtw.13 for ; Fri, 07 Jan 2022 07:12:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=YiYvs8Sd3oIoXIo208nnKEbLmT780JPkeDqqZUB2jEM=; b=fUE9xTlIGN3nrS8RKJnvO6zt3JHGS9yNtb62nzwPgo0hq4RaeXhmTxuNPXN2myYx1i JcAXXB32jIBcK3QlfHTVU1iS0ksQJvfbZ356e/51obRrl2oZio9AkLm48OL2E/fEc6OP 9MEsXfJFe1s4wclobmaB2bbMbQ8/T9HMzHXm4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=YiYvs8Sd3oIoXIo208nnKEbLmT780JPkeDqqZUB2jEM=; b=KtNJofl6TiEAeowwYUxV3jj6mLM65gQ15lSbFHKmDgnKqyTsVXRl9Fp9YA4nXROERN ApCTBYoEsKaJiC8uvL4ENoaoZyNNtG7d0/Q4A0uGTxqyRJqZ9y/W0YCGpjqJ3/wQnX2o XJHkEOqQzm0ht/D2dMkO09RdE9HrGB3PIfNYoKWDI0zJ84lkUfNUpeJEYJksfD4rbaX7 xPHQhXUNm/aqjWdKwvS7cXTV7hPNs96fXP8nRTiljvUfh0VuJuay8j7QFNpimj197cyd gZkPCBzu4Awepc2SwBpkgjQ86mpyEpoGlUF7M5jnNeaaWc9hX63jVDIeyXe71Jf50QJg 7lKg== X-Gm-Message-State: AOAM533jeAwgS6vdvJTvsrNHcjItUwxB6awGoxOvUgEfzwinf1D2eMUi kuRk5ulpW4tqlKMw3zer8K8xew== X-Google-Smtp-Source: ABdhPJzVMCimeYZ1DQRGC0VqELCeuBn3L0d2PYEre/9yfb7D0YWe8x1teQaz74YPoKWM2omUZCwGbg== X-Received: by 2002:a05:622a:1790:: with SMTP id s16mr56053331qtk.591.1641568372819; Fri, 07 Jan 2022 07:12:52 -0800 (PST) Received: from bill-the-cat (2603-6081-7b01-cbda-f174-9b83-85b8-612f.res6.spectrum.com. [2603:6081:7b01:cbda:f174:9b83:85b8:612f]) by smtp.gmail.com with ESMTPSA id a3sm82884qtx.66.2022.01.07.07.12.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Jan 2022 07:12:52 -0800 (PST) Date: Fri, 7 Jan 2022 10:12:50 -0500 From: Tom Rini To: Troy Kisky Cc: Simon Glass , U-Boot Mailing List Subject: Re: [PATCH v1 0/5] Move board specific files to board directory Message-ID: <20220107151250.GK2773246@bill-the-cat> References: <20211217230131.2715940-1-troy.kisky@boundarydevices.com> <20211228131115.GZ2773246@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="14l74oP8pwp5L87R" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.38 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --14l74oP8pwp5L87R Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jan 06, 2022 at 01:14:40PM -0800, Troy Kisky wrote: > On 12/28/2021 5:11 AM, Tom Rini wrote: > > On Tue, Dec 28, 2021 at 01:33:05AM -0700, Simon Glass wrote: > >> Hi Troy, > >> > >> On Fri, 17 Dec 2021 at 16:02, Troy Kisky wrote: > >>> > >>> This series intends to let board specific files live in the boards > >>> directory. The last patch moves files for nitrogen6x. > >>> I have tested it with buildman > >>> > >>> ./tools/buildman/buildman boundary -b denx_master > >>> > >>> But it is likely the more scripts then just tools/genboardscfg.py wou= ld > >>> need to be updated. > >>> > >>> Troy Kisky (5): > >>> kconfig: allow defconfigs to live in board directory > >>> dts: allow dts files in board directory > >>> scripts: Makefile.autoconf: allow CONFIG_SYS_CONFIG_NAME file to li= ve > >>> in board directory > >>> genboardcfg: allow defconfigs in board directory > >>> nitrogen6x: move board specific files to nitrogen6x directory > >>> > >>> arch/arm/dts/Makefile | 3 -- > >>> board/boundary/nitrogen6x/MAINTAINERS | 13 ------- > >>> board/boundary/nitrogen6x/Makefile | 13 +++++++ > >>> .../nitrogen6x}/imx6dl-nitrogen6x.dts | 0 > >>> .../boundary/nitrogen6x}/imx6q-nitrogen6x.dts | 0 > >>> .../boundary/nitrogen6x}/imx6q-sabrelite.dts | 0 > >>> .../nitrogen6x}/imx6qdl-nitrogen6x.dtsi | 0 > >>> .../nitrogen6x}/imx6qdl-sabrelite.dtsi | 0 > >>> .../nitrogen6x}/mx6qsabrelite_defconfig | 0 > >>> .../nitrogen6x}/nitrogen6dl2g_defconfig | 0 > >>> .../nitrogen6x}/nitrogen6dl_defconfig | 0 > >>> .../nitrogen6x}/nitrogen6q2g_defconfig | 0 > >>> .../boundary/nitrogen6x}/nitrogen6q_defconfig | 0 > >>> .../nitrogen6x}/nitrogen6s1g_defconfig | 0 > >>> .../boundary/nitrogen6x}/nitrogen6s_defconfig | 0 > >>> .../boundary/nitrogen6x}/nitrogen6x.h | 2 +- > >>> dts/Makefile | 11 +++++- > >>> scripts/Makefile.autoconf | 9 ++++- > >>> scripts/Makefile.lib | 1 + > >>> scripts/kconfig/Makefile | 9 ++++- > >>> tools/genboardscfg.py | 37 +++++++++++++++++= +- > >>> 21 files changed, 75 insertions(+), 23 deletions(-) > >>> rename {arch/arm/dts =3D> board/boundary/nitrogen6x}/imx6dl-nitrogen= 6x.dts (100%) > >>> rename {arch/arm/dts =3D> board/boundary/nitrogen6x}/imx6q-nitrogen6= x.dts (100%) > >>> rename {arch/arm/dts =3D> board/boundary/nitrogen6x}/imx6q-sabrelite= =2Edts (100%) > >>> rename {arch/arm/dts =3D> board/boundary/nitrogen6x}/imx6qdl-nitroge= n6x.dtsi (100%) > >>> rename {arch/arm/dts =3D> board/boundary/nitrogen6x}/imx6qdl-sabreli= te.dtsi (100%) > >>> rename {configs =3D> board/boundary/nitrogen6x}/mx6qsabrelite_defcon= fig (100%) > >>> rename {configs =3D> board/boundary/nitrogen6x}/nitrogen6dl2g_defcon= fig (100%) > >>> rename {configs =3D> board/boundary/nitrogen6x}/nitrogen6dl_defconfi= g (100%) > >>> rename {configs =3D> board/boundary/nitrogen6x}/nitrogen6q2g_defconf= ig (100%) > >>> rename {configs =3D> board/boundary/nitrogen6x}/nitrogen6q_defconfig= (100%) > >>> rename {configs =3D> board/boundary/nitrogen6x}/nitrogen6s1g_defconf= ig (100%) > >>> rename {configs =3D> board/boundary/nitrogen6x}/nitrogen6s_defconfig= (100%) > >>> rename {include/configs =3D> board/boundary/nitrogen6x}/nitrogen6x.h= (98%) I'm not about the goal. > >> > >> Can you please add a few notes about the motivation for this change? > >=20 > > Sorry for the delayed reply here. I'm also not entirely sure this is a > > good idea. Moving the defconfig files? Maybe. It does make checking > > all configs a bit more tricky, but indeed the configs directory is > > unwieldy. Moving the dts files? Those should be a direct cp from the > > kernel, so that makes things less clear to me. Especially since it will > > need other common files that will still be elsewhere. > >=20 >=20 > They will still be a direct copy. Notice the 100% rename. Common files st= ill living in the dts > directory is less clear. I can try to address the "piecemeal building of = =2Edts files" if this > still has a chance of being accepted. So, here's my worry. Today, in an ideal world that we're not yet at, I could do: 1. cd ~/src/linux; git checkout v5.16 2. cd ~/src/u-boot; for DTS in arch/arm/dts/*.dts*; do \ [ -f ~/src/linux/$DTS ] && cp ~/src/linux/$DTS $DTS; done And now we're resynced with v5.16. That gets a lot more complex with board/*/*/*.dts* too. And since those files should be direct imports I'm not sure how them residing in board/ helps. But! I can see how having board-u-boot.dtsi exist under board/ might help. Or at least, having those files reside somewhere that's NOT where the unmodified imported dts files also live. Long term I think we need to move towards making it easier to import the dts files, and clearer that they should be "read only" other than when being resynced, than it is today. --=20 Tom --14l74oP8pwp5L87R Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmHYWG8ACgkQFHw5/5Y0 tywNrwwAjggg2nZv0BswsVWtc330wL06W+iCZiyNF9Vkrsfb77Ghz0MZH0otHtPK DG5ajcIr2LpYtP3LgzCdOccDBLcg6TuMU/glAj6NCrc54yLW2M8CwxEdHNuyjMBc ahjKCJ60p1te+WbcdOMk6VXwWUlKuUWOCNmToXfwGu3nGMoF4t1SZ9WB/b9yHlaX zcv8dCfviZ10jkn2dQRXg3FTLiy+HrFhKt1GwWx261O7QjhpMSwmJgrDlP6fqGj1 RE7HbsZCpyb4m+g1J7TeVEzAli6r2YvpNWrVGzoZR2BqME+oqKyKhS8Nm2cTOOoG KpfO2QcsqLv96e/sdtIG879M4+5a5XG6GCOXOTETm3GILXMNdCQ7pyvK0G9uYP0T LiPPrMoQejSYWjxgs6iSGxga/RrGFYczFfxEbf4JpgqYX/T2pwBv8eN9zZWHElUh A+KiG/rJ2n0Z9rEJ79bF6f7E9vgDTyEMizeMfHBweBQHyovZHjHxo/+VwRNQUYMl OITgd/YN =Uy36 -----END PGP SIGNATURE----- --14l74oP8pwp5L87R--