From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============8148639724439188962==" MIME-Version: 1.0 From: kernel test robot To: kbuild-all@lists.01.org Subject: Re: [PATCH 16/16] PCI: Remove usage of the deprecated "pci-dma-compat.h" API Date: Fri, 07 Jan 2022 17:41:06 +0800 Message-ID: <202201071737.L7WbVLeU-lkp@intel.com> In-Reply-To: List-Id: --===============8148639724439188962== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi Christophe, Thank you for the patch! Yet something to improve: [auto build test ERROR on media-tree/master] [also build test ERROR on helgaas-pci/next soc/for-next linus/master v5.16-= rc8 next-20220106] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Christophe-JAILLET/Remove-= usage-of-the-deprecated-pci-dma-compat-h-API/20220107-055614 base: git://linuxtv.org/media_tree.git master config: arc-randconfig-r025-20220107 (https://download.01.org/0day-ci/archi= ve/20220107/202201071737.L7WbVLeU-lkp(a)intel.com/config) compiler: arceb-elf-gcc (GCC) 11.2.0 reproduce (this is a W=3D1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/= make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/24f5ae55a3ed7f1638a921db6= 6d8e2f428f2e79d git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Christophe-JAILLET/Remove-usage-of= -the-deprecated-pci-dma-compat-h-API/20220107-055614 git checkout 24f5ae55a3ed7f1638a921db66d8e2f428f2e79d # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dgcc-11.2.0 make.cross= O=3Dbuild_dir ARCH=3Darc SHELL=3D/bin/bash drivers/scsi/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All error/warnings (new ones prefixed by >>): In file included from drivers/scsi/fdomain.c:87: >> include/scsi/scsicam.h:16:31: warning: 'struct block_device' declared in= side parameter list will not be visible outside of this definition or decla= ration 16 | int scsicam_bios_param(struct block_device *bdev, sector_t capac= ity, int *ip); | ^~~~~~~~~~~~ include/scsi/scsicam.h:17:27: warning: 'struct block_device' declared in= side parameter list will not be visible outside of this definition or decla= ration 17 | bool scsi_partsize(struct block_device *bdev, sector_t capacity,= int geom[3]); | ^~~~~~~~~~~~ include/scsi/scsicam.h:18:40: warning: 'struct block_device' declared in= side parameter list will not be visible outside of this definition or decla= ration 18 | unsigned char *scsi_bios_ptable(struct block_device *bdev); | ^~~~~~~~~~~~ drivers/scsi/fdomain.c: In function 'fdomain_biosparam': >> drivers/scsi/fdomain.c:468:45: error: passing argument 1 of 'scsi_bios_p= table' from incompatible pointer type [-Werror=3Dincompatible-pointer-types] 468 | unsigned char *p =3D scsi_bios_ptable(bdev); | ^~~~ | | | struct block_device * In file included from drivers/scsi/fdomain.c:87: include/scsi/scsicam.h:18:54: note: expected 'struct block_device *' but= argument is of type 'struct block_device *' 18 | unsigned char *scsi_bios_ptable(struct block_device *bdev); | ~~~~~~~~~~~~~~~~~~~~~^~~~ cc1: some warnings being treated as errors vim +/scsi_bios_ptable +468 drivers/scsi/fdomain.c ebeb466531154d6 Ondrej Zary 2019-05-14 463 = ebeb466531154d6 Ondrej Zary 2019-05-14 464 static int fdomain_biosparam(s= truct scsi_device *sdev, ebeb466531154d6 Ondrej Zary 2019-05-14 465 struct block_device *b= dev, sector_t capacity, ebeb466531154d6 Ondrej Zary 2019-05-14 466 int geom[]) ebeb466531154d6 Ondrej Zary 2019-05-14 467 { ebeb466531154d6 Ondrej Zary 2019-05-14 @468 unsigned char *p =3D scsi_bio= s_ptable(bdev); ebeb466531154d6 Ondrej Zary 2019-05-14 469 = ebeb466531154d6 Ondrej Zary 2019-05-14 470 if (p && p[65] =3D=3D 0xaa &&= p[64] =3D=3D 0x55 /* Partition table valid */ ebeb466531154d6 Ondrej Zary 2019-05-14 471 && p[4]) { /* Partition = type */ ebeb466531154d6 Ondrej Zary 2019-05-14 472 geom[0] =3D p[5] + 1; /* hea= ds */ ebeb466531154d6 Ondrej Zary 2019-05-14 473 geom[1] =3D p[6] & 0x3f; /* = sectors */ ebeb466531154d6 Ondrej Zary 2019-05-14 474 } else { ebeb466531154d6 Ondrej Zary 2019-05-14 475 if (capacity >=3D 0x7e0000) { ebeb466531154d6 Ondrej Zary 2019-05-14 476 geom[0] =3D 255; /* heads */ ebeb466531154d6 Ondrej Zary 2019-05-14 477 geom[1] =3D 63; /* sectors = */ ebeb466531154d6 Ondrej Zary 2019-05-14 478 } else if (capacity >=3D 0x2= 00000) { ebeb466531154d6 Ondrej Zary 2019-05-14 479 geom[0] =3D 128; /* heads */ ebeb466531154d6 Ondrej Zary 2019-05-14 480 geom[1] =3D 63; /* sectors = */ ebeb466531154d6 Ondrej Zary 2019-05-14 481 } else { ebeb466531154d6 Ondrej Zary 2019-05-14 482 geom[0] =3D 64; /* heads */ ebeb466531154d6 Ondrej Zary 2019-05-14 483 geom[1] =3D 32; /* sectors = */ ebeb466531154d6 Ondrej Zary 2019-05-14 484 } ebeb466531154d6 Ondrej Zary 2019-05-14 485 } ebeb466531154d6 Ondrej Zary 2019-05-14 486 geom[2] =3D sector_div(capaci= ty, geom[0] * geom[1]); ebeb466531154d6 Ondrej Zary 2019-05-14 487 kfree(p); ebeb466531154d6 Ondrej Zary 2019-05-14 488 = ebeb466531154d6 Ondrej Zary 2019-05-14 489 return 0; ebeb466531154d6 Ondrej Zary 2019-05-14 490 } ebeb466531154d6 Ondrej Zary 2019-05-14 491 = --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org --===============8148639724439188962==--