From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: John Keeping <john@metanate.com>
Cc: Vincent Fazio <vfazio@xes-inc.com>,
"Yann E . MORIN" <yann.morin.1998@free.fr>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] download/git: fix LFS support
Date: Fri, 7 Jan 2022 19:07:46 +0100 [thread overview]
Message-ID: <20220107190746.0b714e72@windsurf> (raw)
In-Reply-To: <20220106151942.1506534-1-john@metanate.com>
On Thu, 6 Jan 2022 15:19:42 +0000
John Keeping <john@metanate.com> wrote:
> The original patch for commit cff428fe31 ("download/git: support Git
> LFS") included a call to "git lfs install" but this was a problem as it
> could modify ~/.gitconfig outside the dl/ tree. When this was
> updated it was thought that the modification to gitconfig was
> unnecessary because the LFS fetch and checkout steps are performed
> manually.
>
> Unfortunately, this is not correct and the LFS checkout fails with:
>
> Cannot checkout LFS objects, Git LFS is not installed.
>
> Add the call to "git lfs install", with the --local option so that only
> the repository's .git/config is modified and not the user's global
> ~/.gitconfig.
>
> This is also required for submodules as the parent repository's config
> is not inherited.
>
> Cc: Arnout Vandecappelle <arnout@mind.be>
> Cc: Vincent Fazio <vfazio@xes-inc.com>
> Signed-off-by: John Keeping <john@metanate.com>
> ---
> support/download/git | 2 ++
> 1 file changed, 2 insertions(+)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2022-01-07 18:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-06 15:19 [Buildroot] [PATCH] download/git: fix LFS support John Keeping
2022-01-07 18:07 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220107190746.0b714e72@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@buildroot.org \
--cc=john@metanate.com \
--cc=vfazio@xes-inc.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.