From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1n61E3-0004d5-A2 for mharc-grub-devel@gnu.org; Fri, 07 Jan 2022 21:13:00 -0500 Received: from eggs.gnu.org ([209.51.188.92]:53896) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n61E1-0004bK-8b for grub-devel@gnu.org; Fri, 07 Jan 2022 21:12:57 -0500 Received: from [2607:f8b0:4864:20::830] (port=34526 helo=mail-qt1-x830.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n61Dz-0002yn-Gr for grub-devel@gnu.org; Fri, 07 Jan 2022 21:12:57 -0500 Received: by mail-qt1-x830.google.com with SMTP id o17so7466557qtk.1 for ; Fri, 07 Jan 2022 18:12:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficientek-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references:reply-to :mime-version:content-transfer-encoding; bh=Va11UCKrxP963Xp/3BBlatFNftcm5yz6eRHx3F2tbBg=; b=hz37MmOYcvWO5L/q+TiZCKZjXuwhFMwUQtUlBssop+6r0sTQuBBMVacZSHR3YLenUm 4IwhJe1QfoB17y8taRrPI2J19VAi6PgUeMCbCWwFTHRF9JKFyE1pDaQHtTwxj0Yr7V1z W0EMNC7DfS2BG/ODyMFCWv9vmcHdtBRzMr4nVKxhj22rmNVLOOLc+5i4DjSO2lbu2491 EnyJvghAgt/mdI8CySVxZX572rPQEJ4QmP7LbWHXmA8kFs1fkeMbR7BmGXJWJB2bPes6 9po05ynBE6vJDlRxONH+R2LvaTv5R2bPp4lIyPLUt5Ne7EhvrN05if3xqnBR46KyCVU5 IHjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:reply-to:mime-version:content-transfer-encoding; bh=Va11UCKrxP963Xp/3BBlatFNftcm5yz6eRHx3F2tbBg=; b=1N9SGSJF2sDC68R4ivMO0DHUgRUid+wOjoWTSjN6NmsR/g5q5KudD20Q4jNghIbkG0 5F5AMq4MNbjSbxK3bpZ1TC4Y+5kbArVi06Qfs7TP4+nFOQ1y5XOte5OgGiIpMe9bWBha apPoiWMrPO1YquOmtwSX/3cI9JYGHS0RjZ0ZIadBjJ39EOHxrCWMtyM3IThYdb63LGcX 1uJK3397KrnT7h6hUWuFkAlfIj8TpWWMlGFvMgDw4oIAnCGdh5N4UPrcGe4k7Y+tAPYK iU1LAF0BW0M4a9CYQziwqmavCRD+cXimWqwwh3MFeHd/prm0KHp5bIL10CsvOPAVKmp/ Zx3w== X-Gm-Message-State: AOAM530ouY/uEg1IM4Gmg8qYYCKxi13waJjy3vmt3LwQQx2SQ6BjxKlS 920/zjsUO8594MsdiSJtRvlR6VE3gBml0A== X-Google-Smtp-Source: ABdhPJy983tqsXmmd6oSEnpDTTtp3OtoK/otTg668Tq2e3gklBS7VdAYOQX4ylwWM8wey90/t2rSXw== X-Received: by 2002:a05:622a:20e:: with SMTP id b14mr57941052qtx.288.1641607974457; Fri, 07 Jan 2022 18:12:54 -0800 (PST) Received: from crass-HP-ZBook-15-G2 ([37.218.244.251]) by smtp.gmail.com with ESMTPSA id 2sm218450qty.36.2022.01.07.18.12.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Jan 2022 18:12:54 -0800 (PST) Date: Fri, 7 Jan 2022 20:12:47 -0600 From: Glenn Washburn To: Daniel Kiper Cc: grub-devel@gnu.org, darren.kenny@oracle.com Subject: Re: [PATCH] bootstrap: When a commit hash is specified, do a shallow fetch if possible Message-ID: <20220107201247.5c8f434a@crass-HP-ZBook-15-G2> In-Reply-To: <20211025213506.u5zr6uvfuettl3dd@tomti.i.net-space.pl> References: <20211021174919.895813-1-development@efficientek.com> <20211022164415.lsh3f4v3yofxcmqf@tomti.i.net-space.pl> <20211022162641.2826c075@crass-HP-ZBook-15-G2> <20211025213506.u5zr6uvfuettl3dd@tomti.i.net-space.pl> Reply-To: development@efficientek.com X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::830 (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::830; envelope-from=development@efficientek.com; helo=mail-qt1-x830.google.com X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 08 Jan 2022 02:12:57 -0000 On Mon, 25 Oct 2021 23:35:06 +0200 Daniel Kiper wrote: > On Fri, Oct 22, 2021 at 04:26:41PM -0500, Glenn Washburn wrote: > > On Fri, 22 Oct 2021 18:44:15 +0200 > > Daniel Kiper wrote: > > > > > Is this hunk from gnulib upstream? If not I would prefer if you upstream > > > it into gnulib. We should avoid custom patches for imported code as much > > > as possible. > > > > I agree in general. As mentioned in a follow up reply to this patch, I > > did submit the patch upstream[1]. The only difference is the commit > > Oh, sorry, I missed this somehow. > > > message. It has not been responded to yet. However, even once accepted > > upstream we'll have to cherry-pick it to the GRUB repo. Are you > > thinking we'd need to get all changes to bootstrap at that time? It > > doesn't look like there's anything that would be that useful (except > > maybe using the https repo url). I'm curious how you'd like to handle > > this. > > I want to bump the gnulib version to the latest one. Though first of all > we have to upstream a few gnulib issues discovered by the Coverity. > Darren, CC-ed, is working on it. What's the current status of this? > > I don't think the issue of a custom patch in this instance is a problem > > though. Bootstrap very rarely changes, even in upstream (<10 changes in > > the last 2 years). So there I'm not concerned about having to maintain > > a lot of custom patches on top of it (like the situation of many > > distros vis-a-vis GRUB). So I think if its not accepted upstream (I > > don't see why it wouldn't be), I think we should use in GRUB because it > > provides significant reduction in bandwith and a drastic reduction in > > time to checkout on a qemu VM (but also significant not on a VM, 5min > > vs 1min) depending on the CPU resources available. This is especially > > useful for a CI/testing system that is frequently run. > > If gnulib upstream folks reject it then I can consider taking this patch > into the GRUB. > > > I'm fine with waiting a few weeks and see what happens upstream. > > Sounds like a plan. > > Daniel > > > Glenn > > > > [1] https://lists.gnu.org/archive/html/bug-gnulib/2021-10/msg00052.html Ok its finally been committed to the upstream repo after being missed these past few months. Once/if the Coverity issues are committed we can work on using the latest git revision. Glenn