Re: [Buildroot] [PATCH 1/1] package/avahi: allow disabling default services

From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Florian Larysch <fl@n621.de>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/avahi: allow disabling default services
Date: Fri, 7 Jan 2022 22:07:11 +0100	[thread overview]
Message-ID: <20220107220711.2352f527@windsurf> (raw)
In-Reply-To: <20201204174507.8483-1-fl@n621.de>

Hello Florian,

On Fri,  4 Dec 2020 18:45:08 +0100
Florian Larysch <fl@n621.de> wrote:

> By default, Avahi installs service definitions for SSH and SFTP, but
> those might not be present on all systems. Add an option for disabling
> them.
> 
> As there is no way to tell the Avahi package not to install the service
> files in the first place, we have to manually remove them from the
> target directory.
> 
> Signed-off-by: Florian Larysch <fl@n621.de>
> ---
>  package/avahi/Config.in | 8 ++++++++
>  package/avahi/avahi.mk  | 9 +++++++++
>  2 files changed, 17 insertions(+)

I have finally applied this patch! With some changes:

 * I made the option default to disabled, following the discussion that
   took place

 * Fixed some formatting issues reported by "make check-package"

 * Used a make foreach loop instead of a shell for loop

 * Used $(...) to refer to the make variable instead of ${...}

Thanks a lot, and sorry for the long delay!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot