All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fabiano Rosas <farosas@linux.ibm.com>
To: qemu-devel@nongnu.org
Cc: richard.henderson@linaro.org, danielhb413@gmail.com,
	qemu-ppc@nongnu.org, clg@kaod.org, david@gibson.dropbear.id.au
Subject: [PATCH v3 2/8] target/ppc: powerpc_excp: Keep 60x/7x5 soft MMU logs active
Date: Fri,  7 Jan 2022 19:25:55 -0300	[thread overview]
Message-ID: <20220107222601.4101511-3-farosas@linux.ibm.com> (raw)
In-Reply-To: <20220107222601.4101511-1-farosas@linux.ibm.com>

Remove the compile time definition and make the logging be controlled
by the `-d mmu` option in the cmdline.

Signed-off-by: Fabiano Rosas <farosas@linux.ibm.com>
Reviewed-by: Cédric Le Goater <clg@kaod.org>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
---
 target/ppc/excp_helper.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/target/ppc/excp_helper.c b/target/ppc/excp_helper.c
index 2c5d5470de..a12ed14c30 100644
--- a/target/ppc/excp_helper.c
+++ b/target/ppc/excp_helper.c
@@ -30,8 +30,6 @@
 #include "exec/cpu_ldst.h"
 #endif
 
-/* #define DEBUG_SOFTWARE_TLB */
-
 /*****************************************************************************/
 /* Exception processing */
 #if !defined(CONFIG_USER_ONLY)
@@ -137,12 +135,11 @@ static void dump_hcall(CPUPPCState *env)
 
 static void ppc_excp_debug_sw_tlb(CPUPPCState *env, int excp)
 {
-#if defined(DEBUG_SOFTWARE_TLB)
     const char *es;
     target_ulong *miss, *cmp;
     int en;
 
-    if (!qemu_log_enabled()) {
+    if (!qemu_loglevel_mask(CPU_LOG_MMU)) {
         return;
     }
 
@@ -166,7 +163,6 @@ static void ppc_excp_debug_sw_tlb(CPUPPCState *env, int excp)
              TARGET_FMT_lx " %08x\n", es, en, *miss, en, *cmp,
              env->spr[SPR_HASH1], env->spr[SPR_HASH2],
              env->error_code);
-#endif
 }
 
 
-- 
2.33.1



  parent reply	other threads:[~2022-01-07 22:28 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-07 22:25 [PATCH v3 0/8] target/ppc: powerpc_excp improvements (2/n) Fabiano Rosas
2022-01-07 22:25 ` [PATCH v3 1/8] target/ppc: powerpc_excp: Extract software TLB logging into a function Fabiano Rosas
2022-01-07 22:25 ` Fabiano Rosas [this message]
2022-01-07 22:25 ` [PATCH v3 3/8] target/ppc: powerpc_excp: Group unimplemented exceptions Fabiano Rosas
2022-01-07 22:25 ` [PATCH v3 4/8] target/ppc: Add HV support to ppc_interrupts_little_endian Fabiano Rosas
2022-01-07 22:25 ` [PATCH v3 5/8] target/ppc: Add MSR_ILE " Fabiano Rosas
2022-01-07 22:25 ` [PATCH v3 6/8] target/ppc: Use ppc_interrupts_little_endian in powerpc_excp Fabiano Rosas
2022-01-07 22:26 ` [PATCH v3 7/8] target/ppc: Introduce a wrapper for powerpc_excp Fabiano Rosas
2022-01-07 22:26 ` [PATCH v3 8/8] target/ppc: Set the correct endianness for powernv memory dumps Fabiano Rosas
2022-01-10  2:24   ` David Gibson
2022-01-10  7:38 ` [PATCH v3 0/8] target/ppc: powerpc_excp improvements (2/n) Cédric Le Goater

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220107222601.4101511-3-farosas@linux.ibm.com \
    --to=farosas@linux.ibm.com \
    --cc=clg@kaod.org \
    --cc=danielhb413@gmail.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.