From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D1C6C433F5 for ; Sat, 8 Jan 2022 01:26:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232277AbiAHB0x (ORCPT ); Fri, 7 Jan 2022 20:26:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51628 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232266AbiAHB0w (ORCPT ); Fri, 7 Jan 2022 20:26:52 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DA43CC061574; Fri, 7 Jan 2022 17:26:51 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A179FB827B9; Sat, 8 Jan 2022 01:26:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4E050C36AEB; Sat, 8 Jan 2022 01:26:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1641605209; bh=yxBttM5jej8eNEF7N0nxMv/+l9qCoNu2IKJT8kt1onQ=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=Whn+48xnqgmNqwy6UGTJIrRM0ryA2+K6C73/dGSgXrB3JYDQvkdKmNfhCss8auvU4 jtMTEJksm0DCYhgbhxK0FBOtC/CYN4f5hL4lxYGdPsOMiwGpkLiKlzdsELhrLw0gfo cUOXCpF/Wo+nOfMcX71YY1DwxpHx20eWPjnsgPhM224Fv4DcAEssQ9srYwgJYm/kRr Gvttba4aO0U8HP2rQbUoGEc38HdAEeulcqt3WO6h+xttBvi/0IGRdUkA5plYhZ9ET7 3AB98ZpaR+fV3QdBdBqTUzcvx0bHxDZnzCswx3HdyO2qty3/EFuQBjWy3aDGWtArYg UDbvXUCeNFAag== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20211217155512.1877408-2-dario.binacchi@amarulasolutions.com> References: <20211217155512.1877408-1-dario.binacchi@amarulasolutions.com> <20211217155512.1877408-2-dario.binacchi@amarulasolutions.com> Subject: Re: [RFC PATCH 1/4] clk: mxs: imx28: Reparent gpmi clk to ref_gpmi From: Stephen Boyd Cc: Michael Trimarchi , Dario Binacchi , Fabio Estevam , Michael Turquette , NXP Linux Team , Pengutronix Kernel Team , Sascha Hauer , Shawn Guo , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org To: Dario Binacchi , linux-kernel@vger.kernel.org Date: Fri, 07 Jan 2022 17:26:48 -0800 User-Agent: alot/0.9.1 Message-Id: <20220108012649.4E050C36AEB@smtp.kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Quoting Dario Binacchi (2021-12-17 07:55:09) > From: Michael Trimarchi >=20 > ref_gpmi is connected that is sourced from pll0. This allow > to get nand clk frequency to handle edo mode 5,4,3 >=20 > Signed-off-by: Michael Trimarchi > Signed-off-by: Dario Binacchi > --- >=20 > drivers/clk/mxs/clk-imx28.c | 3 +++ > 1 file changed, 3 insertions(+) >=20 > diff --git a/drivers/clk/mxs/clk-imx28.c b/drivers/clk/mxs/clk-imx28.c > index 62146ea4d5b8..9e0b9f8e5885 100644 > --- a/drivers/clk/mxs/clk-imx28.c > +++ b/drivers/clk/mxs/clk-imx28.c > @@ -243,6 +243,9 @@ static void __init mx28_clocks_init(struct device_nod= e *np) > =20 > clk_register_clkdev(clks[enet_out], NULL, "enet_out"); > =20 > + /* GPMI set parent to ref_gpmi instead of osc */ > + clk_set_parent(clks[gpmi_sel], clks[ref_gpmi]); Please check the return value and print a warning or something if it fails. Also, can it be done through assigned-clock-parents instead? > + > for (i =3D 0; i < ARRAY_SIZE(clks_init_on); i++) > clk_prepare_enable(clks[clks_init_on[i]]); > } From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 20B12C433EF for ; Sat, 8 Jan 2022 01:28:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:To:Cc:From:Subject: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gaXIMXJ+of6r0VqsXh+bhZ9buLRhpAa27qmR/Ae347g=; b=28rn4aeQ5AZIJp 8wzy6pr/BCN6I7LhP4ApyK8BGkAMi3XEjAAu4kDRm0sK0646DeHkgplkHWbJPKUhBmyhw6aiwygcF je5D+hVNAkaV+X2QXnJrdfHhA2M9ka4mjPSNZqnxEczypvjSo01AF99hgfZR995i65mIVaAeLqgxm 8G9+C8Rk3oE9g/zvD7WKkiheRk0L59K1pRL4Kt7HmQAJQJdZ+XSGSm/HjJLaN8V53/FfhGUn16YcG pI3Zguo8SfobVi/F+BVbteY8RfeFrxaVb6iZh6cBS5UxNm6BwC9Ii8N7r3PzCN1rjwDstEaIeikCt /vhVNWH9aHzQcmv4+GxQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n60VU-005kJa-EG; Sat, 08 Jan 2022 01:26:56 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n60VR-005kHz-Nr for linux-arm-kernel@lists.infradead.org; Sat, 08 Jan 2022 01:26:55 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A6355B827BF; Sat, 8 Jan 2022 01:26:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4E050C36AEB; Sat, 8 Jan 2022 01:26:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1641605209; bh=yxBttM5jej8eNEF7N0nxMv/+l9qCoNu2IKJT8kt1onQ=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=Whn+48xnqgmNqwy6UGTJIrRM0ryA2+K6C73/dGSgXrB3JYDQvkdKmNfhCss8auvU4 jtMTEJksm0DCYhgbhxK0FBOtC/CYN4f5hL4lxYGdPsOMiwGpkLiKlzdsELhrLw0gfo cUOXCpF/Wo+nOfMcX71YY1DwxpHx20eWPjnsgPhM224Fv4DcAEssQ9srYwgJYm/kRr Gvttba4aO0U8HP2rQbUoGEc38HdAEeulcqt3WO6h+xttBvi/0IGRdUkA5plYhZ9ET7 3AB98ZpaR+fV3QdBdBqTUzcvx0bHxDZnzCswx3HdyO2qty3/EFuQBjWy3aDGWtArYg UDbvXUCeNFAag== MIME-Version: 1.0 In-Reply-To: <20211217155512.1877408-2-dario.binacchi@amarulasolutions.com> References: <20211217155512.1877408-1-dario.binacchi@amarulasolutions.com> <20211217155512.1877408-2-dario.binacchi@amarulasolutions.com> Subject: Re: [RFC PATCH 1/4] clk: mxs: imx28: Reparent gpmi clk to ref_gpmi From: Stephen Boyd Cc: Michael Trimarchi , Dario Binacchi , Fabio Estevam , Michael Turquette , NXP Linux Team , Pengutronix Kernel Team , Sascha Hauer , Shawn Guo , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org To: Dario Binacchi , linux-kernel@vger.kernel.org Date: Fri, 07 Jan 2022 17:26:48 -0800 User-Agent: alot/0.9.1 Message-Id: <20220108012649.4E050C36AEB@smtp.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220107_172653_938026_041F60E7 X-CRM114-Status: GOOD ( 15.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Dario Binacchi (2021-12-17 07:55:09) > From: Michael Trimarchi > > ref_gpmi is connected that is sourced from pll0. This allow > to get nand clk frequency to handle edo mode 5,4,3 > > Signed-off-by: Michael Trimarchi > Signed-off-by: Dario Binacchi > --- > > drivers/clk/mxs/clk-imx28.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/clk/mxs/clk-imx28.c b/drivers/clk/mxs/clk-imx28.c > index 62146ea4d5b8..9e0b9f8e5885 100644 > --- a/drivers/clk/mxs/clk-imx28.c > +++ b/drivers/clk/mxs/clk-imx28.c > @@ -243,6 +243,9 @@ static void __init mx28_clocks_init(struct device_node *np) > > clk_register_clkdev(clks[enet_out], NULL, "enet_out"); > > + /* GPMI set parent to ref_gpmi instead of osc */ > + clk_set_parent(clks[gpmi_sel], clks[ref_gpmi]); Please check the return value and print a warning or something if it fails. Also, can it be done through assigned-clock-parents instead? > + > for (i = 0; i < ARRAY_SIZE(clks_init_on); i++) > clk_prepare_enable(clks[clks_init_on[i]]); > } _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel