diff for duplicates of <202201080313.70ZrhufR-lkp@intel.com> diff --git a/a/1.txt b/N1/1.txt index 5689eb2..f3eef90 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,8 +1,33 @@ +CC: kbuild-all(a)lists.01.org +In-Reply-To: <20220106125947.139523-7-gengcixi@gmail.com> +References: <20220106125947.139523-7-gengcixi@gmail.com> +TO: Cixi Geng <gengcixi@gmail.com> +TO: orsonzhai(a)gmail.com +TO: baolin.wang7(a)gmail.com +TO: zhang.lyra(a)gmail.com +TO: jic23(a)kernel.org +TO: lars(a)metafoo.de +TO: robh+dt(a)kernel.org +TO: lgirdwood(a)gmail.com +TO: broonie(a)kernel.org +CC: yuming.zhu1(a)unisoc.com +CC: linux-iio(a)vger.kernel.org + Hi Cixi, +Thank you for the patch! Perhaps something to improve: + +[auto build test WARNING on jic23-iio/togreg] +[also build test WARNING on v5.16-rc8 next-20220106] +[If your patch is applied to the wrong git tree, kindly drop us a note. +And when submitting patch, we suggest to use '--base' as documented in +https://git-scm.com/docs/git-format-patch] + url: https://github.com/0day-ci/linux/commits/Cixi-Geng/iio-adc-sc27xx-adjust-structure-and-add-PMIC-s-support/20220106-210151 base: https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg -config: openrisc-randconfig-m031-20220106 (https://download.01.org/0day-ci/archive/20220108/202201080313.70ZrhufR-lkp@intel.com/config) +:::::: branch date: 30 hours ago +:::::: commit date: 30 hours ago +config: openrisc-randconfig-m031-20220106 (https://download.01.org/0day-ci/archive/20220108/202201080313.70ZrhufR-lkp(a)intel.com/config) compiler: or1k-linux-gcc (GCC) 11.2.0 If you fix the issue, kindly add following tag as appropriate @@ -12,8 +37,14 @@ Reported-by: Dan Carpenter <dan.carpenter@oracle.com> New smatch warnings: drivers/iio/adc/sc27xx_adc.c:196 adc_nvmem_cell_calib_data() warn: passing zero to 'PTR_ERR' +Old smatch warnings: +drivers/iio/adc/sc27xx_adc.c:201 adc_nvmem_cell_calib_data() warn: passing zero to 'PTR_ERR' +drivers/iio/adc/sc27xx_adc.c:706 sc27xx_adc_read() error: uninitialized symbol 'value'. +drivers/iio/adc/sc27xx_adc.c:1123 sc27xx_adc_probe() warn: passing zero to 'PTR_ERR' + vim +/PTR_ERR +196 drivers/iio/adc/sc27xx_adc.c +8ba0dbfd07a358 Baolin Wang 2018-08-29 183 87da8dcc76b4aa Cixi Geng 2022-01-06 184 static int adc_nvmem_cell_calib_data(struct sc27xx_adc_data *data, const char *cell_name) 87da8dcc76b4aa Cixi Geng 2022-01-06 185 { 87da8dcc76b4aa Cixi Geng 2022-01-06 186 struct nvmem_cell *cell; @@ -27,29 +58,11 @@ vim +/PTR_ERR +196 drivers/iio/adc/sc27xx_adc.c 87da8dcc76b4aa Cixi Geng 2022-01-06 194 cell = nvmem_cell_get(data->dev, cell_name); 87da8dcc76b4aa Cixi Geng 2022-01-06 195 if (IS_ERR_OR_NULL(cell)) 87da8dcc76b4aa Cixi Geng 2022-01-06 @196 return PTR_ERR(cell); - -When functions return a both error pointers and NULL, then the NULL -return means that the feature has been deliberately disabled by the -admin. - -nvmem_cell_get() cannot be disabled and never returns NULL so this code -should just be: - - if (IS_ERR(cell)) - return PTR_ERR(cell); - -Otherwise we have to create the whole infrastructure to disable it. We -can't just create random sprinklings of dead code to half way support -disabling the feature. - 87da8dcc76b4aa Cixi Geng 2022-01-06 197 87da8dcc76b4aa Cixi Geng 2022-01-06 198 buf = nvmem_cell_read(cell, &len); 87da8dcc76b4aa Cixi Geng 2022-01-06 199 if (IS_ERR_OR_NULL(buf)) { 87da8dcc76b4aa Cixi Geng 2022-01-06 200 nvmem_cell_put(cell); 87da8dcc76b4aa Cixi Geng 2022-01-06 201 return PTR_ERR(buf); - -Same. - 87da8dcc76b4aa Cixi Geng 2022-01-06 202 } 87da8dcc76b4aa Cixi Geng 2022-01-06 203 87da8dcc76b4aa Cixi Geng 2022-01-06 204 memcpy(&calib_data, buf, min(len, sizeof(u32))); @@ -58,7 +71,8 @@ Same. 87da8dcc76b4aa Cixi Geng 2022-01-06 207 nvmem_cell_put(cell); 87da8dcc76b4aa Cixi Geng 2022-01-06 208 return calib_data; 87da8dcc76b4aa Cixi Geng 2022-01-06 209 } +87da8dcc76b4aa Cixi Geng 2022-01-06 210 --- 0-DAY CI Kernel Test Service, Intel Corporation -https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org +https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org diff --git a/a/content_digest b/N1/content_digest index 6186e55..12f39e4 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,28 +1,39 @@ - "ref\020220106125947.139523-7-gengcixi@gmail.com\0" - "From\0Dan Carpenter <dan.carpenter@oracle.com>\0" + "From\0kernel test robot <lkp@intel.com>\0" "Subject\0Re: [PATCH 6/7] iio: adc: sc27xx: add support for PMIC ump9620\0" - "Date\0Mon, 10 Jan 2022 09:30:38 +0300\0" - "To\0kbuild@lists.01.org" - Cixi Geng <gengcixi@gmail.com> - orsonzhai@gmail.com - baolin.wang7@gmail.com - zhang.lyra@gmail.com - jic23@kernel.org - lars@metafoo.de - robh+dt@kernel.org - lgirdwood@gmail.com - " broonie@kernel.org\0" - "Cc\0lkp@intel.com" - kbuild-all@lists.01.org - yuming.zhu1@unisoc.com - " linux-iio@vger.kernel.org\0" - "\00:1\0" + "Date\0Sat, 08 Jan 2022 03:17:50 +0800\0" + "To\0kbuild@lists.01.org\0" + "\01:1\0" "b\0" + "CC: kbuild-all(a)lists.01.org\n" + "In-Reply-To: <20220106125947.139523-7-gengcixi@gmail.com>\n" + "References: <20220106125947.139523-7-gengcixi@gmail.com>\n" + "TO: Cixi Geng <gengcixi@gmail.com>\n" + "TO: orsonzhai(a)gmail.com\n" + "TO: baolin.wang7(a)gmail.com\n" + "TO: zhang.lyra(a)gmail.com\n" + "TO: jic23(a)kernel.org\n" + "TO: lars(a)metafoo.de\n" + "TO: robh+dt(a)kernel.org\n" + "TO: lgirdwood(a)gmail.com\n" + "TO: broonie(a)kernel.org\n" + "CC: yuming.zhu1(a)unisoc.com\n" + "CC: linux-iio(a)vger.kernel.org\n" + "\n" "Hi Cixi,\n" "\n" + "Thank you for the patch! Perhaps something to improve:\n" + "\n" + "[auto build test WARNING on jic23-iio/togreg]\n" + "[also build test WARNING on v5.16-rc8 next-20220106]\n" + "[If your patch is applied to the wrong git tree, kindly drop us a note.\n" + "And when submitting patch, we suggest to use '--base' as documented in\n" + "https://git-scm.com/docs/git-format-patch]\n" + "\n" "url: https://github.com/0day-ci/linux/commits/Cixi-Geng/iio-adc-sc27xx-adjust-structure-and-add-PMIC-s-support/20220106-210151\n" "base: https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg\n" - "config: openrisc-randconfig-m031-20220106 (https://download.01.org/0day-ci/archive/20220108/202201080313.70ZrhufR-lkp@intel.com/config)\n" + ":::::: branch date: 30 hours ago\n" + ":::::: commit date: 30 hours ago\n" + "config: openrisc-randconfig-m031-20220106 (https://download.01.org/0day-ci/archive/20220108/202201080313.70ZrhufR-lkp(a)intel.com/config)\n" "compiler: or1k-linux-gcc (GCC) 11.2.0\n" "\n" "If you fix the issue, kindly add following tag as appropriate\n" @@ -32,8 +43,14 @@ "New smatch warnings:\n" "drivers/iio/adc/sc27xx_adc.c:196 adc_nvmem_cell_calib_data() warn: passing zero to 'PTR_ERR'\n" "\n" + "Old smatch warnings:\n" + "drivers/iio/adc/sc27xx_adc.c:201 adc_nvmem_cell_calib_data() warn: passing zero to 'PTR_ERR'\n" + "drivers/iio/adc/sc27xx_adc.c:706 sc27xx_adc_read() error: uninitialized symbol 'value'.\n" + "drivers/iio/adc/sc27xx_adc.c:1123 sc27xx_adc_probe() warn: passing zero to 'PTR_ERR'\n" + "\n" "vim +/PTR_ERR +196 drivers/iio/adc/sc27xx_adc.c\n" "\n" + "8ba0dbfd07a358 Baolin Wang 2018-08-29 183 \n" "87da8dcc76b4aa Cixi Geng 2022-01-06 184 static int adc_nvmem_cell_calib_data(struct sc27xx_adc_data *data, const char *cell_name)\n" "87da8dcc76b4aa Cixi Geng 2022-01-06 185 {\n" "87da8dcc76b4aa Cixi Geng 2022-01-06 186 \tstruct nvmem_cell *cell;\n" @@ -47,29 +64,11 @@ "87da8dcc76b4aa Cixi Geng 2022-01-06 194 \tcell = nvmem_cell_get(data->dev, cell_name);\n" "87da8dcc76b4aa Cixi Geng 2022-01-06 195 \tif (IS_ERR_OR_NULL(cell))\n" "87da8dcc76b4aa Cixi Geng 2022-01-06 @196 \t\treturn PTR_ERR(cell);\n" - "\n" - "When functions return a both error pointers and NULL, then the NULL\n" - "return means that the feature has been deliberately disabled by the\n" - "admin.\n" - "\n" - "nvmem_cell_get() cannot be disabled and never returns NULL so this code\n" - "should just be:\n" - "\n" - "\tif (IS_ERR(cell))\n" - "\t\treturn PTR_ERR(cell);\n" - "\n" - "Otherwise we have to create the whole infrastructure to disable it. We\n" - "can't just create random sprinklings of dead code to half way support\n" - "disabling the feature.\n" - "\n" "87da8dcc76b4aa Cixi Geng 2022-01-06 197 \n" "87da8dcc76b4aa Cixi Geng 2022-01-06 198 \tbuf = nvmem_cell_read(cell, &len);\n" "87da8dcc76b4aa Cixi Geng 2022-01-06 199 \tif (IS_ERR_OR_NULL(buf)) {\n" "87da8dcc76b4aa Cixi Geng 2022-01-06 200 \t\tnvmem_cell_put(cell);\n" "87da8dcc76b4aa Cixi Geng 2022-01-06 201 \t\treturn PTR_ERR(buf);\n" - "\n" - "Same.\n" - "\n" "87da8dcc76b4aa Cixi Geng 2022-01-06 202 \t}\n" "87da8dcc76b4aa Cixi Geng 2022-01-06 203 \n" "87da8dcc76b4aa Cixi Geng 2022-01-06 204 \tmemcpy(&calib_data, buf, min(len, sizeof(u32)));\n" @@ -78,9 +77,10 @@ "87da8dcc76b4aa Cixi Geng 2022-01-06 207 \tnvmem_cell_put(cell);\n" "87da8dcc76b4aa Cixi Geng 2022-01-06 208 \treturn calib_data;\n" "87da8dcc76b4aa Cixi Geng 2022-01-06 209 }\n" + "87da8dcc76b4aa Cixi Geng 2022-01-06 210 \n" "\n" "---\n" "0-DAY CI Kernel Test Service, Intel Corporation\n" - https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org + https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org -be1239e8acf3eb6b270464daf58b615d7b965e0b9fbbe15c1c5e16c6c8eab352 +c945be77a12945c5e26a1a6e2aab8fafb392f991b991f6b76da818f0464f6a0d
diff --git a/a/1.txt b/N2/1.txt index 5689eb2..9e74f00 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -2,7 +2,7 @@ Hi Cixi, url: https://github.com/0day-ci/linux/commits/Cixi-Geng/iio-adc-sc27xx-adjust-structure-and-add-PMIC-s-support/20220106-210151 base: https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg -config: openrisc-randconfig-m031-20220106 (https://download.01.org/0day-ci/archive/20220108/202201080313.70ZrhufR-lkp@intel.com/config) +config: openrisc-randconfig-m031-20220106 (https://download.01.org/0day-ci/archive/20220108/202201080313.70ZrhufR-lkp(a)intel.com/config) compiler: or1k-linux-gcc (GCC) 11.2.0 If you fix the issue, kindly add following tag as appropriate @@ -61,4 +61,4 @@ Same. --- 0-DAY CI Kernel Test Service, Intel Corporation -https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org +https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org diff --git a/a/content_digest b/N2/content_digest index 6186e55..4e77c5b 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -2,27 +2,14 @@ "From\0Dan Carpenter <dan.carpenter@oracle.com>\0" "Subject\0Re: [PATCH 6/7] iio: adc: sc27xx: add support for PMIC ump9620\0" "Date\0Mon, 10 Jan 2022 09:30:38 +0300\0" - "To\0kbuild@lists.01.org" - Cixi Geng <gengcixi@gmail.com> - orsonzhai@gmail.com - baolin.wang7@gmail.com - zhang.lyra@gmail.com - jic23@kernel.org - lars@metafoo.de - robh+dt@kernel.org - lgirdwood@gmail.com - " broonie@kernel.org\0" - "Cc\0lkp@intel.com" - kbuild-all@lists.01.org - yuming.zhu1@unisoc.com - " linux-iio@vger.kernel.org\0" - "\00:1\0" + "To\0kbuild-all@lists.01.org\0" + "\01:1\0" "b\0" "Hi Cixi,\n" "\n" "url: https://github.com/0day-ci/linux/commits/Cixi-Geng/iio-adc-sc27xx-adjust-structure-and-add-PMIC-s-support/20220106-210151\n" "base: https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg\n" - "config: openrisc-randconfig-m031-20220106 (https://download.01.org/0day-ci/archive/20220108/202201080313.70ZrhufR-lkp@intel.com/config)\n" + "config: openrisc-randconfig-m031-20220106 (https://download.01.org/0day-ci/archive/20220108/202201080313.70ZrhufR-lkp(a)intel.com/config)\n" "compiler: or1k-linux-gcc (GCC) 11.2.0\n" "\n" "If you fix the issue, kindly add following tag as appropriate\n" @@ -81,6 +68,6 @@ "\n" "---\n" "0-DAY CI Kernel Test Service, Intel Corporation\n" - https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org + https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org -be1239e8acf3eb6b270464daf58b615d7b965e0b9fbbe15c1c5e16c6c8eab352 +e62f6fc242d520a96ff09df61eb9599232f060b8def2ca6a8242b58444abc976
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.