Re: [Buildroot] [PATCH v2, 1/1] package/file: fix build with gcc 4.8

[Peter Seiderer <ps.report@gmx.net>]

Hello Fabrice, *,

On Sat, 8 Jan 2022 17:13:47 +0100, Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> Hi,
> 
> Le sam. 8 janv. 2022 à 11:51, Thomas Petazzoni
> <thomas.petazzoni@bootlin.com> a écrit :
> >
> > On Tue,  4 Jan 2022 21:54:55 +0100
> > Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> >  
> > > Fix the following build failure raised since bump to version 5.41 in
> > > commit d38b72bcd75392a88b5100839ac410859d0a6a79:
> > >
> > > readelf.c: In function 'do_auxv_note':
> > > readelf.c:1046:2: error: 'for' loop initial declarations are only allowed in C99 mode
> > >   for (size_t off = 0; off + elsize <= descsz; off += elsize) {
> > >   ^
> > >
> > > Fixes:
> > >  - http://autobuild.buildroot.org/results/31cbc313fceb84c0cbb1969fca5ac44244871dbc
> > >
> > > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>  
> >
> > I am afraid it seems like this didn't fix the problem, see:
> >
> >   http://autobuild.buildroot.net/results/957/9573e8b01d8f21cd89a67475daabdeef533d31d7/build-end.log
> >
> > ac_cv_prog_cc_c99='-std=gnu99' is properly passed to the configure
> > script, but it still fails.  
> Indeed, I suggest to revert this commit and apply the version 1 of
> this patch instead of trying to understand what is "broken" in the
> configure script.

The difference seems to be:

	$ diff -ru file-5.38/configure.ac file-5.41/configure.ac
[...]
@@ -88,7 +88,7 @@
 AC_SUBST(WARNINGS)
 
 dnl Checks for programs.
-AC_PROG_CC_STDC
+AC_PROG_CC
 AC_USE_SYSTEM_EXTENSIONS
 AM_PROG_CC_C_O
 AC_C_BIGENDIAN
[...]

According to [1] AC_PROG_CC checks/enables c89 and AC_PROG_CC_STDC checks/enabls C99 (or
use AC_PROG_CC_C99 to be more explicit)..., note that with AC_PROG_CC the ac_cv_prog_cc_c99
feature is gone (still used for target/host in package/file/file.mk)...

Regards,
Peter	

[1] https://www.gnu.org/software/autoconf/manual/autoconf-2.69/html_node/C-Compiler.html

> >
> > Thomas
> > --
> > Thomas Petazzoni, co-owner and CEO, Bootlin
> > Embedded Linux and Kernel engineering and training
> > https://bootlin.com  
> Best Regards,
> 
> Fabrice
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot