diff for duplicates of <202201090204.9HpxUP5B-lkp@intel.com> diff --git a/a/1.txt b/N1/1.txt index faa97cf..49adceb 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,23 +1,7 @@ -CC: kbuild-all(a)lists.01.org -In-Reply-To: <20220105115527.3592860-7-m.grzeschik@pengutronix.de> -References: <20220105115527.3592860-7-m.grzeschik@pengutronix.de> -TO: Michael Grzeschik <m.grzeschik@pengutronix.de> - Hi Michael, -I love your patch! Perhaps something to improve: - -[auto build test WARNING on media-tree/master] -[also build test WARNING on usb/usb-testing peter-chen-usb/for-usb-next v5.16-rc8 next-20220107] -[cannot apply to balbi-usb/testing/next] -[If your patch is applied to the wrong git tree, kindly drop us a note. -And when submitting patch, we suggest to use '--base' as documented in -https://git-scm.com/docs/git-format-patch] - url: https://github.com/0day-ci/linux/commits/Michael-Grzeschik/usb-gadget-uvc-use-configfs-entries-for-negotiation-and-v4l2-VIDIOCS/20220105-195807 base: git://linuxtv.org/media_tree.git master -:::::: branch date: 3 days ago -:::::: commit date: 3 days ago config: i386-randconfig-m021-20220107 (https://download.01.org/0day-ci/archive/20220109/202201090204.9HpxUP5B-lkp(a)intel.com/config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 @@ -30,7 +14,6 @@ drivers/usb/gadget/function/f_uvc.c:983 uvc_alloc() warn: inconsistent returns ' vim +983 drivers/usb/gadget/function/f_uvc.c -6d11ed76c45dd7 Andrzej Pietrasiewicz 2014-09-09 909 4a6698b80cfe36 Fengguang Wu 2014-09-16 910 static struct usb_function *uvc_alloc(struct usb_function_instance *fi) 6d11ed76c45dd7 Andrzej Pietrasiewicz 2014-09-09 911 { 6d11ed76c45dd7 Andrzej Pietrasiewicz 2014-09-09 912 struct uvc_device *uvc; @@ -47,6 +30,9 @@ d8e96c4bf6e3cd Hans Verkuil 2015-02-17 921 mutex_init(&uvc->video.mu bbea6de1bd12dd Andrzej Pietrasiewicz 2014-12-10 923 opts = fi_to_f_uvc_opts(fi); 6d11ed76c45dd7 Andrzej Pietrasiewicz 2014-09-09 924 46919a23ee87bb Andrzej Pietrasiewicz 2014-12-10 925 mutex_lock(&opts->lock); + +take lock + 46919a23ee87bb Andrzej Pietrasiewicz 2014-12-10 926 if (opts->uvc_fs_streaming_cls) { 46919a23ee87bb Andrzej Pietrasiewicz 2014-12-10 927 strm_cls = opts->uvc_fs_streaming_cls; 46919a23ee87bb Andrzej Pietrasiewicz 2014-12-10 928 opts->fs_streaming = @@ -73,22 +59,34 @@ bbea6de1bd12dd Andrzej Pietrasiewicz 2014-12-10 923 opts = fi_to_f_uvc_opts(f 90866d89b13da2 Michael Grzeschik 2022-01-05 949 if (!streaming) { 90866d89b13da2 Michael Grzeschik 2022-01-05 950 config_item_put(streaming); 90866d89b13da2 Michael Grzeschik 2022-01-05 951 return ERR_PTR(-ENOMEM); + +unlock before returning + 90866d89b13da2 Michael Grzeschik 2022-01-05 952 } 90866d89b13da2 Michael Grzeschik 2022-01-05 953 header = config_group_find_item(to_config_group(streaming), "header"); 90866d89b13da2 Michael Grzeschik 2022-01-05 954 config_item_put(streaming); 90866d89b13da2 Michael Grzeschik 2022-01-05 955 if (!header) { 90866d89b13da2 Michael Grzeschik 2022-01-05 956 config_item_put(header); 90866d89b13da2 Michael Grzeschik 2022-01-05 957 return ERR_PTR(-ENOMEM); + +Same + 90866d89b13da2 Michael Grzeschik 2022-01-05 958 } 90866d89b13da2 Michael Grzeschik 2022-01-05 959 h = config_group_find_item(to_config_group(header), "h"); 90866d89b13da2 Michael Grzeschik 2022-01-05 960 config_item_put(header); 90866d89b13da2 Michael Grzeschik 2022-01-05 961 if (!h) { 90866d89b13da2 Michael Grzeschik 2022-01-05 962 config_item_put(h); 90866d89b13da2 Michael Grzeschik 2022-01-05 963 return ERR_PTR(-ENOMEM); + +Same + 90866d89b13da2 Michael Grzeschik 2022-01-05 964 } 90866d89b13da2 Michael Grzeschik 2022-01-05 965 uvc->header = to_uvcg_streaming_header(h); 90866d89b13da2 Michael Grzeschik 2022-01-05 966 if (!uvc->header->linked) 90866d89b13da2 Michael Grzeschik 2022-01-05 967 return ERR_PTR(-EBUSY); + +Same + 90866d89b13da2 Michael Grzeschik 2022-01-05 968 46919a23ee87bb Andrzej Pietrasiewicz 2014-12-10 969 ++opts->refcnt; 46919a23ee87bb Andrzej Pietrasiewicz 2014-12-10 970 mutex_unlock(&opts->lock); @@ -106,7 +104,6 @@ f277bf27cf5cd5 Robert Baldyga 2015-05-04 981 uvc->func.bind_deactivate 6d11ed76c45dd7 Andrzej Pietrasiewicz 2014-09-09 982 6d11ed76c45dd7 Andrzej Pietrasiewicz 2014-09-09 @983 return &uvc->func; 6d11ed76c45dd7 Andrzej Pietrasiewicz 2014-09-09 984 } -6d11ed76c45dd7 Andrzej Pietrasiewicz 2014-09-09 985 --- 0-DAY CI Kernel Test Service, Intel Corporation diff --git a/a/content_digest b/N1/content_digest index deab0fa..3718bb3 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,29 +1,14 @@ - "From\0kernel test robot <lkp@intel.com>\0" + "ref\020220105115527.3592860-7-m.grzeschik@pengutronix.de\0" + "From\0Dan Carpenter <dan.carpenter@oracle.com>\0" "Subject\0Re: [PATCH v6 6/7] usb: gadget: uvc: add VIDIOC function\0" - "Date\0Sun, 09 Jan 2022 02:23:26 +0800\0" - "To\0kbuild@lists.01.org\0" + "Date\0Mon, 10 Jan 2022 10:04:08 +0300\0" + "To\0kbuild-all@lists.01.org\0" "\01:1\0" "b\0" - "CC: kbuild-all(a)lists.01.org\n" - "In-Reply-To: <20220105115527.3592860-7-m.grzeschik@pengutronix.de>\n" - "References: <20220105115527.3592860-7-m.grzeschik@pengutronix.de>\n" - "TO: Michael Grzeschik <m.grzeschik@pengutronix.de>\n" - "\n" "Hi Michael,\n" "\n" - "I love your patch! Perhaps something to improve:\n" - "\n" - "[auto build test WARNING on media-tree/master]\n" - "[also build test WARNING on usb/usb-testing peter-chen-usb/for-usb-next v5.16-rc8 next-20220107]\n" - "[cannot apply to balbi-usb/testing/next]\n" - "[If your patch is applied to the wrong git tree, kindly drop us a note.\n" - "And when submitting patch, we suggest to use '--base' as documented in\n" - "https://git-scm.com/docs/git-format-patch]\n" - "\n" "url: https://github.com/0day-ci/linux/commits/Michael-Grzeschik/usb-gadget-uvc-use-configfs-entries-for-negotiation-and-v4l2-VIDIOCS/20220105-195807\n" "base: git://linuxtv.org/media_tree.git master\n" - ":::::: branch date: 3 days ago\n" - ":::::: commit date: 3 days ago\n" "config: i386-randconfig-m021-20220107 (https://download.01.org/0day-ci/archive/20220109/202201090204.9HpxUP5B-lkp(a)intel.com/config)\n" "compiler: gcc-9 (Debian 9.3.0-22) 9.3.0\n" "\n" @@ -36,7 +21,6 @@ "\n" "vim +983 drivers/usb/gadget/function/f_uvc.c\n" "\n" - "6d11ed76c45dd7 Andrzej Pietrasiewicz 2014-09-09 909 \n" "4a6698b80cfe36 Fengguang Wu 2014-09-16 910 static struct usb_function *uvc_alloc(struct usb_function_instance *fi)\n" "6d11ed76c45dd7 Andrzej Pietrasiewicz 2014-09-09 911 {\n" "6d11ed76c45dd7 Andrzej Pietrasiewicz 2014-09-09 912 \tstruct uvc_device *uvc;\n" @@ -53,6 +37,9 @@ "bbea6de1bd12dd Andrzej Pietrasiewicz 2014-12-10 923 \topts = fi_to_f_uvc_opts(fi);\n" "6d11ed76c45dd7 Andrzej Pietrasiewicz 2014-09-09 924 \n" "46919a23ee87bb Andrzej Pietrasiewicz 2014-12-10 925 \tmutex_lock(&opts->lock);\n" + "\n" + "take lock\n" + "\n" "46919a23ee87bb Andrzej Pietrasiewicz 2014-12-10 926 \tif (opts->uvc_fs_streaming_cls) {\n" "46919a23ee87bb Andrzej Pietrasiewicz 2014-12-10 927 \t\tstrm_cls = opts->uvc_fs_streaming_cls;\n" "46919a23ee87bb Andrzej Pietrasiewicz 2014-12-10 928 \t\topts->fs_streaming =\n" @@ -79,22 +66,34 @@ "90866d89b13da2 Michael Grzeschik 2022-01-05 949 \tif (!streaming) {\n" "90866d89b13da2 Michael Grzeschik 2022-01-05 950 \t\tconfig_item_put(streaming);\n" "90866d89b13da2 Michael Grzeschik 2022-01-05 951 \t\treturn ERR_PTR(-ENOMEM);\n" + "\n" + "unlock before returning\n" + "\n" "90866d89b13da2 Michael Grzeschik 2022-01-05 952 \t}\n" "90866d89b13da2 Michael Grzeschik 2022-01-05 953 \theader = config_group_find_item(to_config_group(streaming), \"header\");\n" "90866d89b13da2 Michael Grzeschik 2022-01-05 954 \tconfig_item_put(streaming);\n" "90866d89b13da2 Michael Grzeschik 2022-01-05 955 \tif (!header) {\n" "90866d89b13da2 Michael Grzeschik 2022-01-05 956 \t\tconfig_item_put(header);\n" "90866d89b13da2 Michael Grzeschik 2022-01-05 957 \t\treturn ERR_PTR(-ENOMEM);\n" + "\n" + "Same\n" + "\n" "90866d89b13da2 Michael Grzeschik 2022-01-05 958 \t}\n" "90866d89b13da2 Michael Grzeschik 2022-01-05 959 \th = config_group_find_item(to_config_group(header), \"h\");\n" "90866d89b13da2 Michael Grzeschik 2022-01-05 960 \tconfig_item_put(header);\n" "90866d89b13da2 Michael Grzeschik 2022-01-05 961 \tif (!h) {\n" "90866d89b13da2 Michael Grzeschik 2022-01-05 962 \t\tconfig_item_put(h);\n" "90866d89b13da2 Michael Grzeschik 2022-01-05 963 \t\treturn ERR_PTR(-ENOMEM);\n" + "\n" + "Same\n" + "\n" "90866d89b13da2 Michael Grzeschik 2022-01-05 964 \t}\n" "90866d89b13da2 Michael Grzeschik 2022-01-05 965 \tuvc->header = to_uvcg_streaming_header(h);\n" "90866d89b13da2 Michael Grzeschik 2022-01-05 966 \tif (!uvc->header->linked)\n" "90866d89b13da2 Michael Grzeschik 2022-01-05 967 \t\treturn ERR_PTR(-EBUSY);\n" + "\n" + "Same\n" + "\n" "90866d89b13da2 Michael Grzeschik 2022-01-05 968 \n" "46919a23ee87bb Andrzej Pietrasiewicz 2014-12-10 969 \t++opts->refcnt;\n" "46919a23ee87bb Andrzej Pietrasiewicz 2014-12-10 970 \tmutex_unlock(&opts->lock);\n" @@ -112,10 +111,9 @@ "6d11ed76c45dd7 Andrzej Pietrasiewicz 2014-09-09 982 \n" "6d11ed76c45dd7 Andrzej Pietrasiewicz 2014-09-09 @983 \treturn &uvc->func;\n" "6d11ed76c45dd7 Andrzej Pietrasiewicz 2014-09-09 984 }\n" - "6d11ed76c45dd7 Andrzej Pietrasiewicz 2014-09-09 985 \n" "\n" "---\n" "0-DAY CI Kernel Test Service, Intel Corporation\n" https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org -38850787a39a3934146b4f59f355a2be60906893cb38ff925ea6317e0de34e22 +0bed797eef627ce30c2ce02c8c366619fbfe7c181361bc56cec9d0cd1298337e
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.