From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============4719281908062693041==" MIME-Version: 1.0 From: kernel test robot To: kbuild-all@lists.01.org Subject: Re: [PATCH 2/2] tracing: Add test for user space strings when filtering on string pointers Date: Sun, 09 Jan 2022 03:04:51 +0800 Message-ID: <202201090343.IKIQqdk4-lkp@intel.com> In-Reply-To: <20220107225840.003487216@goodmis.org> List-Id: --===============4719281908062693041== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi Steven, I love your patch! Perhaps something to improve: [auto build test WARNING on rostedt-trace/for-next] [also build test WARNING on linux/master linus/master hnaz-mm/master v5.16-= rc8 next-20220107] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Steven-Rostedt/tracing-Fix= -filtering-on-string-pointers/20220108-070047 base: https://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace= .git for-next config: openrisc-randconfig-s031-20220107 (https://download.01.org/0day-ci/= archive/20220109/202201090343.IKIQqdk4-lkp(a)intel.com/config) compiler: or1k-linux-gcc (GCC) 11.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/= make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # apt-get install sparse # sparse version: v0.6.4-dirty # https://github.com/0day-ci/linux/commit/19b8c1c0fee0d7bff07ed0d58= 62a29ac2bb4adc9 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Steven-Rostedt/tracing-Fix-filteri= ng-on-string-pointers/20220108-070047 git checkout 19b8c1c0fee0d7bff07ed0d5862a29ac2bb4adc9 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dgcc-11.2.0 make.cross= C=3D1 CF=3D'-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=3Dbuild_dir ARCH=3Do= penrisc SHELL=3D/bin/bash kernel/trace/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot sparse warnings: (new ones prefixed by >>) >> kernel/trace/trace_events_filter.c:685:22: sparse: sparse: incorrect typ= e in assignment (different address spaces) @@ expected char [noderef] _= _user *ustr @@ got char *str @@ kernel/trace/trace_events_filter.c:685:22: sparse: expected char [no= deref] __user *ustr kernel/trace/trace_events_filter.c:685:22: sparse: got char *str >> kernel/trace/trace_events_filter.c:685:22: sparse: sparse: incorrect typ= e in assignment (different address spaces) @@ expected char [noderef] _= _user *ustr @@ got char *str @@ kernel/trace/trace_events_filter.c:685:22: sparse: expected char [no= deref] __user *ustr kernel/trace/trace_events_filter.c:685:22: sparse: got char *str >> kernel/trace/trace_events_filter.c:685:22: sparse: sparse: incorrect typ= e in assignment (different address spaces) @@ expected char [noderef] _= _user *ustr @@ got char *str @@ kernel/trace/trace_events_filter.c:685:22: sparse: expected char [no= deref] __user *ustr kernel/trace/trace_events_filter.c:685:22: sparse: got char *str >> kernel/trace/trace_events_filter.c:685:22: sparse: sparse: incorrect typ= e in assignment (different address spaces) @@ expected char [noderef] _= _user *ustr @@ got char *str @@ kernel/trace/trace_events_filter.c:685:22: sparse: expected char [no= deref] __user *ustr kernel/trace/trace_events_filter.c:685:22: sparse: got char *str >> kernel/trace/trace_events_filter.c:685:22: sparse: sparse: incorrect typ= e in assignment (different address spaces) @@ expected char [noderef] _= _user *ustr @@ got char *str @@ kernel/trace/trace_events_filter.c:685:22: sparse: expected char [no= deref] __user *ustr kernel/trace/trace_events_filter.c:685:22: sparse: got char *str >> kernel/trace/trace_events_filter.c:685:22: sparse: sparse: incorrect typ= e in assignment (different address spaces) @@ expected char [noderef] _= _user *ustr @@ got char *str @@ kernel/trace/trace_events_filter.c:685:22: sparse: expected char [no= deref] __user *ustr kernel/trace/trace_events_filter.c:685:22: sparse: got char *str >> kernel/trace/trace_events_filter.c:685:22: sparse: sparse: incorrect typ= e in assignment (different address spaces) @@ expected char [noderef] _= _user *ustr @@ got char *str @@ kernel/trace/trace_events_filter.c:685:22: sparse: expected char [no= deref] __user *ustr kernel/trace/trace_events_filter.c:685:22: sparse: got char *str kernel/trace/trace_events_filter.c:1066:20: sparse: sparse: incorrect ty= pe in return expression (different address spaces) @@ expected struct e= vent_filter * @@ got struct event_filter [noderef] __rcu *filter @@ kernel/trace/trace_events_filter.c:1066:20: sparse: expected struct = event_filter * kernel/trace/trace_events_filter.c:1066:20: sparse: got struct event= _filter [noderef] __rcu *filter kernel/trace/trace_events_filter.c:1136:34: sparse: sparse: incorrect ty= pe in argument 1 (different address spaces) @@ expected struct event_fi= lter *filter @@ got struct event_filter [noderef] __rcu *filter @@ kernel/trace/trace_events_filter.c:1136:34: sparse: expected struct = event_filter *filter kernel/trace/trace_events_filter.c:1136:34: sparse: got struct event= _filter [noderef] __rcu *filter kernel/trace/trace_events_filter.c:1153:27: sparse: sparse: incorrect ty= pe in argument 1 (different address spaces) @@ expected struct event_fi= lter *filter @@ got struct event_filter [noderef] __rcu *filter @@ kernel/trace/trace_events_filter.c:1153:27: sparse: expected struct = event_filter *filter kernel/trace/trace_events_filter.c:1153:27: sparse: got struct event= _filter [noderef] __rcu *filter kernel/trace/trace_events_filter.c:1066:20: sparse: sparse: incorrect ty= pe in return expression (different address spaces) @@ expected struct e= vent_filter * @@ got struct event_filter [noderef] __rcu *filter @@ kernel/trace/trace_events_filter.c:1066:20: sparse: expected struct = event_filter * kernel/trace/trace_events_filter.c:1066:20: sparse: got struct event= _filter [noderef] __rcu *filter kernel/trace/trace_events_filter.c:1066:20: sparse: sparse: incorrect ty= pe in return expression (different address spaces) @@ expected struct e= vent_filter * @@ got struct event_filter [noderef] __rcu *filter @@ kernel/trace/trace_events_filter.c:1066:20: sparse: expected struct = event_filter * kernel/trace/trace_events_filter.c:1066:20: sparse: got struct event= _filter [noderef] __rcu *filter kernel/trace/trace_events_filter.c:1066:20: sparse: sparse: incorrect ty= pe in return expression (different address spaces) @@ expected struct e= vent_filter * @@ got struct event_filter [noderef] __rcu *filter @@ kernel/trace/trace_events_filter.c:1066:20: sparse: expected struct = event_filter * kernel/trace/trace_events_filter.c:1066:20: sparse: got struct event= _filter [noderef] __rcu *filter vim +685 kernel/trace/trace_events_filter.c 666 = 667 static __always_inline char *test_string(char *str) 668 { 669 struct ustring_buffer *ubuf; 670 char __user *ustr; 671 char *kstr; 672 = 673 if (!ustring_per_cpu) 674 return NULL; 675 = 676 ubuf =3D this_cpu_ptr(ustring_per_cpu); 677 kstr =3D ubuf->buffer; 678 = 679 if (likely((unsigned long)str >=3D TASK_SIZE)) { 680 /* For safety, do not trust the string pointer */ 681 if (!strncpy_from_kernel_nofault(kstr, str, USTRING_BUF_SIZE)) 682 return NULL; 683 } else { 684 /* user space address? */ > 685 ustr =3D str; 686 if (!strncpy_from_user_nofault(kstr, ustr, USTRING_BUF_SIZE)) 687 return NULL; 688 } 689 return kstr; 690 } 691 = --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org --===============4719281908062693041==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 350BFC433FE for ; Sat, 8 Jan 2022 19:05:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2C81A6B0093; Sat, 8 Jan 2022 14:05:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2763D6B0096; Sat, 8 Jan 2022 14:05:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 13D926B0098; Sat, 8 Jan 2022 14:05:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0254.hostedemail.com [216.40.44.254]) by kanga.kvack.org (Postfix) with ESMTP id 049BD6B0093 for ; Sat, 8 Jan 2022 14:05:12 -0500 (EST) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id A4DE61823DA9F for ; Sat, 8 Jan 2022 19:05:11 +0000 (UTC) X-FDA: 79008047622.16.9F6F785 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by imf05.hostedemail.com (Postfix) with ESMTP id A7819100012 for ; Sat, 8 Jan 2022 19:05:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1641668710; x=1673204710; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=K4X8Y8f1pY3S0dmZw5XiasYMbgEQb1XWFb9uzokkf2E=; b=mDGHJhNadqXlh3JGPM4skIqe21A/UieXpXLR5C9r/+eyBQQYZLj/aUkc xp6k9mLfZkmFgpuIOW39IEYfZh2/FZWw2M/TBfIcL6iPJwQkTsAoZPfhd nArQ6BtFsLAKxZjZlues6NaUYa8WzxWQetJefcwmTAlr/zzqj+oRQtBgc nvxX0bIKRQ0+J8JfwkBXQcKwtpynudfUdTGs4rPGti1XlebHaHKVr/Y16 /dUVSo9zGa1V/s+jhmZwFNOE3HIPmM/SC25WlJgScR4Lw1yDp0JN3ZQHp tK7gbn2laQ5NcBhh622hvrn1Z/35+M5PnAqifDWlM92pyKsRv6+ub1139 g==; X-IronPort-AV: E=McAfee;i="6200,9189,10221"; a="241847225" X-IronPort-AV: E=Sophos;i="5.88,273,1635231600"; d="scan'208";a="241847225" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jan 2022 11:05:09 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,273,1635231600"; d="scan'208";a="690141548" Received: from lkp-server01.sh.intel.com (HELO 276f1b88eecb) ([10.239.97.150]) by orsmga005.jf.intel.com with ESMTP; 08 Jan 2022 11:05:06 -0800 Received: from kbuild by 276f1b88eecb with local (Exim 4.92) (envelope-from ) id 1n6H1V-0000wc-QO; Sat, 08 Jan 2022 19:05:05 +0000 Date: Sun, 9 Jan 2022 03:04:51 +0800 From: kernel test robot To: Steven Rostedt , linux-kernel@vger.kernel.org Cc: kbuild-all@lists.01.org, Ingo Molnar , Andrew Morton , Linux Memory Management List , Masami Hiramatsu , Tom Zanussi , stable@vger.kernel.org, Pingfan Liu Subject: Re: [PATCH 2/2] tracing: Add test for user space strings when filtering on string pointers Message-ID: <202201090343.IKIQqdk4-lkp@intel.com> References: <20220107225840.003487216@goodmis.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220107225840.003487216@goodmis.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: A7819100012 X-Stat-Signature: qe6gbd8akd8dh8ezxk5p4s3j7p5ar8cq Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=mDGHJhNa; spf=none (imf05.hostedemail.com: domain of lkp@intel.com has no SPF policy when checking 192.55.52.120) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com X-HE-Tag: 1641668710-731028 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Steven, I love your patch! Perhaps something to improve: [auto build test WARNING on rostedt-trace/for-next] [also build test WARNING on linux/master linus/master hnaz-mm/master v5.16-rc8 next-20220107] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Steven-Rostedt/tracing-Fix-filtering-on-string-pointers/20220108-070047 base: https://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git for-next config: openrisc-randconfig-s031-20220107 (https://download.01.org/0day-ci/archive/20220109/202201090343.IKIQqdk4-lkp@intel.com/config) compiler: or1k-linux-gcc (GCC) 11.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # apt-get install sparse # sparse version: v0.6.4-dirty # https://github.com/0day-ci/linux/commit/19b8c1c0fee0d7bff07ed0d5862a29ac2bb4adc9 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Steven-Rostedt/tracing-Fix-filtering-on-string-pointers/20220108-070047 git checkout 19b8c1c0fee0d7bff07ed0d5862a29ac2bb4adc9 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=openrisc SHELL=/bin/bash kernel/trace/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot sparse warnings: (new ones prefixed by >>) >> kernel/trace/trace_events_filter.c:685:22: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected char [noderef] __user *ustr @@ got char *str @@ kernel/trace/trace_events_filter.c:685:22: sparse: expected char [noderef] __user *ustr kernel/trace/trace_events_filter.c:685:22: sparse: got char *str >> kernel/trace/trace_events_filter.c:685:22: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected char [noderef] __user *ustr @@ got char *str @@ kernel/trace/trace_events_filter.c:685:22: sparse: expected char [noderef] __user *ustr kernel/trace/trace_events_filter.c:685:22: sparse: got char *str >> kernel/trace/trace_events_filter.c:685:22: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected char [noderef] __user *ustr @@ got char *str @@ kernel/trace/trace_events_filter.c:685:22: sparse: expected char [noderef] __user *ustr kernel/trace/trace_events_filter.c:685:22: sparse: got char *str >> kernel/trace/trace_events_filter.c:685:22: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected char [noderef] __user *ustr @@ got char *str @@ kernel/trace/trace_events_filter.c:685:22: sparse: expected char [noderef] __user *ustr kernel/trace/trace_events_filter.c:685:22: sparse: got char *str >> kernel/trace/trace_events_filter.c:685:22: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected char [noderef] __user *ustr @@ got char *str @@ kernel/trace/trace_events_filter.c:685:22: sparse: expected char [noderef] __user *ustr kernel/trace/trace_events_filter.c:685:22: sparse: got char *str >> kernel/trace/trace_events_filter.c:685:22: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected char [noderef] __user *ustr @@ got char *str @@ kernel/trace/trace_events_filter.c:685:22: sparse: expected char [noderef] __user *ustr kernel/trace/trace_events_filter.c:685:22: sparse: got char *str >> kernel/trace/trace_events_filter.c:685:22: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected char [noderef] __user *ustr @@ got char *str @@ kernel/trace/trace_events_filter.c:685:22: sparse: expected char [noderef] __user *ustr kernel/trace/trace_events_filter.c:685:22: sparse: got char *str kernel/trace/trace_events_filter.c:1066:20: sparse: sparse: incorrect type in return expression (different address spaces) @@ expected struct event_filter * @@ got struct event_filter [noderef] __rcu *filter @@ kernel/trace/trace_events_filter.c:1066:20: sparse: expected struct event_filter * kernel/trace/trace_events_filter.c:1066:20: sparse: got struct event_filter [noderef] __rcu *filter kernel/trace/trace_events_filter.c:1136:34: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct event_filter *filter @@ got struct event_filter [noderef] __rcu *filter @@ kernel/trace/trace_events_filter.c:1136:34: sparse: expected struct event_filter *filter kernel/trace/trace_events_filter.c:1136:34: sparse: got struct event_filter [noderef] __rcu *filter kernel/trace/trace_events_filter.c:1153:27: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct event_filter *filter @@ got struct event_filter [noderef] __rcu *filter @@ kernel/trace/trace_events_filter.c:1153:27: sparse: expected struct event_filter *filter kernel/trace/trace_events_filter.c:1153:27: sparse: got struct event_filter [noderef] __rcu *filter kernel/trace/trace_events_filter.c:1066:20: sparse: sparse: incorrect type in return expression (different address spaces) @@ expected struct event_filter * @@ got struct event_filter [noderef] __rcu *filter @@ kernel/trace/trace_events_filter.c:1066:20: sparse: expected struct event_filter * kernel/trace/trace_events_filter.c:1066:20: sparse: got struct event_filter [noderef] __rcu *filter kernel/trace/trace_events_filter.c:1066:20: sparse: sparse: incorrect type in return expression (different address spaces) @@ expected struct event_filter * @@ got struct event_filter [noderef] __rcu *filter @@ kernel/trace/trace_events_filter.c:1066:20: sparse: expected struct event_filter * kernel/trace/trace_events_filter.c:1066:20: sparse: got struct event_filter [noderef] __rcu *filter kernel/trace/trace_events_filter.c:1066:20: sparse: sparse: incorrect type in return expression (different address spaces) @@ expected struct event_filter * @@ got struct event_filter [noderef] __rcu *filter @@ kernel/trace/trace_events_filter.c:1066:20: sparse: expected struct event_filter * kernel/trace/trace_events_filter.c:1066:20: sparse: got struct event_filter [noderef] __rcu *filter vim +685 kernel/trace/trace_events_filter.c 666 667 static __always_inline char *test_string(char *str) 668 { 669 struct ustring_buffer *ubuf; 670 char __user *ustr; 671 char *kstr; 672 673 if (!ustring_per_cpu) 674 return NULL; 675 676 ubuf = this_cpu_ptr(ustring_per_cpu); 677 kstr = ubuf->buffer; 678 679 if (likely((unsigned long)str >= TASK_SIZE)) { 680 /* For safety, do not trust the string pointer */ 681 if (!strncpy_from_kernel_nofault(kstr, str, USTRING_BUF_SIZE)) 682 return NULL; 683 } else { 684 /* user space address? */ > 685 ustr = str; 686 if (!strncpy_from_user_nofault(kstr, ustr, USTRING_BUF_SIZE)) 687 return NULL; 688 } 689 return kstr; 690 } 691 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org