From: Herve Codina <herve.codina@bootlin.com>
To: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Louis-Paul CORDIER <lpdev@cordier.org>,
Adam Duskett <aduskett@gmail.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Andreas Naumann <anaumann@ultratronik.de>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 2/3] core/pkg-generic: fixup all PPD paths in a generic fashion
Date: Sun, 9 Jan 2022 13:14:22 +0100 [thread overview]
Message-ID: <20220109131422.4f774dfd@bootlin.com> (raw)
In-Reply-To: <91348c3073b0dcf57a8ea3227bae74c23a122713.1641663315.git.yann.morin.1998@free.fr>
On Sat, 8 Jan 2022 18:35:41 +0100
"Yann E. MORIN" <yann.morin.1998@free.fr> wrote:
> Some files contain hard-coded absolute paths that point to the host
> and/or staging directories.
>
> With per-package directories (aka. PPD), these paths point to the PPD
> of the package that created the files, when we want them to point to the
> PPD of the package that uses them.
>
> Up until now, we had two hooks that attempted to fix those files:
>
> - a libtool-specific hook that searches for all .la files and seds
> them with the proper PPD,
>
> - a python-specific hook that tweaks just the sysconfigdata and
> removes the byte-compiled version of the sysconfigdata.
>
> But now, we also have a few other kinds of files for which we need to
> fix the PPD: .cmake, .pc, or .pri files, and probably a bunch of others
> as well.
>
> We solve this issue by just replacing any PPD in text files, with the
> current package's PPD.
>
> This is very similar to, and inspired from what is done when relocating
> the SDK. However, we can't use the existing relocate-sdk script, because
> that needs to know the original location, which we do not have when we
> aggregate the PPD (we could store it, but we can easily do without it).
>
> Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
> Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> Cc: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> Cc: Adam Duskett <aduskett@gmail.com>
> Cc: Louis-Paul CORDIER <lpdev@cordier.org>
> Cc: Andreas Naumann <anaumann@ultratronik.de>
> ---
> package/pkg-generic.mk | 43 +++++++++++++++++++++---------------------
> 1 file changed, 21 insertions(+), 22 deletions(-)
>
[...]
Acked-by: Herve Codina <herve.codina@bootlin.com>
Best regards,
Hervé
--
Hervé Codina, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-01-09 12:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-08 17:35 [Buildroot] [PATCH 0/3] core: fixup PPD paths (branch yem/ppd-fixup-paths) Yann E. MORIN
2022-01-08 17:35 ` [Buildroot] [PATCH 1/3] core/pkg-utils: properly indent per-package-rsync Yann E. MORIN
2022-01-08 17:52 ` Peter Korsgaard
2022-01-08 17:35 ` [Buildroot] [PATCH 2/3] core/pkg-generic: fixup all PPD paths in a generic fashion Yann E. MORIN
2022-01-09 12:14 ` Herve Codina [this message]
2022-01-12 20:42 ` Arnout Vandecappelle
2022-01-13 21:58 ` Yann E. MORIN
2022-01-22 10:50 ` Yann E. MORIN
2022-01-08 17:35 ` [Buildroot] [PATCH 3/3] core/pkg-generic: apply post-prepare hooks before monitoring directories Yann E. MORIN
2022-01-09 12:11 ` Herve Codina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220109131422.4f774dfd@bootlin.com \
--to=herve.codina@bootlin.com \
--cc=aduskett@gmail.com \
--cc=anaumann@ultratronik.de \
--cc=buildroot@buildroot.org \
--cc=lpdev@cordier.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.