diff for duplicates of <202201091544.W5HHEXAp-lkp@intel.com> diff --git a/a/1.txt b/N1/1.txt index 4dd499f..c621234 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,8 +1,30 @@ +CC: kbuild-all(a)lists.01.org +In-Reply-To: <20220107121215.1912-2-yinxin.x@bytedance.com> +References: <20220107121215.1912-2-yinxin.x@bytedance.com> +TO: Xin Yin <yinxin.x@bytedance.com> +TO: harshadshirwadkar(a)gmail.com +TO: tytso(a)mit.edu +TO: adilger.kernel(a)dilger.ca +CC: linux-ext4(a)vger.kernel.org +CC: linux-kernel(a)vger.kernel.org +CC: Xin Yin <yinxin.x@bytedance.com> + Hi Xin, +Thank you for the patch! Perhaps something to improve: + +[auto build test WARNING on tytso-ext4/dev] +[also build test WARNING on next-20220107] +[cannot apply to linus/master v5.16-rc8] +[If your patch is applied to the wrong git tree, kindly drop us a note. +And when submitting patch, we suggest to use '--base' as documented in +https://git-scm.com/docs/git-format-patch] + url: https://github.com/0day-ci/linux/commits/Xin-Yin/ext4-fix-issues-when-fast-commit-work-with-jbd/20220107-201314 base: https://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git dev -config: x86_64-randconfig-m001-20220107 (https://download.01.org/0day-ci/archive/20220109/202201091544.W5HHEXAp-lkp@intel.com/config) +:::::: branch date: 2 days ago +:::::: commit date: 2 days ago +config: x86_64-randconfig-m001-20220107 (https://download.01.org/0day-ci/archive/20220109/202201091544.W5HHEXAp-lkp(a)intel.com/config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 If you fix the issue, kindly add following tag as appropriate @@ -12,8 +34,22 @@ Reported-by: Dan Carpenter <dan.carpenter@oracle.com> New smatch warnings: fs/ext4/inode.c:340 ext4_evict_inode() error: uninitialized symbol 'handle'. +Old smatch warnings: +fs/ext4/inode.c:380 ext4_da_update_reserve_space() warn: should 'used << sbi->s_cluster_bits' be a 64 bit type? +fs/ext4/inode.c:387 ext4_da_update_reserve_space() warn: should 'used << sbi->s_cluster_bits' be a 64 bit type? +fs/ext4/inode.c:1469 ext4_da_reserve_space() warn: should '(1) << sbi->s_cluster_bits' be a 64 bit type? +fs/ext4/inode.c:1476 ext4_da_reserve_space() warn: should '(1) << sbi->s_cluster_bits' be a 64 bit type? +fs/ext4/inode.c:1518 ext4_da_release_space() warn: should 'to_free << sbi->s_cluster_bits' be a 64 bit type? +fs/ext4/inode.c:2571 mpage_prepare_extent_to_map() warn: missing error code 'err' +fs/ext4/inode.c:5550 ext4_file_getattr() warn: should '(()->i_reserved_data_blocks) << (EXT4_SB(inode->i_sb))->s_cluster_bits' be a 64 bit type? +fs/ext4/inode.c:6090 ext4_page_mkwrite() error: uninitialized symbol 'get_block'. + vim +/handle +340 fs/ext4/inode.c +ac27a0ec112a08 Dave Kleikamp 2006-10-11 163 +ac27a0ec112a08 Dave Kleikamp 2006-10-11 164 /* +ac27a0ec112a08 Dave Kleikamp 2006-10-11 165 * Called at the last iput() if i_nlink is zero. +ac27a0ec112a08 Dave Kleikamp 2006-10-11 166 */ 0930fcc1ee2f0a Al Viro 2010-06-07 167 void ext4_evict_inode(struct inode *inode) ac27a0ec112a08 Dave Kleikamp 2006-10-11 168 { ac27a0ec112a08 Dave Kleikamp 2006-10-11 169 handle_t *handle; @@ -61,9 +97,6 @@ d76a3a77113db0 Theodore Ts'o 2013-04-03 208 jbd2_complete_transaction( 91b0abe36a7b2b Johannes Weiner 2014-04-03 211 truncate_inode_pages_final(&inode->i_data); 5dc23bdd5f846e Jan Kara 2013-06-04 212 0930fcc1ee2f0a Al Viro 2010-06-07 213 goto no_delete; - -Assume we hit this goto - 0930fcc1ee2f0a Al Viro 2010-06-07 214 } 0930fcc1ee2f0a Al Viro 2010-06-07 215 e2bfb088fac03c Theodore Ts'o 2014-10-05 216 if (is_bad_inode(inode)) @@ -190,17 +223,11 @@ ac27a0ec112a08 Dave Kleikamp 2006-10-11 331 else ac27a0ec112a08 Dave Kleikamp 2006-10-11 337 return; ac27a0ec112a08 Dave Kleikamp 2006-10-11 338 no_delete: b21ebf143af219 Harshad Shirwadkar 2020-11-05 339 if (!list_empty(&EXT4_I(inode)->i_fc_list)) - -It's not clear without more context where this ->i_fc_list list is -modified. - db40129f85538a Xin Yin 2022-01-07 @340 ext4_fc_mark_ineligible(inode->i_sb, EXT4_FC_REASON_NOMEM, handle); - -"handle" might be uninitialized? - 0930fcc1ee2f0a Al Viro 2010-06-07 341 ext4_clear_inode(inode); /* We must guarantee clearing of inode... */ 9d0be50230b333 Theodore Ts'o 2010-01-01 342 } +ac27a0ec112a08 Dave Kleikamp 2006-10-11 343 --- 0-DAY CI Kernel Test Service, Intel Corporation -https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org +https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org diff --git a/a/content_digest b/N1/content_digest index 0cf38e6..fb35f4d 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,24 +1,36 @@ - "ref\020220107121215.1912-2-yinxin.x@bytedance.com\0" - "From\0Dan Carpenter <dan.carpenter@oracle.com>\0" + "From\0kernel test robot <lkp@intel.com>\0" "Subject\0Re: [PATCH 1/2] ext4: fast commit may not fallback for ineligible commit\0" - "Date\0Mon, 10 Jan 2022 12:23:13 +0300\0" - "To\0kbuild@lists.01.org" - Xin Yin <yinxin.x@bytedance.com> - harshadshirwadkar@gmail.com - tytso@mit.edu - " adilger.kernel@dilger.ca\0" - "Cc\0lkp@intel.com" - kbuild-all@lists.01.org - linux-ext4@vger.kernel.org - linux-kernel@vger.kernel.org - " Xin Yin <yinxin.x@bytedance.com>\0" - "\00:1\0" + "Date\0Sun, 09 Jan 2022 15:41:08 +0800\0" + "To\0kbuild@lists.01.org\0" + "\01:1\0" "b\0" + "CC: kbuild-all(a)lists.01.org\n" + "In-Reply-To: <20220107121215.1912-2-yinxin.x@bytedance.com>\n" + "References: <20220107121215.1912-2-yinxin.x@bytedance.com>\n" + "TO: Xin Yin <yinxin.x@bytedance.com>\n" + "TO: harshadshirwadkar(a)gmail.com\n" + "TO: tytso(a)mit.edu\n" + "TO: adilger.kernel(a)dilger.ca\n" + "CC: linux-ext4(a)vger.kernel.org\n" + "CC: linux-kernel(a)vger.kernel.org\n" + "CC: Xin Yin <yinxin.x@bytedance.com>\n" + "\n" "Hi Xin,\n" "\n" + "Thank you for the patch! Perhaps something to improve:\n" + "\n" + "[auto build test WARNING on tytso-ext4/dev]\n" + "[also build test WARNING on next-20220107]\n" + "[cannot apply to linus/master v5.16-rc8]\n" + "[If your patch is applied to the wrong git tree, kindly drop us a note.\n" + "And when submitting patch, we suggest to use '--base' as documented in\n" + "https://git-scm.com/docs/git-format-patch]\n" + "\n" "url: https://github.com/0day-ci/linux/commits/Xin-Yin/ext4-fix-issues-when-fast-commit-work-with-jbd/20220107-201314\n" "base: https://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git dev\n" - "config: x86_64-randconfig-m001-20220107 (https://download.01.org/0day-ci/archive/20220109/202201091544.W5HHEXAp-lkp@intel.com/config)\n" + ":::::: branch date: 2 days ago\n" + ":::::: commit date: 2 days ago\n" + "config: x86_64-randconfig-m001-20220107 (https://download.01.org/0day-ci/archive/20220109/202201091544.W5HHEXAp-lkp(a)intel.com/config)\n" "compiler: gcc-9 (Debian 9.3.0-22) 9.3.0\n" "\n" "If you fix the issue, kindly add following tag as appropriate\n" @@ -28,8 +40,22 @@ "New smatch warnings:\n" "fs/ext4/inode.c:340 ext4_evict_inode() error: uninitialized symbol 'handle'.\n" "\n" + "Old smatch warnings:\n" + "fs/ext4/inode.c:380 ext4_da_update_reserve_space() warn: should 'used << sbi->s_cluster_bits' be a 64 bit type?\n" + "fs/ext4/inode.c:387 ext4_da_update_reserve_space() warn: should 'used << sbi->s_cluster_bits' be a 64 bit type?\n" + "fs/ext4/inode.c:1469 ext4_da_reserve_space() warn: should '(1) << sbi->s_cluster_bits' be a 64 bit type?\n" + "fs/ext4/inode.c:1476 ext4_da_reserve_space() warn: should '(1) << sbi->s_cluster_bits' be a 64 bit type?\n" + "fs/ext4/inode.c:1518 ext4_da_release_space() warn: should 'to_free << sbi->s_cluster_bits' be a 64 bit type?\n" + "fs/ext4/inode.c:2571 mpage_prepare_extent_to_map() warn: missing error code 'err'\n" + "fs/ext4/inode.c:5550 ext4_file_getattr() warn: should '(()->i_reserved_data_blocks) << (EXT4_SB(inode->i_sb))->s_cluster_bits' be a 64 bit type?\n" + "fs/ext4/inode.c:6090 ext4_page_mkwrite() error: uninitialized symbol 'get_block'.\n" + "\n" "vim +/handle +340 fs/ext4/inode.c\n" "\n" + "ac27a0ec112a08 Dave Kleikamp 2006-10-11 163 \n" + "ac27a0ec112a08 Dave Kleikamp 2006-10-11 164 /*\n" + "ac27a0ec112a08 Dave Kleikamp 2006-10-11 165 * Called at the last iput() if i_nlink is zero.\n" + "ac27a0ec112a08 Dave Kleikamp 2006-10-11 166 */\n" "0930fcc1ee2f0a Al Viro 2010-06-07 167 void ext4_evict_inode(struct inode *inode)\n" "ac27a0ec112a08 Dave Kleikamp 2006-10-11 168 {\n" "ac27a0ec112a08 Dave Kleikamp 2006-10-11 169 \thandle_t *handle;\n" @@ -77,9 +103,6 @@ "91b0abe36a7b2b Johannes Weiner 2014-04-03 211 \t\ttruncate_inode_pages_final(&inode->i_data);\n" "5dc23bdd5f846e Jan Kara 2013-06-04 212 \n" "0930fcc1ee2f0a Al Viro 2010-06-07 213 \t\tgoto no_delete;\n" - "\n" - "Assume we hit this goto\n" - "\n" "0930fcc1ee2f0a Al Viro 2010-06-07 214 \t}\n" "0930fcc1ee2f0a Al Viro 2010-06-07 215 \n" "e2bfb088fac03c Theodore Ts'o 2014-10-05 216 \tif (is_bad_inode(inode))\n" @@ -206,19 +229,13 @@ "ac27a0ec112a08 Dave Kleikamp 2006-10-11 337 \treturn;\n" "ac27a0ec112a08 Dave Kleikamp 2006-10-11 338 no_delete:\n" "b21ebf143af219 Harshad Shirwadkar 2020-11-05 339 \tif (!list_empty(&EXT4_I(inode)->i_fc_list))\n" - "\n" - "It's not clear without more context where this ->i_fc_list list is\n" - "modified.\n" - "\n" "db40129f85538a Xin Yin 2022-01-07 @340 \t\text4_fc_mark_ineligible(inode->i_sb, EXT4_FC_REASON_NOMEM, handle);\n" - "\n" - "\"handle\" might be uninitialized?\n" - "\n" "0930fcc1ee2f0a Al Viro 2010-06-07 341 \text4_clear_inode(inode);\t/* We must guarantee clearing of inode... */\n" "9d0be50230b333 Theodore Ts'o 2010-01-01 342 }\n" + "ac27a0ec112a08 Dave Kleikamp 2006-10-11 343 \n" "\n" "---\n" "0-DAY CI Kernel Test Service, Intel Corporation\n" - https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org + https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org -687195c273c04672fa158ae28b267f6f98432facffb612c727b1e92ce6b6070a +f2acbe55ef3929beef3bae6413c14c8dd41d6b02a323528921825a75dfc7bbe0
diff --git a/a/1.txt b/N2/1.txt index 4dd499f..0b4264f 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -2,7 +2,7 @@ Hi Xin, url: https://github.com/0day-ci/linux/commits/Xin-Yin/ext4-fix-issues-when-fast-commit-work-with-jbd/20220107-201314 base: https://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git dev -config: x86_64-randconfig-m001-20220107 (https://download.01.org/0day-ci/archive/20220109/202201091544.W5HHEXAp-lkp@intel.com/config) +config: x86_64-randconfig-m001-20220107 (https://download.01.org/0day-ci/archive/20220109/202201091544.W5HHEXAp-lkp(a)intel.com/config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 If you fix the issue, kindly add following tag as appropriate @@ -203,4 +203,4 @@ db40129f85538a Xin Yin 2022-01-07 @340 ext4_fc_mark_ineligible(ino --- 0-DAY CI Kernel Test Service, Intel Corporation -https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org +https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org diff --git a/a/content_digest b/N2/content_digest index 0cf38e6..ccf81e3 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -2,23 +2,14 @@ "From\0Dan Carpenter <dan.carpenter@oracle.com>\0" "Subject\0Re: [PATCH 1/2] ext4: fast commit may not fallback for ineligible commit\0" "Date\0Mon, 10 Jan 2022 12:23:13 +0300\0" - "To\0kbuild@lists.01.org" - Xin Yin <yinxin.x@bytedance.com> - harshadshirwadkar@gmail.com - tytso@mit.edu - " adilger.kernel@dilger.ca\0" - "Cc\0lkp@intel.com" - kbuild-all@lists.01.org - linux-ext4@vger.kernel.org - linux-kernel@vger.kernel.org - " Xin Yin <yinxin.x@bytedance.com>\0" - "\00:1\0" + "To\0kbuild-all@lists.01.org\0" + "\01:1\0" "b\0" "Hi Xin,\n" "\n" "url: https://github.com/0day-ci/linux/commits/Xin-Yin/ext4-fix-issues-when-fast-commit-work-with-jbd/20220107-201314\n" "base: https://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git dev\n" - "config: x86_64-randconfig-m001-20220107 (https://download.01.org/0day-ci/archive/20220109/202201091544.W5HHEXAp-lkp@intel.com/config)\n" + "config: x86_64-randconfig-m001-20220107 (https://download.01.org/0day-ci/archive/20220109/202201091544.W5HHEXAp-lkp(a)intel.com/config)\n" "compiler: gcc-9 (Debian 9.3.0-22) 9.3.0\n" "\n" "If you fix the issue, kindly add following tag as appropriate\n" @@ -219,6 +210,6 @@ "\n" "---\n" "0-DAY CI Kernel Test Service, Intel Corporation\n" - https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org + https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org -687195c273c04672fa158ae28b267f6f98432facffb612c727b1e92ce6b6070a +07405197f302c0f2f615c1ce302bc115de1cf5b3c1499c61dd7097923d2596dd
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.