From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28F92C433FE for ; Mon, 10 Jan 2022 01:51:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238005AbiAJBvC (ORCPT ); Sun, 9 Jan 2022 20:51:02 -0500 Received: from dfw.source.kernel.org ([139.178.84.217]:59508 "EHLO dfw.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238009AbiAJBu5 (ORCPT ); Sun, 9 Jan 2022 20:50:57 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6B74160F4A for ; Mon, 10 Jan 2022 01:50:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 28CD0C36AF5; Mon, 10 Jan 2022 01:50:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1641779456; bh=dTXgpWiybwA/hCGFY5arTv+LKbZ+aZewd6YanDfyWEI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bria5oNNYw5PUQKTKUWUEvjvkv3ubiXrESFz7qIK9VEDpA45nOT1Ch10pR+PEHuy/ tTU2J8Kr9EEx4tTkUp7VDzC0Q96m9va8X3PJkOPnLtwB7JQAp5BLtFTPoCFwBF7fcC IadTwCro5Ll6RmV94Qr/sc6Mgtl7teyfqrmoq+pOW0Qtqsoi/9wbg73qmXufI/PqPy HSIHn2q7Z7fokq2I1VMZ36GxyA+RKJ+czveNtyGkishYdlRkdZ1Ex05BdQL6gwo55b DmcYWzNXb1SojJBIfEx7JzT/30mkAMRkGpM4c0CsOul6wthh1W8pqvu9k/gWwOXuUo cuRkCOxp05Q2A== From: =?UTF-8?q?Marek=20Beh=C3=BAn?= To: Marc Zyngier , Lorenzo Pieralisi , Bjorn Helgaas Cc: pali@kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, =?UTF-8?q?Marek=20Beh=C3=BAn?= Subject: [PATCH v2 16/23] PCI: aardvark: Add support for PME interrupts Date: Mon, 10 Jan 2022 02:50:11 +0100 Message-Id: <20220110015018.26359-17-kabel@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220110015018.26359-1-kabel@kernel.org> References: <20220110015018.26359-1-kabel@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org From: Pali Rohár Currently enabling PCI_EXP_RTSTA_PME bit in PCI_EXP_RTCTL register does nothing. This is because PCIe PME driver expects to receive PCIe interrupt defined in PCI_EXP_FLAGS_IRQ register, but aardvark hardware does not trigger PCIe INTx/MSI interrupt for PME event, rather it triggers custom aardvark interrupt which this driver is not processing yet. Fix this issue by handling PME interrupt in advk_pcie_handle_int() and chaining it to PCIe interrupt 0 with generic_handle_domain_irq() (since aardvark sets PCI_EXP_FLAGS_IRQ to zero). With this change PCIe PME driver finally starts receiving PME interrupt. Signed-off-by: Pali Rohár Signed-off-by: Marek Behún --- drivers/pci/controller/pci-aardvark.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/drivers/pci/controller/pci-aardvark.c b/drivers/pci/controller/pci-aardvark.c index e7b9ca31c79c..3f2d570bfbb5 100644 --- a/drivers/pci/controller/pci-aardvark.c +++ b/drivers/pci/controller/pci-aardvark.c @@ -1487,6 +1487,18 @@ static void advk_pcie_handle_int(struct advk_pcie *pcie) isr1_mask = advk_readl(pcie, PCIE_ISR1_MASK_REG); isr1_status = isr1_val & ((~isr1_mask) & PCIE_ISR1_ALL_MASK); + /* Process PME interrupt */ + if (isr0_status & PCIE_MSG_PM_PME_MASK) { + /* + * Do not clear PME interrupt bit in ISR0, it is cleared by IRQ + * receiver by writing to the PCI_EXP_RTSTA register of emulated + * root bridge. Aardvark HW returns zero for PCI_EXP_FLAGS_IRQ, + * so use PCIe interrupt 0. + */ + if (generic_handle_domain_irq(pcie->irq_domain, 0) == -EINVAL) + dev_err_ratelimited(&pcie->pdev->dev, "unhandled PME IRQ\n"); + } + /* Process ERR interrupt */ if (isr0_status & PCIE_ISR0_ERR_MASK) { advk_writel(pcie, PCIE_ISR0_ERR_MASK, PCIE_ISR0_REG); -- 2.34.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B7FADC433F5 for ; Mon, 10 Jan 2022 01:59:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=oV5qKzJ7zI5GEQdCzYbznPtgUlgeOYBZkE3NVR0gs/Y=; b=R6VDI4rt0evTDE LJvrbemMfobyGOjSHuA+Ybqbg+MfC7uZV22/HpOBvjdxO8IzyZw7/ezp0JtA9XqhACNnqumWmnmP1 sy0KJYItY5GDX7OD32XGkepxozOMugd0mZPYFKrH/Hh6I5P5RiK2voTDKUej6H5Sogj8kR51iyapO 0dSuxvG2kaT9o8dzFJYJSdJHuBBnb8Vx+G/YkYfP3qlV6eJktTqgvMdLS8QaZ1T7cXe8UMtUlKp+r esGIRyc9rjI9lZG01515WYnid0+wPDdeUzBX82BsCOVKb0aytBXAYhtfHQZHXtaZilpiudZRfwSZv J2CIX9u/xHgidFhpZtuw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n6jwd-008pwS-8M; Mon, 10 Jan 2022 01:57:59 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n6jpp-008llh-Uh for linux-arm-kernel@lists.infradead.org; Mon, 10 Jan 2022 01:50:59 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7D93760F61; Mon, 10 Jan 2022 01:50:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 28CD0C36AF5; Mon, 10 Jan 2022 01:50:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1641779456; bh=dTXgpWiybwA/hCGFY5arTv+LKbZ+aZewd6YanDfyWEI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bria5oNNYw5PUQKTKUWUEvjvkv3ubiXrESFz7qIK9VEDpA45nOT1Ch10pR+PEHuy/ tTU2J8Kr9EEx4tTkUp7VDzC0Q96m9va8X3PJkOPnLtwB7JQAp5BLtFTPoCFwBF7fcC IadTwCro5Ll6RmV94Qr/sc6Mgtl7teyfqrmoq+pOW0Qtqsoi/9wbg73qmXufI/PqPy HSIHn2q7Z7fokq2I1VMZ36GxyA+RKJ+czveNtyGkishYdlRkdZ1Ex05BdQL6gwo55b DmcYWzNXb1SojJBIfEx7JzT/30mkAMRkGpM4c0CsOul6wthh1W8pqvu9k/gWwOXuUo cuRkCOxp05Q2A== From: =?UTF-8?q?Marek=20Beh=C3=BAn?= To: Marc Zyngier , Lorenzo Pieralisi , Bjorn Helgaas Cc: pali@kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, =?UTF-8?q?Marek=20Beh=C3=BAn?= Subject: [PATCH v2 16/23] PCI: aardvark: Add support for PME interrupts Date: Mon, 10 Jan 2022 02:50:11 +0100 Message-Id: <20220110015018.26359-17-kabel@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220110015018.26359-1-kabel@kernel.org> References: <20220110015018.26359-1-kabel@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220109_175058_101297_4394AC8C X-CRM114-Status: GOOD ( 13.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org RnJvbTogUGFsaSBSb2jDoXIgPHBhbGlAa2VybmVsLm9yZz4KCkN1cnJlbnRseSBlbmFibGluZyBQ Q0lfRVhQX1JUU1RBX1BNRSBiaXQgaW4gUENJX0VYUF9SVENUTCByZWdpc3RlciBkb2VzCm5vdGhp bmcuIFRoaXMgaXMgYmVjYXVzZSBQQ0llIFBNRSBkcml2ZXIgZXhwZWN0cyB0byByZWNlaXZlIFBD SWUgaW50ZXJydXB0CmRlZmluZWQgaW4gUENJX0VYUF9GTEFHU19JUlEgcmVnaXN0ZXIsIGJ1dCBh YXJkdmFyayBoYXJkd2FyZSBkb2VzIG5vdAp0cmlnZ2VyIFBDSWUgSU5UeC9NU0kgaW50ZXJydXB0 IGZvciBQTUUgZXZlbnQsIHJhdGhlciBpdCB0cmlnZ2VycyBjdXN0b20KYWFyZHZhcmsgaW50ZXJy dXB0IHdoaWNoIHRoaXMgZHJpdmVyIGlzIG5vdCBwcm9jZXNzaW5nIHlldC4KCkZpeCB0aGlzIGlz c3VlIGJ5IGhhbmRsaW5nIFBNRSBpbnRlcnJ1cHQgaW4gYWR2a19wY2llX2hhbmRsZV9pbnQoKSBh bmQKY2hhaW5pbmcgaXQgdG8gUENJZSBpbnRlcnJ1cHQgMCB3aXRoIGdlbmVyaWNfaGFuZGxlX2Rv bWFpbl9pcnEoKSAoc2luY2UKYWFyZHZhcmsgc2V0cyBQQ0lfRVhQX0ZMQUdTX0lSUSB0byB6ZXJv KS4gV2l0aCB0aGlzIGNoYW5nZSBQQ0llIFBNRSBkcml2ZXIKZmluYWxseSBzdGFydHMgcmVjZWl2 aW5nIFBNRSBpbnRlcnJ1cHQuCgpTaWduZWQtb2ZmLWJ5OiBQYWxpIFJvaMOhciA8cGFsaUBrZXJu ZWwub3JnPgpTaWduZWQtb2ZmLWJ5OiBNYXJlayBCZWjDum4gPGthYmVsQGtlcm5lbC5vcmc+Ci0t LQogZHJpdmVycy9wY2kvY29udHJvbGxlci9wY2ktYWFyZHZhcmsuYyB8IDEyICsrKysrKysrKysr KwogMSBmaWxlIGNoYW5nZWQsIDEyIGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9kcml2ZXJz L3BjaS9jb250cm9sbGVyL3BjaS1hYXJkdmFyay5jIGIvZHJpdmVycy9wY2kvY29udHJvbGxlci9w Y2ktYWFyZHZhcmsuYwppbmRleCBlN2I5Y2EzMWM3OWMuLjNmMmQ1NzBiZmJiNSAxMDA2NDQKLS0t IGEvZHJpdmVycy9wY2kvY29udHJvbGxlci9wY2ktYWFyZHZhcmsuYworKysgYi9kcml2ZXJzL3Bj aS9jb250cm9sbGVyL3BjaS1hYXJkdmFyay5jCkBAIC0xNDg3LDYgKzE0ODcsMTggQEAgc3RhdGlj IHZvaWQgYWR2a19wY2llX2hhbmRsZV9pbnQoc3RydWN0IGFkdmtfcGNpZSAqcGNpZSkKIAlpc3Ix X21hc2sgPSBhZHZrX3JlYWRsKHBjaWUsIFBDSUVfSVNSMV9NQVNLX1JFRyk7CiAJaXNyMV9zdGF0 dXMgPSBpc3IxX3ZhbCAmICgofmlzcjFfbWFzaykgJiBQQ0lFX0lTUjFfQUxMX01BU0spOwogCisJ LyogUHJvY2VzcyBQTUUgaW50ZXJydXB0ICovCisJaWYgKGlzcjBfc3RhdHVzICYgUENJRV9NU0df UE1fUE1FX01BU0spIHsKKwkJLyoKKwkJICogRG8gbm90IGNsZWFyIFBNRSBpbnRlcnJ1cHQgYml0 IGluIElTUjAsIGl0IGlzIGNsZWFyZWQgYnkgSVJRCisJCSAqIHJlY2VpdmVyIGJ5IHdyaXRpbmcg dG8gdGhlIFBDSV9FWFBfUlRTVEEgcmVnaXN0ZXIgb2YgZW11bGF0ZWQKKwkJICogcm9vdCBicmlk Z2UuIEFhcmR2YXJrIEhXIHJldHVybnMgemVybyBmb3IgUENJX0VYUF9GTEFHU19JUlEsCisJCSAq IHNvIHVzZSBQQ0llIGludGVycnVwdCAwLgorCQkgKi8KKwkJaWYgKGdlbmVyaWNfaGFuZGxlX2Rv bWFpbl9pcnEocGNpZS0+aXJxX2RvbWFpbiwgMCkgPT0gLUVJTlZBTCkKKwkJCWRldl9lcnJfcmF0 ZWxpbWl0ZWQoJnBjaWUtPnBkZXYtPmRldiwgInVuaGFuZGxlZCBQTUUgSVJRXG4iKTsKKwl9CisK IAkvKiBQcm9jZXNzIEVSUiBpbnRlcnJ1cHQgKi8KIAlpZiAoaXNyMF9zdGF0dXMgJiBQQ0lFX0lT UjBfRVJSX01BU0spIHsKIAkJYWR2a193cml0ZWwocGNpZSwgUENJRV9JU1IwX0VSUl9NQVNLLCBQ Q0lFX0lTUjBfUkVHKTsKLS0gCjIuMzQuMQoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFy bS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK