From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 311D8C433EF for ; Mon, 10 Jan 2022 10:23:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243898AbiAJKXQ (ORCPT ); Mon, 10 Jan 2022 05:23:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33592 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243887AbiAJKXH (ORCPT ); Mon, 10 Jan 2022 05:23:07 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 476D8C061751 for ; Mon, 10 Jan 2022 02:23:07 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DC9156124E for ; Mon, 10 Jan 2022 10:23:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 06698C36AE9; Mon, 10 Jan 2022 10:23:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1641810186; bh=52SGtoSXoHH5/gXeIjcW4u1oqUamKPxuDGP8DWpswyk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=oopgaGtWWTvJOJd+5cECRJ3DZFgE28a/xrvInrVxjiTY6Jm8KD6qL1YrLC+UL7qm/ vGO40nuIh6hWP8g9By3gWBpPReklOQvb8gXvphuXIWPN9lpkH8BZS73X0LDYZbMxck rj78pjD+DaeTotMA+dcv+Kr1O8xRbtoEyxmxv8SB0KHjfuDANyCFGZ99t3Irhwxh1Y DI1OVVEXPX8zAvawKGFf9Y5MCX1pCReDBH+7YBMSTR5qIYpZab7JhoD/841enEE3bU SiC9Vn0XD6HMsCFVO0iyMkeOwlVMZgNPPh/fo9Ck6fQ6GP4zS6LRAs1NnwMeKmhN/t GjdfIznbRQMSQ== Date: Mon, 10 Jan 2022 11:23:01 +0100 From: Marek =?UTF-8?B?QmVow7pu?= To: Marc Zyngier Cc: Lorenzo Pieralisi , Bjorn Helgaas , pali@kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 23/23] PCI: aardvark: Make main irq_chip structure a static driver structure Message-ID: <20220110112301.7e13c716@thinkpad> In-Reply-To: References: <20220110015018.26359-1-kabel@kernel.org> <20220110015018.26359-24-kabel@kernel.org> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Mon, 10 Jan 2022 09:28:39 +0000 Marc Zyngier wrote: > On 2022-01-10 01:50, Marek Beh=C3=BAn wrote: > > Marc Zyngier says [1] that we should use struct irq_chip as a global > > static struct in the driver. Even though the structure currently > > contains a dynamic member (parent_device), Marc says [2] that he plans > > to kill it and make the structure completely static. > >=20 > > We have already converted others irq_chip structures in this driver in > > this way, but we omitted this one because the .name member is > > dynamically created from device's name, and the name is displayed in > > sysfs, so changing it would break sysfs ABI. > >=20 > > The rationale for changing the name (to "advk-INT") in spite of sysfs > > ABI, and thus allowing to convert to a static structure, is that after > > the other changes we made in this series, the IRQ chip is basically > > something different: it no logner generates ERR and PME interrupts=20 > > (they > > are generated by emulated bridge's rp_irq_chip). =20 >=20 > There is no 'is spite of the ABI'. If you don't understand why > we don't break the ABI, you have an even bigger problem. >=20 > So NAK to this patch, now and forever. Any change to the structure to > make it read-only must allow the preservation of the existing names > when they are generated by the driver. Dear Marc, That's why I put it as a last patch here :) I have the questions 1) the first is that this driver has only ever been used on Armada 37xx, where there has always been only one PCIe controller, and it's name always was d0070000.pcie, so the irq_chip was always called d0070000.pcie-irq. So we could theoretically infer from config options if we are building for Armada 37xx: if ARM64 and ARMADA_37XX_CLK config options are enabled, make the name d0070000.pcie-irq, otherwise advk-INT ? 2) I tried to look for the name d0070000.pcie-irq in /proc and /sysfs, but couldn't find it there (not in /proc/interrupts nor anywhere else). It is possible that I omitted something, or that with other PCIe card it will show up when corresponding driver is loaded. But theoretically, if I could prove that until now this never appeared anywhere in sysfs for some reason, then we could change it, right? Becuase that way it isn't sysfs ABI change. Thanks. Marek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3776EC433F5 for ; Mon, 10 Jan 2022 10:24:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=oF2RbT7WOatGPzaVPxE9R8fl9DX7OtJrsSCK9hA3x3A=; b=oYjDrTmauYSm7D Sm4xSxLxrYwdrLNewTPjQf1NnEn9UqxqCFVNH3bVSJV2aOKxZWKU34FCaHKVLbTfmD7RAYXlwfxbo I5FBApe57vjmfu7t0pv++b4giag3Naq3Enp9c2ZYSRwOpJF6kmrwL7h+3uUpKLgYTbdzFZQYHgXLY coQofknDMa48cgpEg3Cb2QRZqoh8DYeLrMRqIzptmbFHP2WG5gLNVuG9K/ljbNdQ8o8t1ecdsA6/9 CG+9yNCtYD8PA7WTgE4LxdPzap6bHPVVRFCrTj80AUxIF/f5UcBdbh+uJgAQ0hH/VrsHevcW/80Oh f3A30um7tcg1bPSoSs+Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n6rpZ-00Al4w-0j; Mon, 10 Jan 2022 10:23:13 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n6rpV-00Al3t-7W for linux-arm-kernel@lists.infradead.org; Mon, 10 Jan 2022 10:23:10 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 77FACB815C3; Mon, 10 Jan 2022 10:23:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 06698C36AE9; Mon, 10 Jan 2022 10:23:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1641810186; bh=52SGtoSXoHH5/gXeIjcW4u1oqUamKPxuDGP8DWpswyk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=oopgaGtWWTvJOJd+5cECRJ3DZFgE28a/xrvInrVxjiTY6Jm8KD6qL1YrLC+UL7qm/ vGO40nuIh6hWP8g9By3gWBpPReklOQvb8gXvphuXIWPN9lpkH8BZS73X0LDYZbMxck rj78pjD+DaeTotMA+dcv+Kr1O8xRbtoEyxmxv8SB0KHjfuDANyCFGZ99t3Irhwxh1Y DI1OVVEXPX8zAvawKGFf9Y5MCX1pCReDBH+7YBMSTR5qIYpZab7JhoD/841enEE3bU SiC9Vn0XD6HMsCFVO0iyMkeOwlVMZgNPPh/fo9Ck6fQ6GP4zS6LRAs1NnwMeKmhN/t GjdfIznbRQMSQ== Date: Mon, 10 Jan 2022 11:23:01 +0100 From: Marek =?UTF-8?B?QmVow7pu?= To: Marc Zyngier Cc: Lorenzo Pieralisi , Bjorn Helgaas , pali@kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 23/23] PCI: aardvark: Make main irq_chip structure a static driver structure Message-ID: <20220110112301.7e13c716@thinkpad> In-Reply-To: References: <20220110015018.26359-1-kabel@kernel.org> <20220110015018.26359-24-kabel@kernel.org> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220110_022309_572237_FDFE441B X-CRM114-Status: GOOD ( 29.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCAxMCBKYW4gMjAyMiAwOToyODozOSArMDAwMApNYXJjIFp5bmdpZXIgPG1hekBrZXJu ZWwub3JnPiB3cm90ZToKCj4gT24gMjAyMi0wMS0xMCAwMTo1MCwgTWFyZWsgQmVow7puIHdyb3Rl Ogo+ID4gTWFyYyBaeW5naWVyIHNheXMgWzFdIHRoYXQgd2Ugc2hvdWxkIHVzZSBzdHJ1Y3QgaXJx X2NoaXAgYXMgYSBnbG9iYWwKPiA+IHN0YXRpYyBzdHJ1Y3QgaW4gdGhlIGRyaXZlci4gRXZlbiB0 aG91Z2ggdGhlIHN0cnVjdHVyZSBjdXJyZW50bHkKPiA+IGNvbnRhaW5zIGEgZHluYW1pYyBtZW1i ZXIgKHBhcmVudF9kZXZpY2UpLCBNYXJjIHNheXMgWzJdIHRoYXQgaGUgcGxhbnMKPiA+IHRvIGtp bGwgaXQgYW5kIG1ha2UgdGhlIHN0cnVjdHVyZSBjb21wbGV0ZWx5IHN0YXRpYy4KPiA+IAo+ID4g V2UgaGF2ZSBhbHJlYWR5IGNvbnZlcnRlZCBvdGhlcnMgaXJxX2NoaXAgc3RydWN0dXJlcyBpbiB0 aGlzIGRyaXZlciBpbgo+ID4gdGhpcyB3YXksIGJ1dCB3ZSBvbWl0dGVkIHRoaXMgb25lIGJlY2F1 c2UgdGhlIC5uYW1lIG1lbWJlciBpcwo+ID4gZHluYW1pY2FsbHkgY3JlYXRlZCBmcm9tIGRldmlj ZSdzIG5hbWUsIGFuZCB0aGUgbmFtZSBpcyBkaXNwbGF5ZWQgaW4KPiA+IHN5c2ZzLCBzbyBjaGFu Z2luZyBpdCB3b3VsZCBicmVhayBzeXNmcyBBQkkuCj4gPiAKPiA+IFRoZSByYXRpb25hbGUgZm9y IGNoYW5naW5nIHRoZSBuYW1lICh0byAiYWR2ay1JTlQiKSBpbiBzcGl0ZSBvZiBzeXNmcwo+ID4g QUJJLCBhbmQgdGh1cyBhbGxvd2luZyB0byBjb252ZXJ0IHRvIGEgc3RhdGljIHN0cnVjdHVyZSwg aXMgdGhhdCBhZnRlcgo+ID4gdGhlIG90aGVyIGNoYW5nZXMgd2UgbWFkZSBpbiB0aGlzIHNlcmll cywgdGhlIElSUSBjaGlwIGlzIGJhc2ljYWxseQo+ID4gc29tZXRoaW5nIGRpZmZlcmVudDogaXQg bm8gbG9nbmVyIGdlbmVyYXRlcyBFUlIgYW5kIFBNRSBpbnRlcnJ1cHRzIAo+ID4gKHRoZXkKPiA+ IGFyZSBnZW5lcmF0ZWQgYnkgZW11bGF0ZWQgYnJpZGdlJ3MgcnBfaXJxX2NoaXApLiAgCj4gCj4g VGhlcmUgaXMgbm8gJ2lzIHNwaXRlIG9mIHRoZSBBQkknLiBJZiB5b3UgZG9uJ3QgdW5kZXJzdGFu ZCB3aHkKPiB3ZSBkb24ndCBicmVhayB0aGUgQUJJLCB5b3UgaGF2ZSBhbiBldmVuIGJpZ2dlciBw cm9ibGVtLgo+IAo+IFNvIE5BSyB0byB0aGlzIHBhdGNoLCBub3cgYW5kIGZvcmV2ZXIuIEFueSBj aGFuZ2UgdG8gdGhlIHN0cnVjdHVyZSB0bwo+IG1ha2UgaXQgcmVhZC1vbmx5IG11c3QgYWxsb3cg dGhlIHByZXNlcnZhdGlvbiBvZiB0aGUgZXhpc3RpbmcgbmFtZXMKPiB3aGVuIHRoZXkgYXJlIGdl bmVyYXRlZCBieSB0aGUgZHJpdmVyLgoKRGVhciBNYXJjLAoKVGhhdCdzIHdoeSBJIHB1dCBpdCBh cyBhIGxhc3QgcGF0Y2ggaGVyZSA6KQoKSSBoYXZlIHRoZSBxdWVzdGlvbnMKCjEpIHRoZSBmaXJz dCBpcyB0aGF0IHRoaXMgZHJpdmVyIGhhcyBvbmx5IGV2ZXIgYmVlbiB1c2VkIG9uIEFybWFkYSAz N3h4LAogICB3aGVyZSB0aGVyZSBoYXMgYWx3YXlzIGJlZW4gb25seSBvbmUgUENJZSBjb250cm9s bGVyLCBhbmQgaXQncyBuYW1lCiAgIGFsd2F5cyB3YXMgZDAwNzAwMDAucGNpZSwgc28gdGhlIGly cV9jaGlwIHdhcyBhbHdheXMgY2FsbGVkCiAgIGQwMDcwMDAwLnBjaWUtaXJxLgogICBTbyB3ZSBj b3VsZCB0aGVvcmV0aWNhbGx5IGluZmVyIGZyb20gY29uZmlnIG9wdGlvbnMgaWYgd2UgYXJlCiAg IGJ1aWxkaW5nIGZvciBBcm1hZGEgMzd4eDogaWYgQVJNNjQgYW5kIEFSTUFEQV8zN1hYX0NMSyBj b25maWcgb3B0aW9ucwogICBhcmUgZW5hYmxlZCwgbWFrZSB0aGUgbmFtZSBkMDA3MDAwMC5wY2ll LWlycSwgb3RoZXJ3aXNlIGFkdmstSU5UID8KCjIpIEkgdHJpZWQgdG8gbG9vayBmb3IgdGhlIG5h bWUgZDAwNzAwMDAucGNpZS1pcnEgaW4gL3Byb2MgYW5kIC9zeXNmcywKICAgYnV0IGNvdWxkbid0 IGZpbmQgaXQgdGhlcmUgKG5vdCBpbiAvcHJvYy9pbnRlcnJ1cHRzIG5vciBhbnl3aGVyZQogICBl bHNlKS4gSXQgaXMgcG9zc2libGUgdGhhdCBJIG9taXR0ZWQgc29tZXRoaW5nLCBvciB0aGF0IHdp dGggb3RoZXIKICAgUENJZSBjYXJkIGl0IHdpbGwgc2hvdyB1cCB3aGVuIGNvcnJlc3BvbmRpbmcg ZHJpdmVyIGlzIGxvYWRlZC4KICAgQnV0IHRoZW9yZXRpY2FsbHksIGlmIEkgY291bGQgcHJvdmUg dGhhdCB1bnRpbCBub3cgdGhpcyBuZXZlcgogICBhcHBlYXJlZCBhbnl3aGVyZSBpbiBzeXNmcyBm b3Igc29tZSByZWFzb24sIHRoZW4gd2UgY291bGQgY2hhbmdlIGl0LAogICByaWdodD8gQmVjdWFz ZSB0aGF0IHdheSBpdCBpc24ndCBzeXNmcyBBQkkgY2hhbmdlLgoKVGhhbmtzLgoKTWFyZWsKCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1r ZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpo dHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJu ZWwK