From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90A2AC433F5 for ; Mon, 10 Jan 2022 15:19:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236088AbiAJPTf (ORCPT ); Mon, 10 Jan 2022 10:19:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45728 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236085AbiAJPTe (ORCPT ); Mon, 10 Jan 2022 10:19:34 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4ED3DC06173F for ; Mon, 10 Jan 2022 07:19:34 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 18D5CB81649 for ; Mon, 10 Jan 2022 15:19:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5C146C36AE5; Mon, 10 Jan 2022 15:19:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1641827971; bh=aZhQbEyF7vRdK8xCqH1U68jQTLsHNHruPWc3aZkJjzI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=I34LhhvfBl6iamTOVTEbL25MvVaLuiEDR4e88n5Hmp5kq7r0m+8oi04IFtuETWYxE nVg1BOL+PPyDFPoPAP7P/28YDQFVUTqxMQkjl7bVQH9HotaztFzm60n88U2lFtZevg XWQMr+zu/2jf02I5iL4vahkkZiCjMqYzWUS6pHtb0uQleII49dhGLsjSsn/r3RIraW CNiAutAqg4L3lliAdNIOgSRefm1dfamFfP1wS5+ZrO+d4VDYzLRGQckFde0gdleXmA tyFZUkENpcNXY8hBqCE2TtRkr7GX5PLb3Sjn1t1iDlg6sYHcv672ST7Y2eOTK398Nc IWaFtdhuDpqpA== Date: Mon, 10 Jan 2022 16:19:27 +0100 From: Marek =?UTF-8?B?QmVow7pu?= To: Marc Zyngier , Pali =?UTF-8?B?Um9ow6Fy?= Cc: Lorenzo Pieralisi , Bjorn Helgaas , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 23/23] PCI: aardvark: Make main irq_chip structure a static driver structure Message-ID: <20220110161927.64362d52@thinkpad> In-Reply-To: <87mtk3tzum.wl-maz@kernel.org> References: <20220110015018.26359-1-kabel@kernel.org> <20220110015018.26359-24-kabel@kernel.org> <20220110105324.jud6bzdtmoiuvyas@pali> <87mtk3tzum.wl-maz@kernel.org> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Mon, 10 Jan 2022 14:44:17 +0000 Marc Zyngier wrote: > On Mon, 10 Jan 2022 10:53:24 +0000, > Pali Roh=C3=A1r wrote: > >=20 > > On Monday 10 January 2022 09:28:39 Marc Zyngier wrote: =20 > > > On 2022-01-10 01:50, Marek Beh=C3=BAn wrote: =20 > > > > Marc Zyngier says [1] that we should use struct irq_chip as a global > > > > static struct in the driver. Even though the structure currently > > > > contains a dynamic member (parent_device), Marc says [2] that he pl= ans > > > > to kill it and make the structure completely static. > > > >=20 > > > > We have already converted others irq_chip structures in this driver= in > > > > this way, but we omitted this one because the .name member is > > > > dynamically created from device's name, and the name is displayed in > > > > sysfs, so changing it would break sysfs ABI. > > > >=20 > > > > The rationale for changing the name (to "advk-INT") in spite of sys= fs > > > > ABI, and thus allowing to convert to a static structure, is that af= ter > > > > the other changes we made in this series, the IRQ chip is basically > > > > something different: it no logner generates ERR and PME interrupts = (they > > > > are generated by emulated bridge's rp_irq_chip). =20 > > >=20 > > > There is no 'is spite of the ABI'. If you don't understand why > > > we don't break the ABI, you have an even bigger problem. > > >=20 > > > So NAK to this patch, now and forever. Any change to the structure to > > > make it read-only must allow the preservation of the existing names > > > when they are generated by the driver. =20 > >=20 > > Marc, you already presented that you do not like Armada 3720 platform > > and that you do not care about it. =20 >=20 > What I like or not is irrelevant here. What I ask for is that > userspace ABIs are not broken. >=20 > > But please do not slowdown development for this platform. =20 >=20 > That's quite an accusation. >=20 > > Arguments about ABIs, breaking it and similar are not relevant here as > > this current kernel implementation is broken. And has to be replaced by > > a working one. We are doing on it for more than year. > > > > It really does not make sense to try doing some backward compatibility > > with something which is broken by design and does not work. It just take > > lot of time without any value. > >=20 > > We really need to more forward and fix driver as in current state is > > PCIe on Armada 3720 unusable. =20 >=20 > This patch doesn't fix anything. It has the potential to break > userspace, and I'm not having any of it. You may not care about > backward compatibility, but this is thankfully *not* your pet > playground. >=20 > You can claim that I am doing a bad job. In which case, feel free to > submit a patch removing me from the MAINTAINER file, and we can have > that discussion. >=20 > In the meantime, I will continue to oppose these kind of patches that > pretend to 'fix' things without adding any value. >=20 > M. Dear Marc, that is why I put this patch as last patch of this series, so that it could be potentially dropped. I mostly agree with your points, Pali does not. Pali, let's not sabotage ourselves with needless arguments. Marc, Pali means well, but sometimes when he has different opinion, he can get quite argumentative. Let's ignore this patch for now. Marc, what do you think about the other patches? Did you have time to look at them? Thanks. Marek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1F148C433EF for ; Mon, 10 Jan 2022 15:20:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Pg0rmJRC11Tb87QY4nHv6skQbPw69u6Xd9mRuf9qeA4=; b=GE4yKkX+ZchZ+2 y91ky+dtnAUmFwbRxpn3h0QhZBnq2u55MtM1VKdIthQjrMtr8Jt/g1P7ePd9F8VFzE/mTdGYt6JVy s6TGPX/XyKxs3ZmwI6Kzum+qjPW3HfJrSxENVyEglhYbrBNGFNTfyM7SbXoBD2BFvW1LYCQ/WcH0l ProTT3pa8cmIWZUZvFu9ywwtJZI9mO1DRdX+ydFyzzFTazkf/w9tYiDPGpjd0waOk4L+UqFY3lyvN O7bWuynehpPiWmgDMAaU3PJpjgp6wNMkWpfVOamg3EVfEjqaco2Dq0T9UFyYoK4HR577PRLbi0NqD 7U4PYn047qaUB6B7oNXA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n6wSP-00C1eQ-Rn; Mon, 10 Jan 2022 15:19:38 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n6wSM-00C1d2-Az for linux-arm-kernel@lists.infradead.org; Mon, 10 Jan 2022 15:19:36 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 1443BB81661; Mon, 10 Jan 2022 15:19:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5C146C36AE5; Mon, 10 Jan 2022 15:19:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1641827971; bh=aZhQbEyF7vRdK8xCqH1U68jQTLsHNHruPWc3aZkJjzI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=I34LhhvfBl6iamTOVTEbL25MvVaLuiEDR4e88n5Hmp5kq7r0m+8oi04IFtuETWYxE nVg1BOL+PPyDFPoPAP7P/28YDQFVUTqxMQkjl7bVQH9HotaztFzm60n88U2lFtZevg XWQMr+zu/2jf02I5iL4vahkkZiCjMqYzWUS6pHtb0uQleII49dhGLsjSsn/r3RIraW CNiAutAqg4L3lliAdNIOgSRefm1dfamFfP1wS5+ZrO+d4VDYzLRGQckFde0gdleXmA tyFZUkENpcNXY8hBqCE2TtRkr7GX5PLb3Sjn1t1iDlg6sYHcv672ST7Y2eOTK398Nc IWaFtdhuDpqpA== Date: Mon, 10 Jan 2022 16:19:27 +0100 From: Marek =?UTF-8?B?QmVow7pu?= To: Marc Zyngier , Pali =?UTF-8?B?Um9ow6Fy?= Cc: Lorenzo Pieralisi , Bjorn Helgaas , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 23/23] PCI: aardvark: Make main irq_chip structure a static driver structure Message-ID: <20220110161927.64362d52@thinkpad> In-Reply-To: <87mtk3tzum.wl-maz@kernel.org> References: <20220110015018.26359-1-kabel@kernel.org> <20220110015018.26359-24-kabel@kernel.org> <20220110105324.jud6bzdtmoiuvyas@pali> <87mtk3tzum.wl-maz@kernel.org> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220110_071934_693538_36478FC4 X-CRM114-Status: GOOD ( 43.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCAxMCBKYW4gMjAyMiAxNDo0NDoxNyArMDAwMApNYXJjIFp5bmdpZXIgPG1hekBrZXJu ZWwub3JnPiB3cm90ZToKCj4gT24gTW9uLCAxMCBKYW4gMjAyMiAxMDo1MzoyNCArMDAwMCwKPiBQ YWxpIFJvaMOhciA8cGFsaUBrZXJuZWwub3JnPiB3cm90ZToKPiA+IAo+ID4gT24gTW9uZGF5IDEw IEphbnVhcnkgMjAyMiAwOToyODozOSBNYXJjIFp5bmdpZXIgd3JvdGU6ICAKPiA+ID4gT24gMjAy Mi0wMS0xMCAwMTo1MCwgTWFyZWsgQmVow7puIHdyb3RlOiAgCj4gPiA+ID4gTWFyYyBaeW5naWVy IHNheXMgWzFdIHRoYXQgd2Ugc2hvdWxkIHVzZSBzdHJ1Y3QgaXJxX2NoaXAgYXMgYSBnbG9iYWwK PiA+ID4gPiBzdGF0aWMgc3RydWN0IGluIHRoZSBkcml2ZXIuIEV2ZW4gdGhvdWdoIHRoZSBzdHJ1 Y3R1cmUgY3VycmVudGx5Cj4gPiA+ID4gY29udGFpbnMgYSBkeW5hbWljIG1lbWJlciAocGFyZW50 X2RldmljZSksIE1hcmMgc2F5cyBbMl0gdGhhdCBoZSBwbGFucwo+ID4gPiA+IHRvIGtpbGwgaXQg YW5kIG1ha2UgdGhlIHN0cnVjdHVyZSBjb21wbGV0ZWx5IHN0YXRpYy4KPiA+ID4gPiAKPiA+ID4g PiBXZSBoYXZlIGFscmVhZHkgY29udmVydGVkIG90aGVycyBpcnFfY2hpcCBzdHJ1Y3R1cmVzIGlu IHRoaXMgZHJpdmVyIGluCj4gPiA+ID4gdGhpcyB3YXksIGJ1dCB3ZSBvbWl0dGVkIHRoaXMgb25l IGJlY2F1c2UgdGhlIC5uYW1lIG1lbWJlciBpcwo+ID4gPiA+IGR5bmFtaWNhbGx5IGNyZWF0ZWQg ZnJvbSBkZXZpY2UncyBuYW1lLCBhbmQgdGhlIG5hbWUgaXMgZGlzcGxheWVkIGluCj4gPiA+ID4g c3lzZnMsIHNvIGNoYW5naW5nIGl0IHdvdWxkIGJyZWFrIHN5c2ZzIEFCSS4KPiA+ID4gPiAKPiA+ ID4gPiBUaGUgcmF0aW9uYWxlIGZvciBjaGFuZ2luZyB0aGUgbmFtZSAodG8gImFkdmstSU5UIikg aW4gc3BpdGUgb2Ygc3lzZnMKPiA+ID4gPiBBQkksIGFuZCB0aHVzIGFsbG93aW5nIHRvIGNvbnZl cnQgdG8gYSBzdGF0aWMgc3RydWN0dXJlLCBpcyB0aGF0IGFmdGVyCj4gPiA+ID4gdGhlIG90aGVy IGNoYW5nZXMgd2UgbWFkZSBpbiB0aGlzIHNlcmllcywgdGhlIElSUSBjaGlwIGlzIGJhc2ljYWxs eQo+ID4gPiA+IHNvbWV0aGluZyBkaWZmZXJlbnQ6IGl0IG5vIGxvZ25lciBnZW5lcmF0ZXMgRVJS IGFuZCBQTUUgaW50ZXJydXB0cyAodGhleQo+ID4gPiA+IGFyZSBnZW5lcmF0ZWQgYnkgZW11bGF0 ZWQgYnJpZGdlJ3MgcnBfaXJxX2NoaXApLiAgCj4gPiA+IAo+ID4gPiBUaGVyZSBpcyBubyAnaXMg c3BpdGUgb2YgdGhlIEFCSScuIElmIHlvdSBkb24ndCB1bmRlcnN0YW5kIHdoeQo+ID4gPiB3ZSBk b24ndCBicmVhayB0aGUgQUJJLCB5b3UgaGF2ZSBhbiBldmVuIGJpZ2dlciBwcm9ibGVtLgo+ID4g PiAKPiA+ID4gU28gTkFLIHRvIHRoaXMgcGF0Y2gsIG5vdyBhbmQgZm9yZXZlci4gQW55IGNoYW5n ZSB0byB0aGUgc3RydWN0dXJlIHRvCj4gPiA+IG1ha2UgaXQgcmVhZC1vbmx5IG11c3QgYWxsb3cg dGhlIHByZXNlcnZhdGlvbiBvZiB0aGUgZXhpc3RpbmcgbmFtZXMKPiA+ID4gd2hlbiB0aGV5IGFy ZSBnZW5lcmF0ZWQgYnkgdGhlIGRyaXZlci4gIAo+ID4gCj4gPiBNYXJjLCB5b3UgYWxyZWFkeSBw cmVzZW50ZWQgdGhhdCB5b3UgZG8gbm90IGxpa2UgQXJtYWRhIDM3MjAgcGxhdGZvcm0KPiA+IGFu ZCB0aGF0IHlvdSBkbyBub3QgY2FyZSBhYm91dCBpdC4gIAo+IAo+IFdoYXQgSSBsaWtlIG9yIG5v dCBpcyBpcnJlbGV2YW50IGhlcmUuIFdoYXQgSSBhc2sgZm9yIGlzIHRoYXQKPiB1c2Vyc3BhY2Ug QUJJcyBhcmUgbm90IGJyb2tlbi4KPiAKPiA+IEJ1dCBwbGVhc2UgZG8gbm90IHNsb3dkb3duIGRl dmVsb3BtZW50IGZvciB0aGlzIHBsYXRmb3JtLiAgCj4gCj4gVGhhdCdzIHF1aXRlIGFuIGFjY3Vz YXRpb24uCj4gCj4gPiBBcmd1bWVudHMgYWJvdXQgQUJJcywgYnJlYWtpbmcgaXQgYW5kIHNpbWls YXIgYXJlIG5vdCByZWxldmFudCBoZXJlIGFzCj4gPiB0aGlzIGN1cnJlbnQga2VybmVsIGltcGxl bWVudGF0aW9uIGlzIGJyb2tlbi4gQW5kIGhhcyB0byBiZSByZXBsYWNlZCBieQo+ID4gYSB3b3Jr aW5nIG9uZS4gV2UgYXJlIGRvaW5nIG9uIGl0IGZvciBtb3JlIHRoYW4geWVhci4KPiA+Cj4gPiBJ dCByZWFsbHkgZG9lcyBub3QgbWFrZSBzZW5zZSB0byB0cnkgZG9pbmcgc29tZSBiYWNrd2FyZCBj b21wYXRpYmlsaXR5Cj4gPiB3aXRoIHNvbWV0aGluZyB3aGljaCBpcyBicm9rZW4gYnkgZGVzaWdu IGFuZCBkb2VzIG5vdCB3b3JrLiBJdCBqdXN0IHRha2UKPiA+IGxvdCBvZiB0aW1lIHdpdGhvdXQg YW55IHZhbHVlLgo+ID4gCj4gPiBXZSByZWFsbHkgbmVlZCB0byBtb3JlIGZvcndhcmQgYW5kIGZp eCBkcml2ZXIgYXMgaW4gY3VycmVudCBzdGF0ZSBpcwo+ID4gUENJZSBvbiBBcm1hZGEgMzcyMCB1 bnVzYWJsZS4gIAo+IAo+IFRoaXMgcGF0Y2ggZG9lc24ndCBmaXggYW55dGhpbmcuIEl0IGhhcyB0 aGUgcG90ZW50aWFsIHRvIGJyZWFrCj4gdXNlcnNwYWNlLCBhbmQgSSdtIG5vdCBoYXZpbmcgYW55 IG9mIGl0LiBZb3UgbWF5IG5vdCBjYXJlIGFib3V0Cj4gYmFja3dhcmQgY29tcGF0aWJpbGl0eSwg YnV0IHRoaXMgaXMgdGhhbmtmdWxseSAqbm90KiB5b3VyIHBldAo+IHBsYXlncm91bmQuCj4gCj4g WW91IGNhbiBjbGFpbSB0aGF0IEkgYW0gZG9pbmcgYSBiYWQgam9iLiBJbiB3aGljaCBjYXNlLCBm ZWVsIGZyZWUgdG8KPiBzdWJtaXQgYSBwYXRjaCByZW1vdmluZyBtZSBmcm9tIHRoZSBNQUlOVEFJ TkVSIGZpbGUsIGFuZCB3ZSBjYW4gaGF2ZQo+IHRoYXQgZGlzY3Vzc2lvbi4KPiAKPiBJbiB0aGUg bWVhbnRpbWUsIEkgd2lsbCBjb250aW51ZSB0byBvcHBvc2UgdGhlc2Uga2luZCBvZiBwYXRjaGVz IHRoYXQKPiBwcmV0ZW5kIHRvICdmaXgnIHRoaW5ncyB3aXRob3V0IGFkZGluZyBhbnkgdmFsdWUu Cj4gCj4gCU0uCgpEZWFyIE1hcmMsCgp0aGF0IGlzIHdoeSBJIHB1dCB0aGlzIHBhdGNoIGFzIGxh c3QgcGF0Y2ggb2YgdGhpcyBzZXJpZXMsIHNvIHRoYXQgaXQKY291bGQgYmUgcG90ZW50aWFsbHkg ZHJvcHBlZC4KCkkgbW9zdGx5IGFncmVlIHdpdGggeW91ciBwb2ludHMsIFBhbGkgZG9lcyBub3Qu IFBhbGksIGxldCdzIG5vdCBzYWJvdGFnZQpvdXJzZWx2ZXMgd2l0aCBuZWVkbGVzcyBhcmd1bWVu dHMuIE1hcmMsIFBhbGkgbWVhbnMgd2VsbCwgYnV0IHNvbWV0aW1lcwp3aGVuIGhlIGhhcyBkaWZm ZXJlbnQgb3BpbmlvbiwgaGUgY2FuIGdldCBxdWl0ZSBhcmd1bWVudGF0aXZlLiBMZXQncwppZ25v cmUgdGhpcyBwYXRjaCBmb3Igbm93LgoKTWFyYywgd2hhdCBkbyB5b3UgdGhpbmsgYWJvdXQgdGhl IG90aGVyIHBhdGNoZXM/IERpZCB5b3UgaGF2ZSB0aW1lIHRvCmxvb2sgYXQgdGhlbT8KClRoYW5r cy4KCk1hcmVrCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmlu ZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9s aW51eC1hcm0ta2VybmVsCg==