From: Marcelo Tosatti <mtosatti@redhat.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: kvm@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] KVM: VMX: switch wakeup_vcpus_on_cpu_lock to raw spinlock
Date: Tue, 11 Jan 2022 09:13:17 -0300 [thread overview]
Message-ID: <20220111121317.GA8480@fuller.cnet> (raw)
In-Reply-To: <Yd1rw+XiUYFH1+OZ@linutronix.de>
On Tue, Jan 11, 2022 at 12:36:35PM +0100, Sebastian Andrzej Siewior wrote:
> On 2022-01-07 14:51:14 [-0300], Marcelo Tosatti wrote:
> >
> > wakeup_vcpus_on_cpu_lock is taken from hard interrupt context
> > (pi_wakeup_handler), therefore it cannot sleep.
> >
> > Switch it to a raw spinlock.
> >
> > Fixes:
> >
> > [41297.066254] BUG: scheduling while atomic: CPU 0/KVM/635218/0x00010001
> > [41297.066323] Preemption disabled at:
> > [41297.066324] [<ffffffff902ee47f>] irq_enter_rcu+0xf/0x60
> > [41297.066339] Call Trace:
> > [41297.066342] <IRQ>
> > [41297.066346] dump_stack_lvl+0x34/0x44
> > [41297.066353] ? irq_enter_rcu+0xf/0x60
> > [41297.066356] __schedule_bug.cold+0x7d/0x8b
> > [41297.066361] __schedule+0x439/0x5b0
> > [41297.066365] ? task_blocks_on_rt_mutex.constprop.0.isra.0+0x1b0/0x440
> > [41297.066369] schedule_rtlock+0x1e/0x40
> > [41297.066371] rtlock_slowlock_locked+0xf1/0x260
> > [41297.066374] rt_spin_lock+0x3b/0x60
> > [41297.066378] pi_wakeup_handler+0x31/0x90 [kvm_intel]
> > [41297.066388] sysvec_kvm_posted_intr_wakeup_ipi+0x9d/0xd0
> > [41297.066392] </IRQ>
> > [41297.066392] asm_sysvec_kvm_posted_intr_wakeup_ipi+0x12/0x20
> > ...
> >
> > Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
>
> so I have here v5.16 and no wakeup_vcpus_on_cpu_lock. It was also not
> removed so this patch is not intended for a previous kernel. Also
> checked next-20220111 and no wakeup_vcpus_on_cpu_lock.
>
> Sebastian
>
>
Sebastian,
The variable has been renamed on kvm.git/queue (sorry for not mentioning
that).
I suppose Paolo can integrate through kvm.git.
next prev parent reply other threads:[~2022-01-11 12:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-07 17:51 [PATCH] KVM: VMX: switch wakeup_vcpus_on_cpu_lock to raw spinlock Marcelo Tosatti
2022-01-11 11:36 ` Sebastian Andrzej Siewior
2022-01-11 12:13 ` Marcelo Tosatti [this message]
2022-01-18 16:24 ` Paolo Bonzini
2022-01-18 9:56 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220111121317.GA8480@fuller.cnet \
--to=mtosatti@redhat.com \
--cc=bigeasy@linutronix.de \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.