From: "Michael S. Tsirkin" <mst@redhat.com>
To: Si-Wei Liu <si-wei.liu@oracle.com>
Cc: lvivier@redhat.com, virtualization@lists.linux-foundation.org,
eperezma@redhat.com, elic@nvidia.com
Subject: Re: [PATCH 3/3] vdpa/mlx5: validate the queue pair value from driver
Date: Thu, 13 Jan 2022 02:00:08 -0500 [thread overview]
Message-ID: <20220113015815-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <1642050651-16197-4-git-send-email-si-wei.liu@oracle.com>
On Thu, Jan 13, 2022 at 12:10:51AM -0500, Si-Wei Liu wrote:
> Fixes: 52893733f2c5 ("vdpa/mlx5: Add multiqueue support")
> Signed-off-by: Si-Wei Liu<si-wei.liu@oracle.com>
Add motivation for change in the commit log.
> ---
> drivers/vdpa/mlx5/net/mlx5_vnet.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> index 46d4deb..491127f 100644
> --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c
> +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> @@ -1563,11 +1563,21 @@ static virtio_net_ctrl_ack handle_ctrl_mq(struct mlx5_vdpa_dev *mvdev, u8 cmd)
>
> switch (cmd) {
> case VIRTIO_NET_CTRL_MQ_VQ_PAIRS_SET:
> + /* This mq feature check aligns with pre-existing userspace implementation,
> + * although the spec doesn't mandate so.
And so ... why do we bother? what breaks if we don't?
> + */
> + if (!MLX5_FEATURE(mvdev, VIRTIO_NET_F_MQ))
> + break;
> +
this part is not described in the commit log at all.
is it intentional?
> read = vringh_iov_pull_iotlb(&cvq->vring, &cvq->riov, (void *)&mq, sizeof(mq));
> if (read != sizeof(mq))
> break;
>
> newqps = mlx5vdpa16_to_cpu(mvdev, mq.virtqueue_pairs);
> + if (newqps < VIRTIO_NET_CTRL_MQ_VQ_PAIRS_MIN ||
> + newqps > mlx5_vdpa_max_qps(mvdev->max_vqs))
> + break;
> +
> if (ndev->cur_num_vqs == 2 * newqps) {
> status = VIRTIO_NET_OK;
> break;
> --
> 1.8.3.1
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2022-01-13 7:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-13 5:10 [PATCH 0/3] fixes for mlx5_vdpa multiqueue support Si-Wei Liu
2022-01-13 5:10 ` [PATCH 1/3] vdpa: factor out vdpa_set_features_unlocked for vdpa internal use Si-Wei Liu
2022-01-13 6:46 ` Michael S. Tsirkin
2022-01-13 5:10 ` [PATCH 2/3] vdpa/mlx5: set_features should nack MQ if no CTRL_VQ Si-Wei Liu
2022-01-13 6:57 ` Michael S. Tsirkin
2022-01-14 8:51 ` Si-Wei Liu
2022-01-14 12:53 ` Michael S. Tsirkin
[not found] ` <20220113080914.GB1312@mtl-vdi-166.wap.labs.mlnx>
2022-01-14 6:08 ` Jason Wang
2022-01-13 5:10 ` [PATCH 3/3] vdpa/mlx5: validate the queue pair value from driver Si-Wei Liu
2022-01-13 7:00 ` Michael S. Tsirkin [this message]
2022-01-14 9:19 ` Si-Wei Liu
2022-01-13 7:03 ` [PATCH 0/3] fixes for mlx5_vdpa multiqueue support Michael S. Tsirkin
2022-01-14 9:24 ` Si-Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220113015815-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=elic@nvidia.com \
--cc=eperezma@redhat.com \
--cc=lvivier@redhat.com \
--cc=si-wei.liu@oracle.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.