From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1F7AC433EF for ; Thu, 13 Jan 2022 11:14:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231733AbiAMLO5 (ORCPT ); Thu, 13 Jan 2022 06:14:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47828 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231464AbiAMLO4 (ORCPT ); Thu, 13 Jan 2022 06:14:56 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 50F58C06173F for ; Thu, 13 Jan 2022 03:14:56 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 183F0B81ECF for ; Thu, 13 Jan 2022 11:14:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8F468C36AE3; Thu, 13 Jan 2022 11:14:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1642072493; bh=UmxdOvMmvJBXNOBXxoAPwTQsMP+oo3Tk5o3sNl2s06M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ibc3aLJmYY5CwJ9+ySxYdxAwG03NmPcv48qZyfLnvS9uuSfoF7LtB//exqcApsKpY vXRty1BSdQ81K84HrUDhFdgCTY9fu/Ug1QtTn5S4p5VMBfZvRQdwP4u229jS36dxIl XDgbl+r9y46Fmu10T3glxQxaXqwMzq04FzmQ+X627epcQQlIg9DdGp5WPtDNMyegew 8G+TRZ+eDw8hs0icurdlP6i061X0lQvL30Uh0cTH27hM351Np9D/86V5pti/xD/NZE UZes2dLE87dvSzMDgVCyzFXDLWN4JNb/ky/Ba2E8torpaBWhpmhjFFy2UFM1HqlNpW M84g9aKxApTWQ== Received: by pali.im (Postfix) id E6F05732; Thu, 13 Jan 2022 12:14:50 +0100 (CET) Date: Thu, 13 Jan 2022 12:14:50 +0100 From: Pali =?utf-8?B?Um9ow6Fy?= To: Stefan Roese Cc: linux-pci@vger.kernel.org, Bharat Kumar Gogada , Bjorn Helgaas , Michal Simek Subject: Re: [PATCH v3 1/2] PCI/portdrv: Add option to setup IRQs for platform-specific Service Errors Message-ID: <20220113111450.pgacviso7sn627ln@pali> References: <20220113104939.1635398-1-sr@denx.de> <20220113104939.1635398-2-sr@denx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220113104939.1635398-2-sr@denx.de> User-Agent: NeoMutt/20180716 Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Thursday 13 January 2022 11:49:38 Stefan Roese wrote: > From: Bharat Kumar Gogada > > As per section 6.2.4.1.2, 6.2.6 in PCIe r4.0 (and later versions), > platform-specific System Errors like AER can be delivered via platform- > specific interrupt lines. > > This patch adds the init_platform_service_irqs() hook to struct > pci_host_bridge, making it possible that platforms may implement this > function to hook IRQs for these platform-specific System Errors, like > AER. > > If these platform-specific service IRQs have been successfully > installed via pcie_init_platform_service_irqs(), > pcie_init_service_irqs() is skipped. > > Signed-off-by: Bharat Kumar Gogada > Signed-off-by: Stefan Roese > Cc: Bjorn Helgaas > Cc: Pali Rohár > Cc: Michal Simek > --- > drivers/pci/pcie/portdrv_core.c | 43 ++++++++++++++++++++++++++++++++- > include/linux/pci.h | 2 ++ > 2 files changed, 44 insertions(+), 1 deletion(-) > > diff --git a/drivers/pci/pcie/portdrv_core.c b/drivers/pci/pcie/portdrv_core.c > index bda630889f95..4dab74ff4368 100644 > --- a/drivers/pci/pcie/portdrv_core.c > +++ b/drivers/pci/pcie/portdrv_core.c > @@ -190,6 +190,31 @@ static int pcie_init_service_irqs(struct pci_dev *dev, int *irqs, int mask) > return 0; > } > > +/** > + * pcie_init_platform_service_irqs - initialize platform service irqs for > + * platform-specific System Errors > + * @dev: PCI Express port to handle > + * @irqs: Array of irqs to populate > + * @mask: Bitmask of capabilities > + * > + * Return value: true/false for platforms service irqs installed or not > + */ > +static bool pcie_init_platform_service_irqs(struct pci_dev *dev, > + int *irqs, int mask) > +{ > + struct pci_host_bridge *bridge; > + > + if (pci_pcie_type(dev) == PCI_EXP_TYPE_ROOT_PORT) { I think that this check is not needed as it is done before calling pcie_init_platform_service_irqs() function. > + bridge = pci_find_host_bridge(dev->bus); > + if (bridge && bridge->init_platform_service_irqs) { > + bridge->init_platform_service_irqs(dev, irqs, mask); > + return true; Suggestion: What about "return bridge->init_platform_service_irqs(...);" ? This could allow callback function to fail... > + } > + } > + > + return false; > +} > + > /** > * get_port_device_capability - discover capabilities of a PCI Express port > * @dev: PCI Express port to examine > @@ -318,6 +343,7 @@ int pcie_port_device_register(struct pci_dev *dev) > int irqs[PCIE_PORT_DEVICE_MAXSERVICES] = { > [0 ... PCIE_PORT_DEVICE_MAXSERVICES-1] = -1 > }; > + bool plat_irqs; > > /* Enable PCI Express port device */ > status = pci_enable_device(dev); > @@ -342,7 +368,22 @@ int pcie_port_device_register(struct pci_dev *dev) > irq_services |= PCIE_PORT_SERVICE_DPC; > irq_services &= capabilities; > > - if (irq_services) { > + /* > + * Some platforms have dedicated interrupts from root complex to > + * interrupt controller for PCIe platform-specific System Errors > + * like AER/PME etc., check if the platform registered with any such > + * IRQ. > + */ > + if (pci_pcie_type(dev) == PCI_EXP_TYPE_ROOT_PORT) { > + plat_irqs = pcie_init_platform_service_irqs(dev, irqs, > + capabilities); > + } > + > + /* > + * Only install service irqs, when the platform-specific hook was > + * unsuccessful > + */ > + if (irq_services && !plat_irqs) { > /* > * Initialize service IRQs. Don't use service devices that > * require interrupts if there is no way to generate them. > diff --git a/include/linux/pci.h b/include/linux/pci.h > index 18a75c8e615c..a0bcc8062b91 100644 > --- a/include/linux/pci.h > +++ b/include/linux/pci.h > @@ -554,6 +554,8 @@ struct pci_host_bridge { > u8 (*swizzle_irq)(struct pci_dev *, u8 *); /* Platform IRQ swizzler */ > int (*map_irq)(const struct pci_dev *, u8, u8); > void (*release_fn)(struct pci_host_bridge *); > + void (*init_platform_service_irqs)(struct pci_dev *dev, int *irqs, > + int plat_mask); > void *release_data; > unsigned int ignore_reset_delay:1; /* For entire hierarchy */ > unsigned int no_ext_tags:1; /* No Extended Tags */ > -- > 2.34.1 >