From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E0989C433F5 for ; Thu, 13 Jan 2022 14:15:52 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 370C983420; Thu, 13 Jan 2022 15:15:51 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="W/C9FUxB"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id D9CE38342C; Thu, 13 Jan 2022 15:15:49 +0100 (CET) Received: from mail-qt1-x82a.google.com (mail-qt1-x82a.google.com [IPv6:2607:f8b0:4864:20::82a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 342BE83434 for ; Thu, 13 Jan 2022 15:15:44 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x82a.google.com with SMTP id y17so6944910qtx.9 for ; Thu, 13 Jan 2022 06:15:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=jr0nRv0dXgIc9JwzQ6mq2CxvDlsQJh3idxwYZ2FbNsg=; b=W/C9FUxBFELai3UvnrNY00n0F0LQs5sBK0joaLmMAcFDcNA6skXAMeh28M5FZG00gG N5WnzBzezkmSiDzUS26TvofXbluJXQN8GOUs2KhsQVhVeWDjmw6c0mIF0imU3uTSVMUR c2RhL4Y5yoT4nARoNoUclM0oU5K1p7XqBWiac= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=jr0nRv0dXgIc9JwzQ6mq2CxvDlsQJh3idxwYZ2FbNsg=; b=sQyEgfugrczxBFhEx14V+Aav2/jbxokHXg3naifOEHtOQTElgIf3kwkNHlJQFr2OD5 IMM/MoJTcUBcx2HLjyhLKLHXdQ1mpdLQI5jHNbNRkPeBaecO5X9glLFwsh9B8++v6THe 25MwQUsfipaYPp02UnZB0t6RArRb2vSC1sBicNriuy6Z0m1fGDUp1IqJ+i80MI44wEzk zAdFPTXLayR9w8gBJlLFTyNdxr6zXb42vH1Yynt15SobVqF/Jt1TurdAGclCwvlIEYEZ x90aqZwxJ5jBURGAlM6sKBrk5CudS997hRA7/1Knty94YvRQKYtTOf2UqgtcyUqhX1Bn IFfQ== X-Gm-Message-State: AOAM531audMjnDZdAtLZY34oCmwTA1QwjdGV7E8Jvx1x+xpZnnCeS6E3 8hkUBZyPuDbckkoeVD/Ot3C8sQ== X-Google-Smtp-Source: ABdhPJwTwqrWXlgje49dpXrBSCAY6jZBXq0MElhDllKBUZDu2FzxdOaIvijeswh2DnGaODPGvNW0fg== X-Received: by 2002:a05:622a:15c9:: with SMTP id d9mr3681544qty.85.1642083342900; Thu, 13 Jan 2022 06:15:42 -0800 (PST) Received: from bill-the-cat (2603-6081-7b01-cbda-2440-966a-5ce3-c6d0.res6.spectrum.com. [2603:6081:7b01:cbda:2440:966a:5ce3:c6d0]) by smtp.gmail.com with ESMTPSA id v7sm1782978qkp.30.2022.01.13.06.15.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Jan 2022 06:15:42 -0800 (PST) Date: Thu, 13 Jan 2022 09:15:39 -0500 From: Tom Rini To: Aswath Govindraju Cc: u-boot@lists.denx.de, Wolfgang Denk , Hari Nagalla , David Huang , Keerthy , Dave Gerlach , Suman Anna , Nishanth Menon , Tero Kristo , Kishon Vijay Abraham I , Vignesh Raghavendra , Christian Hewitt , Tim Harvey , Peter Robinson , Kever Yang , Neil Armstrong , Fabio Estevam , Andre Przywara , Jaehoon Chung , Sean Anderson , Lukasz Majewski Subject: Re: [PATCH v2 09/20] ram: k3-ddrss: Add support for J721S2 SoC Message-ID: <20220113141539.GQ9207@bill-the-cat> References: <20220111075545.1880-1-a-govindraju@ti.com> <20220111075545.1880-10-a-govindraju@ti.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="GJhwMzjEpQseGxPa" Content-Disposition: inline In-Reply-To: <20220111075545.1880-10-a-govindraju@ti.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --GJhwMzjEpQseGxPa Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jan 11, 2022 at 01:25:34PM +0530, Aswath Govindraju wrote: > From: David Huang >=20 > Add support for DDR subsystem in J721S2 SoC. >=20 > Signed-off-by: David Huang > Signed-off-by: Aswath Govindraju > --- > drivers/ram/Kconfig | 12 ++++++++++++ > drivers/ram/k3-ddrss/Makefile | 4 ++++ > 2 files changed, 16 insertions(+) >=20 > diff --git a/drivers/ram/Kconfig b/drivers/ram/Kconfig > index a79594d35198..2b6b1d57aaaa 100644 > --- a/drivers/ram/Kconfig > +++ b/drivers/ram/Kconfig > @@ -63,6 +63,7 @@ choice > prompt "K3 DDRSS Arch Support" > =20 > default K3_J721E_DDRSS if SOC_K3_J721E > + default K3_J721S2_DDRSS if SOC_K3_J721S2 > default K3_AM64_DDRSS if SOC_K3_AM642 > =20 > config K3_J721E_DDRSS > @@ -75,6 +76,17 @@ config K3_J721E_DDRSS > Enabling this config adds support for the DDR memory controller > on J721E family of SoCs. > =20 > +config K3_J721S2_DDRSS > + bool "Enable J721S2 DRSS support" > + help > + The J721S2 DDR subsystem comprises DDR controller, DDR PHY and > + wrapper logic to integrate these blocks in the device. The DDR > + subsystem is used to provide an interface to external SDRAM > + devices which can be utilized for storing program or data. > + Enabling this config adds support for the DDR memory controller > + on J721S2 family of SoCs. > + > + > config K3_AM64_DDRSS > bool "Enable AM64 DDRSS support" > help > diff --git a/drivers/ram/k3-ddrss/Makefile b/drivers/ram/k3-ddrss/Makefile > index 8be00118f501..d30bf5ec6dab 100644 > --- a/drivers/ram/k3-ddrss/Makefile > +++ b/drivers/ram/k3-ddrss/Makefile > @@ -15,3 +15,7 @@ ccflags-$(CONFIG_K3_AM64_DDRSS) +=3D -Idrivers/ram/k3-d= drss/16bit/ > obj-$(CONFIG_K3_J721E_DDRSS) +=3D lpddr4_32bit.o > obj-$(CONFIG_K3_J721E_DDRSS) +=3D lpddr4_32bit_ctl_regs_rw_masks.o > ccflags-$(CONFIG_K3_J721E_DDRSS) +=3D -Idrivers/ram/k3-ddrss/32bit/ > + > +obj-$(CONFIG_K3_J721S2_DDRSS) +=3D lpddr4_32bit.o > +obj-$(CONFIG_K3_J721S2_DDRSS) +=3D lpddr4_32bit_ctl_regs_rw_masks.o > +ccflags-$(CONFIG_K3_J721S2_DDRSS) +=3D -Idrivers/ram/k3-ddrss/32bit/ I'm not seeing a difference between J721E and J721S2 here. This tells me the symbol should be renamed and almost certainly select'd by the SoC and not asked to the user, as well. --=20 Tom --GJhwMzjEpQseGxPa Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmHgNAsACgkQFHw5/5Y0 tywjfgv/Tm/L/qcj0zF1u61m2orcjVha7PQEkk72ittz1LLF3olG+PJnvisPFkyC rCuGdn1Owv62cfNIXdCXroVmVKZKYSGgrl0vZ1Vk99GcjtQrDOB1mJ3PMKpIybeI xgH9p7sXK65S0NujuxbociCdMyvOtcmWOidDlZhpTPp+JpXmqH4gVxzMiuw2Cqu6 Fs9fq3hQwKPlsZ3jW2suK2YOxyxOU80PsBfK7pcVQOn1vHoRRHEFaQrrDZn1nZpM uqY+AhBtDbvA3io5Yfs5D/Bhs7sJ1k9+0Iu3I0JHjFFa5L3SAtqYTJPInMkPiBaY XPFHDydTVrw+jPRBxSoU0l+5XWyfRf8iRPA24vu56WutWNhJGtE5LOAvmVCGD7i2 tQ6LmAFnlpsRXieEqknR6hIRYz0l6wB7O2fohb74aRRqjWfBPUn6wDf4qQKcwl9F 5yzfb3ZQEHFq2+p+ExOyadqvuOMRKF+DQX/f6/6UVVhar40KFB5Xbu9yQNDLmGbz jisJsYBQ =NY+p -----END PGP SIGNATURE----- --GJhwMzjEpQseGxPa--