From: "Pali Rohár" <pali@kernel.org>
To: "Simon Glass" <sjg@chromium.org>,
"Alexandru Gagniuc" <mr.nuke.me@gmail.com>,
"Yann Dirson" <yann@blade-group.com>, "Stefan Roese" <sr@denx.de>,
"Marek Behún" <marek.behun@nic.cz>
Cc: u-boot@lists.denx.de
Subject: [PATCH] mkimage: Call verify_header after writing image to disk
Date: Thu, 13 Jan 2022 15:42:22 +0100 [thread overview]
Message-ID: <20220113144222.25162-1-pali@kernel.org> (raw)
If image backend provides verify_header callback then call it after writing
image to disk. This ensures that written image is correct.
Signed-off-by: Pali Rohár <pali@kernel.org>
---
tools/mkimage.c | 34 ++++++++++++++++++++++++++++++++++
1 file changed, 34 insertions(+)
diff --git a/tools/mkimage.c b/tools/mkimage.c
index fbe883ce3620..2d282630787c 100644
--- a/tools/mkimage.c
+++ b/tools/mkimage.c
@@ -698,6 +698,40 @@ int main(int argc, char **argv)
exit (EXIT_FAILURE);
}
+ if (tparams->verify_header) {
+ ifd = open(params.imagefile, O_RDONLY | O_BINARY);
+ if (ifd < 0) {
+ fprintf(stderr, "%s: Can't open %s: %s\n",
+ params.cmdname, params.imagefile,
+ strerror(errno));
+ exit(EXIT_FAILURE);
+ }
+
+ if (fstat(ifd, &sbuf) < 0) {
+ fprintf(stderr, "%s: Can't stat %s: %s\n",
+ params.cmdname, params.imagefile, strerror(errno));
+ exit(EXIT_FAILURE);
+ }
+ params.file_size = sbuf.st_size;
+
+ map_len = sbuf.st_size;
+ ptr = mmap(0, sbuf.st_size, PROT_READ, MAP_SHARED, ifd, 0);
+ if (ptr == MAP_FAILED) {
+ fprintf(stderr, "%s: Can't map %s: %s\n",
+ params.cmdname, params.imagefile, strerror(errno));
+ exit(EXIT_FAILURE);
+ }
+
+ if (tparams->verify_header((unsigned char *)ptr, sbuf.st_size, ¶ms) != 0) {
+ fprintf(stderr, "%s: Failed to verify header of %s\n",
+ params.cmdname, params.imagefile);
+ exit(EXIT_FAILURE);
+ }
+
+ (void)munmap((void *)ptr, map_len);
+ close(ifd);
+ }
+
exit (EXIT_SUCCESS);
}
--
2.20.1
next reply other threads:[~2022-01-13 14:43 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-13 14:42 Pali Rohár [this message]
2022-01-13 19:30 ` [PATCH] mkimage: Call verify_header after writing image to disk Simon Glass
2022-01-14 17:34 ` [PATCH v2] tools: " Pali Rohár
2022-01-15 9:46 ` Stefan Roese
2022-01-15 18:01 ` Simon Glass
2022-01-21 21:21 ` Tom Rini
2022-01-22 1:44 ` Pali Rohár
2022-01-22 2:15 ` Tom Rini
2022-01-22 16:31 ` Pali Rohár
2022-01-22 16:34 ` Pali Rohár
2022-01-22 16:35 ` Tom Rini
2022-02-02 9:06 ` Priyanka Jain
2022-02-15 19:52 ` Pali Rohár
2022-02-16 9:33 ` Priyanka Jain
2022-02-16 14:17 ` Z.Q. Hou
2022-03-06 11:50 ` Pali Rohár
2022-03-06 13:58 ` Tom Rini
2022-03-08 13:42 ` Tom Rini
2022-03-14 1:51 ` 陈健洪
2022-03-14 1:54 ` 陈健洪
2022-04-06 15:55 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220113144222.25162-1-pali@kernel.org \
--to=pali@kernel.org \
--cc=marek.behun@nic.cz \
--cc=mr.nuke.me@gmail.com \
--cc=sjg@chromium.org \
--cc=sr@denx.de \
--cc=u-boot@lists.denx.de \
--cc=yann@blade-group.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.