All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: Peter Seiderer <ps.report@gmx.net>,
	Julien Corjon <corjon.j@ecagroup.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/qt5/qt5base: disable broken qmake sysrootify
Date: Thu, 13 Jan 2022 20:44:51 +0100	[thread overview]
Message-ID: <20220113204451.23849f67@windsurf> (raw)
In-Reply-To: <20220112203939.606775-1-james.hilliard1@gmail.com>

Hello James,

On Wed, 12 Jan 2022 13:39:39 -0700
James Hilliard <james.hilliard1@gmail.com> wrote:

> Currently the qmake gcc sysrootify path logic causes issues with
> per-package directories, disable automatic gcc sysroot for qt5base
> install and override all qt.conf paths manually to point to their
> correct locations.
> 
> Redirect HostData to STAGING_DIR as mkspecs need to be available there
> instead of the HOST_DIR for cross compilation to work.
> 
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
>  package/qt5/qt5base/qt.conf.in | 18 +++++++++++++++---
>  package/qt5/qt5base/qt5base.mk |  2 ++
>  2 files changed, 17 insertions(+), 3 deletions(-)

Do you have a bit more details on what this changing, i.e how this is
making things better?

I have no doubt that it can make things better, but it would be useful
in the commit log to have extra details on what specific
details/aspects it is fixing/improving.

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-01-13 19:45 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-12 20:39 [Buildroot] [PATCH 1/1] package/qt5/qt5base: disable broken qmake sysrootify James Hilliard
2022-01-13 19:44 ` Thomas Petazzoni [this message]
2022-01-14  4:51   ` James Hilliard
2022-01-15 22:37 ` Peter Seiderer
2022-01-16  1:34   ` James Hilliard
2022-01-16  5:08   ` James Hilliard
2022-01-16  9:19     ` Peter Seiderer
2022-01-16 10:28       ` James Hilliard
2022-01-16 10:45         ` James Hilliard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220113204451.23849f67@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@buildroot.org \
    --cc=corjon.j@ecagroup.com \
    --cc=james.hilliard1@gmail.com \
    --cc=ps.report@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.